Adding talk permissions clarity (#1281)

* The permission labels 'Can work with and change proposals' and 'Is a reviewer'
were unclear about the actual permissions granted. Updated labels and added help text.

* Add Talk permissions section to team create/edit page

* Add migration for updated team permission labels

* Update migration to match simplified permission labels

* Add JavaScript to show/hide Review settings

* consistence_last_line

* Update app/eventyay/eventyay_common/templates/eventyay_common/organizers/teams/team_edit.html

* Fix template syntax error and add deprecation notice

* added proper migration

---------

Co-authored-by: Mario Behling <mb@mariobehling.de>

Author: ArnavBallinCode

app/eventyay/base/migrations/0004_update_team_permission_labels.py

@@ -0,0 +1,31 @@
+# Generated migration for updating Team permission labels and help text
+
+from django.db import migrations, models
+
+
+class Migration(migrations.Migration):
+
+    dependencies = [
+        ('base', '0003_alter_question_type'),
+    ]
+
+    operations = [
+        migrations.AlterField(
+            model_name='team',
+            name='can_change_submissions',
+            field=models.BooleanField(
+                default=False,
+                help_text='Can edit submission details, change proposal states (accept/reject/waitlist), manage submission metadata, and oversee the review workflow. This provides full management permissions beyond standard reviewing.',
+                verbose_name='Reviewer Manager — can edit and manage submissions'
+            ),
+        ),
+        migrations.AlterField(
+            model_name='team',
+            name='is_reviewer',
+            field=models.BooleanField(
+                default=False,
+                help_text='Can review and provide feedback on submissions but cannot edit details or change submission states.',
+                verbose_name='Reviewer — can only review submissions'
+            ),
+        ),
+    ]

app/eventyay/base/models/organizer.py

@@ -421,8 +421,22 @@ class Meta:
 
     # From Talk
     limit_tracks = models.ManyToManyField(to='Track', verbose_name=_('Limit to tracks'), blank=True)
-    can_change_submissions = models.BooleanField(default=False, verbose_name=_('Can work with and change proposals'))
-    is_reviewer = models.BooleanField(default=False, verbose_name=_('Is a reviewer'))
+    can_change_submissions = models.BooleanField(
+        default=False,
+        verbose_name=_('Reviewer Manager — can edit and manage submissions'),
+        help_text=_(
+            'Can edit submission details, change proposal states (accept/reject/waitlist), '
+            'manage submission metadata, and oversee the review workflow. '
+            'This provides full management permissions beyond standard reviewing.'
+        )
+    )
+    is_reviewer = models.BooleanField(
+        default=False,
+        verbose_name=_('Reviewer — can only review submissions'),
+        help_text=_(
+            'Can review and provide feedback on submissions but cannot edit details or change submission states.'
+        )
+    )
     force_hide_speaker_names = models.BooleanField(
         verbose_name=_('Always hide speaker names'),
         help_text=_(

app/eventyay/control/templates/pretixcontrol/organizers/team_edit.html

@@ -1,6 +1,8 @@
 {% extends "pretixcontrol/organizers/base.html" %}
 {% load i18n %}
 {% load bootstrap3 %}
+{# DEPRECATED: Team management has moved to /common area. This template is kept for backward compatibility only. #}
+{# For the active implementation with conditional field visibility, see: eventyay_common/organizers/teams/team_edit.html #}
 {% block inner %}
     {% if team %}
         <h1>{% trans "Team:" %} {{ team.name }}</h1>
@@ -39,6 +41,14 @@ <h1>{% trans "Create a new team" %}</h1>
             {% bootstrap_field form.can_view_vouchers layout="control" %}
             {% bootstrap_field form.can_change_vouchers layout="control" %}
         </fieldset>
+        <fieldset>
+            <legend>{% trans "Talk permissions" %}</legend>
+            {% bootstrap_field form.can_change_submissions layout="control" %}
+            {% bootstrap_field form.is_reviewer layout="control" %}
+            {% bootstrap_field form.force_hide_speaker_names layout="control" %}
+            {% bootstrap_field form.limit_tracks layout="control" %}
+        </fieldset>
+
         <div class="form-group submit-group">
             <button type="submit" class="btn btn-primary btn-save">
                 {% trans "Save" %}

app/eventyay/eventyay_common/templates/eventyay_common/organizers/teams/team_edit.html

@@ -64,4 +64,25 @@ <h1>{% translate "Create a new team" %}</h1>
             </button>
         </div>
     </form>
+
+    <script>
+        $(document).ready(function() {
+            // Function to toggle review settings visibility
+            function toggleReviewSettings() {
+                if ($('#id_is_reviewer').is(':checked')) {
+                    $('#review-settings').show();
+                } else {
+                    $('#review-settings').hide();
+                }
+            }
+
+            // Toggle on page load
+            toggleReviewSettings();
+
+            // Toggle when checkbox changes
+            $('#id_is_reviewer').change(function() {
+                toggleReviewSettings();
+            });
+        });
+    </script>
 {% endblock %}