fix: remove direct modification of providers

Author: abhinavs1920

lib/screens/settings_page.dart

@@ -64,7 +64,11 @@ class SettingsPage extends ConsumerWidget {
                   } else {
                     showDialog(
                       context: context,
-                      builder: (context) => const ProxySettingsDialog(),
+                      builder: (context) => ProxySettingsDialog(
+                        onUpdateProxySettings: (newProxy) {
+                          ref.read(settingsProvider.notifier).update(proxySettings: newProxy);
+                        },
+                      ),
                     );
                   }
                 },

lib/widgets/proxy_settings_dialog.dart

@@ -4,7 +4,8 @@ import 'package:apidash_core/models/models.dart';
 import 'package:apidash/providers/settings_providers.dart';
 
 class ProxySettingsDialog extends ConsumerStatefulWidget {
-  const ProxySettingsDialog({super.key});
+  final void Function(ProxySettings?) onUpdateProxySettings;
+  const ProxySettingsDialog({super.key, required this.onUpdateProxySettings});
 
   @override
   ConsumerState<ProxySettingsDialog> createState() =>
@@ -45,11 +46,11 @@ class _ProxySettingsDialogState extends ConsumerState<ProxySettingsDialog> {
         username: _usernameController.text.isEmpty ? null : _usernameController.text,
         password: _passwordController.text.isEmpty ? null : _passwordController.text,
       );
-      ref.read(settingsProvider.notifier).update(proxySettings: newProxy);
+      widget.onUpdateProxySettings(newProxy);
       Navigator.of(context).pop();
     }
     else{
-      ref.read(settingsProvider.notifier).update(proxySettings: null);
+      widget.onUpdateProxySettings(null);
     }
   }
 

pubspec.lock

@@ -5,18 +5,23 @@ packages:
     dependency: transitive
     description:
       name: _fe_analyzer_shared
-      sha256: dc27559385e905ad30838356c5f5d574014ba39872d732111cd07ac0beff4c57
+      sha256: "16e298750b6d0af7ce8a3ba7c18c69c3785d11b15ec83f6dcd0ad2a0009b3cab"
       url: "https://pub.dev"
     source: hosted
-    version: "80.0.0"
+    version: "76.0.0"
+  _macros:
+    dependency: transitive
+    description: dart
+    source: sdk
+    version: "0.3.3"
   analyzer:
     dependency: transitive
     description:
       name: analyzer
-      sha256: "192d1c5b944e7e53b24b5586db760db934b177d4147c42fbca8c8c5f1eb8d11e"
+      sha256: "1f14db053a8c23e260789e9b0980fa27f2680dd640932cae5e1137cce0e46e1e"
       url: "https://pub.dev"
     source: hosted
-    version: "7.3.0"
+    version: "6.11.0"
   ansi_styles:
     dependency: transitive
     description:
@@ -390,22 +395,6 @@ packages:
       url: "https://pub.dev"
     source: hosted
     version: "1.3.2"
-  fetch_api:
-    dependency: transitive
-    description:
-      name: fetch_api
-      sha256: "97f46c25b480aad74f7cc2ad7ccba2c5c6f08d008e68f95c1077286ce243d0e6"
-      url: "https://pub.dev"
-    source: hosted
-    version: "2.2.0"
-  fetch_client:
-    dependency: transitive
-    description:
-      name: fetch_client
-      sha256: "9666ee14536778474072245ed5cba07db81ae8eb5de3b7bf4a2d1e2c49696092"
-      url: "https://pub.dev"
-    source: hosted
-    version: "1.1.2"
   ffi:
     dependency: transitive
     description:
@@ -977,7 +966,15 @@ packages:
       sha256: c5fa04a80a620066c15cf19cc44773e19e9b38e989ff23ea32e5903ef1015950
       url: "https://pub.dev"
     source: hosted
-    version: "3.3.1"
+    version: "3.2.0"
+  macros:
+    dependency: transitive
+    description:
+      name: macros
+      sha256: "1d9e801cd66f7ea3663c45fc708450db1fa57f988142c64289142c9b7ee80656"
+      url: "https://pub.dev"
+    source: hosted
+    version: "0.1.3-main.0"
   markdown:
     dependency: "direct main"
     description:
@@ -1983,5 +1980,5 @@ packages:
     source: hosted
     version: "2.2.2"
 sdks:
-  dart: ">=3.7.0 <3.999.0"
-  flutter: ">=3.29.0"
+  dart: ">=3.7.0-0 <3.999.0"
+  flutter: ">=3.24.2"

test/widgets/proxy_settings_dialog_test.dart

@@ -2,6 +2,7 @@ import 'package:flutter/material.dart';
 import 'package:flutter_test/flutter_test.dart';
 import 'package:flutter_riverpod/flutter_riverpod.dart';
 import 'package:apidash/widgets/proxy_settings_dialog.dart';
+import 'package:apidash/providers/settings_providers.dart';
 
 void main() {
   testWidgets('ProxySettingsDialog shows correctly', (WidgetTester tester) async {
@@ -14,7 +15,13 @@ void main() {
                 onPressed: () {
                   showDialog(
                     context: context,
-                    builder: (context) => const ProxySettingsDialog(),
+                    builder: (context) => ProxySettingsDialog(
+                      onUpdateProxySettings: (newProxy) {
+                        final ref = ProviderScope.containerOf(context);
+                        final notifier = ref.read(settingsProvider.notifier);
+                        notifier.update(proxySettings: newProxy);
+                      },
+                    ),
                   );
                 },
                 child: const Text('Show Dialog'),
@@ -48,7 +55,13 @@ void main() {
                 onPressed: () {
                   showDialog(
                     context: context,
-                    builder: (context) => const ProxySettingsDialog(),
+                    builder: (context) => ProxySettingsDialog(
+                      onUpdateProxySettings: (newProxy) {
+                        final ref = ProviderScope.containerOf(context);
+                        final notifier = ref.read(settingsProvider.notifier);
+                        notifier.update(proxySettings: newProxy);
+                      },
+                    ),
                   );
                 },
                 child: const Text('Show Dialog'),
@@ -87,7 +100,13 @@ void main() {
                 onPressed: () {
                   showDialog(
                     context: context,
-                    builder: (context) => const ProxySettingsDialog(),
+                    builder: (context) => ProxySettingsDialog(
+                      onUpdateProxySettings: (newProxy) {
+                        final ref = ProviderScope.containerOf(context);
+                        final notifier = ref.read(settingsProvider.notifier);
+                        notifier.update(proxySettings: newProxy);
+                      },
+                    ),
                   );
                 },
                 child: const Text('Show Dialog'),