chore: use const for event types

Author: fguery

internal/connectors/engine/activities/outbox_publisher.go

@@ -45,18 +45,17 @@ func (a Activities) OutboxPublishPendingEvents(ctx context.Context, limit int) e
 	return nil
 }
 
-// todo use consts
 func (a Activities) processOutboxEvent(ctx context.Context, event models.OutboxEvent) error {
 	switch event.EventType {
-	case "account.saved":
+	case models.OUTBOX_EVENT_ACCOUNT_SAVED:
 		return a.publishAccountEvent(ctx, event)
-	case "balance.saved":
+	case models.OUTBOX_EVENT_BALANCE_SAVED:
 		return a.publishBalanceEvent(ctx, event)
-	case "payment.saved":
+	case models.OUTBOX_EVENT_PAYMENT_SAVED:
 		return a.publishPaymentEvent(ctx, event)
-	case "payment.deleted":
+	case models.OUTBOX_EVENT_PAYMENT_DELETED:
 		return a.publishPaymentDeletedEvent(ctx, event)
-	case "bank_account.saved":
+	case models.OUTBOX_EVENT_BANK_ACCOUNT_SAVED:
 		return a.publishBankAccountEvent(ctx, event)
 	default:
 		return fmt.Errorf("unknown event type: %s", event.EventType)

internal/models/outbox.go

@@ -14,6 +14,15 @@ const (
 	OUTBOX_STATUS_FAILED  OutboxEventStatus = "failed"
 )
 
+// Outbox event type constants
+const (
+	OUTBOX_EVENT_ACCOUNT_SAVED     = "account.saved"
+	OUTBOX_EVENT_BALANCE_SAVED     = "balance.saved"
+	OUTBOX_EVENT_PAYMENT_SAVED     = "payment.saved"
+	OUTBOX_EVENT_PAYMENT_DELETED   = "payment.deleted"
+	OUTBOX_EVENT_BANK_ACCOUNT_SAVED = "bank_account.saved"
+)
+
 const MaxOutboxRetries = 5
 
 type OutboxEvent struct {

internal/storage/accounts.go

@@ -110,7 +110,7 @@ func (s *store) AccountsUpsert(ctx context.Context, accounts []models.Account) e
 
 		cid := account.ConnectorID
 		outboxEvent := models.OutboxEvent{
-			EventType:      "account.saved",
+			EventType:      models.OUTBOX_EVENT_ACCOUNT_SAVED,
 			EntityID:       account.ID.String(),
 			Payload:        payloadBytes,
 			CreatedAt:      time.Now().UTC().Time,

internal/storage/balances.go

@@ -81,7 +81,7 @@ func (s *store) BalancesUpsert(ctx context.Context, balances []models.Balance) e
 			}
 
 			outboxEvent := models.OutboxEvent{
-				EventType:      "balance.saved",
+				EventType:      models.OUTBOX_EVENT_BALANCE_SAVED,
 				EntityID:       balance.AccountID.String(),
 				Payload:        payloadBytes,
 				CreatedAt:      time.Now().UTC(),

internal/storage/bank_accounts.go

@@ -146,7 +146,7 @@ func (s *store) BankAccountsUpsert(ctx context.Context, ba models.BankAccount) e
 		}
 
 		outboxEvent := models.OutboxEvent{
-			EventType:      "bank_account.saved",
+			EventType:      models.OUTBOX_EVENT_BANK_ACCOUNT_SAVED,
 			EntityID:       bankAccountModel.ID.String(),
 			Payload:        payloadBytes,
 			CreatedAt:      time.Now().UTC(),

internal/storage/payments.go

@@ -231,7 +231,7 @@ func (s *store) PaymentsUpsert(ctx context.Context, payments []models.Payment) e
 			// Convert adjustment back to model to get idempotency key
 			adjustmentModel := toPaymentAdjustmentModels(adj)
 			outboxEvent := models.OutboxEvent{
-				EventType:      "payment.saved",
+				EventType:      models.OUTBOX_EVENT_PAYMENT_SAVED,
 				EntityID:       payment.ID.String(),
 				Payload:        payloadBytes,
 				CreatedAt:      time.Now().UTC(),
@@ -386,6 +386,7 @@ func (s *store) PaymentsDelete(ctx context.Context, id models.PaymentID) error {
 	return e("failed to delete payment", err)
 }
 
+// PaymentsDeleteFromReference TODO this deletion method is the only one emiting outbox events. Others did not either before using outbox events.
 func (s *store) PaymentsDeleteFromReference(ctx context.Context, reference string, connectorID models.ConnectorID) error {
 	tx, err := s.db.BeginTx(ctx, &sql.TxOptions{})
 	if err != nil {
@@ -437,13 +438,13 @@ func (s *store) PaymentsDeleteFromReference(ctx context.Context, reference strin
 	}
 
 	outboxEvent := models.OutboxEvent{
-		EventType:      "payment.deleted",
+		EventType:      models.OUTBOX_EVENT_PAYMENT_DELETED,
 		EntityID:       paymentID.String(),
 		Payload:        payloadBytes,
 		CreatedAt:      time.Now().UTC(),
 		Status:         models.OUTBOX_STATUS_PENDING,
 		ConnectorID:    &connectorID,
-		IdempotencyKey: fmt.Sprintf("delete:%s", paymentID.String()), // TODO this looks made up?
+		IdempotencyKey: fmt.Sprintf("delete:%s", paymentID.String()),
 	}
 
 	if err = s.OutboxEventsInsert(ctx, tx, []models.OutboxEvent{outboxEvent}); err != nil {