fix: relax assets regex (#1059)

* test: added regression tests. (You never know)

* feat: relaxed pattern

Author: ascandone

pkg/assets/asset.go

@@ -4,7 +4,7 @@ import (
 	"regexp"
 )
 
-const Pattern = `[A-Z][A-Z0-9]{0,16}(\/\d{1,6})?`
+const Pattern = `[A-Z][A-Z0-9]{0,16}(_[A-Z]{1,16})?(\/\d{1,6})?`
 
 var Regexp = regexp.MustCompile("^" + Pattern + "$")
 

pkg/assets/asset_test.go

@@ -0,0 +1,36 @@
+package assets_test
+
+import (
+	"testing"
+
+	"github.com/formancehq/ledger/pkg/assets"
+	"github.com/stretchr/testify/require"
+)
+
+func TestValidAssets(t *testing.T) {
+	require.True(t, assets.IsValid("A"))
+	require.True(t, assets.IsValid("USD"))
+	require.True(t, assets.IsValid("USD123"))
+	require.True(t, assets.IsValid("USD/2"))
+	require.True(t, assets.IsValid("USD/1234"))
+	require.True(t, assets.IsValid("EUR/00"))
+
+	require.True(t, assets.IsValid("EUR_COL"))
+	require.True(t, assets.IsValid("EUR_COL/12"))
+}
+
+func TestInvalidAsset(t *testing.T) {
+	require.False(t, assets.IsValid(""))
+	require.False(t, assets.IsValid("1"))
+	require.False(t, assets.IsValid("!"))
+	require.False(t, assets.IsValid("@s"))
+	require.False(t, assets.IsValid("/2"))
+	require.False(t, assets.IsValid("USD/"))
+	require.False(t, assets.IsValid("A//2"))
+	require.False(t, assets.IsValid("a"))
+
+	require.False(t, assets.IsValid("EUR_"))
+	require.False(t, assets.IsValid("_"))
+	require.False(t, assets.IsValid("_C"))
+	require.False(t, assets.IsValid("A_/2"))
+}