Merge pull request #21 from fog/dependency-constraints

Remove Dependencies Version constraint

Author: plribeiro3000

.gitignore

@@ -1,10 +1,23 @@
-/.bundle/
-/.yardoc
-/Gemfile.lock
-/_yardoc/
-/coverage/
-/doc/
-/pkg/
-/spec/reports/
-/tmp/
-*~
+*.gem
+*.rbc
+.bundle
+.config
+.yardoc
+Gemfile.lock
+InstalledFiles
+_yardoc
+coverage
+doc/
+lib/bundler/man
+pkg
+rdoc
+spec/reports
+test/tmp
+test/version_tmp
+tmp
+*.bundle
+*.so
+*.o
+*.a
+mkmf.log
+gemfiles/*.lock

.rubocop.yml

@@ -1,5 +1,32 @@
-AllCops:
-  Exclude:
-    - bin/**/*
+inherit_from: .rubocop_todo.yml
 
-# inherit_from: .rubocop_todo.yml
+Style/Documentation:
+  Enabled: false
+
+Metrics/MethodLength:
+  Enabled: false
+
+Metrics/AbcSize:
+  Enabled: false
+
+Metrics/LineLength:
+  Max: 120
+
+Metrics/BlockLength:
+  Enabled: false
+
+Layout/ExtraSpacing:
+  AllowForAlignment: false
+  ForceEqualSignAlignment: false
+
+Style/ExpandPathArguments:
+  Enabled: false
+
+Metrics/CyclomaticComplexity:
+  Enabled: false
+
+Naming/VariableName:
+  Enabled: false
+
+Lint/UnderscorePrefixedVariableName:
+  Enabled: false

.rubocop_todo.yml

@@ -1,32 +1,37 @@
 # This configuration was generated by
 # `rubocop --auto-gen-config`
-# on 2016-05-12 13:44:44 +0800 using RuboCop version 0.40.0.
+# on 2018-06-22 19:29:12 -0300 using RuboCop version 0.57.2.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
 # versions of RuboCop, may require this file to be generated again.
 
+# Offense count: 1
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyleAlignWith, AutoCorrect, Severity.
+# SupportedStylesAlignWith: start_of_line, def
+Layout/DefEndAlignment:
+  Exclude:
+    - 'lib/fog/aliyun/requests/storage/put_object.rb'
+
+# Offense count: 5
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyleAlignWith, AutoCorrect, Severity.
+# SupportedStylesAlignWith: keyword, variable, start_of_line
+Layout/EndAlignment:
+  Exclude:
+    - 'lib/fog/aliyun/compute.rb'
+    - 'lib/fog/aliyun/models/storage/file.rb'
+    - 'lib/fog/aliyun/requests/compute/create_server.rb'
+    - 'lib/fog/aliyun/storage.rb'
+
 # Offense count: 4
 # Configuration parameters: AllowSafeAssignment.
 Lint/AssignmentInCondition:
   Exclude:
     - 'lib/fog/aliyun/requests/compute/create_server.rb'
     - 'lib/fog/aliyun/requests/compute/delete_server.rb'
 
-# Offense count: 1
-# Cop supports --auto-correct.
-# Configuration parameters: AlignWith, SupportedStyles, AutoCorrect.
-# SupportedStyles: start_of_line, def
-Lint/DefEndAlignment:
-  Enabled: false
-
-# Offense count: 5
-# Cop supports --auto-correct.
-# Configuration parameters: AlignWith, SupportedStyles, AutoCorrect.
-# SupportedStyles: keyword, variable, start_of_line
-Lint/EndAlignment:
-  Enabled: false
-
 # Offense count: 4
 Lint/RandOne:
   Exclude:
@@ -35,19 +40,19 @@ Lint/RandOne:
     - 'lib/fog/aliyun/requests/compute/list_servers.rb'
     - 'lib/fog/aliyun/requests/compute/list_vrouters.rb'
 
-# Offense count: 127
-Lint/UnderscorePrefixedVariableName:
-  Enabled: false
-
 # Offense count: 1
 Lint/UnreachableCode:
   Exclude:
     - 'lib/fog/aliyun/models/storage/directory.rb'
 
-# Offense count: 38
+# Offense count: 26
+Lint/UriEscapeUnescape:
+  Enabled: false
+
+# Offense count: 37
 Lint/UselessAssignment:
   Exclude:
-    - 'lib/fog/aliyun.rb'
+    - 'lib/fog/aliyun/requests/compute/create_server.rb'
     - 'lib/fog/aliyun/requests/compute/list_disks.rb'
     - 'lib/fog/aliyun/requests/compute/list_security_groups.rb'
     - 'lib/fog/aliyun/requests/storage/delete_object.rb'
@@ -62,30 +67,17 @@ Lint/UselessAssignment:
     - 'lib/fog/aliyun/requests/storage/put_object.rb'
     - 'lib/fog/aliyun/storage.rb'
 
-# Offense count: 78
-Metrics/AbcSize:
-  Max: 100
-
-# Offense count: 5
+# Offense count: 7
 # Configuration parameters: CountComments.
 Metrics/ClassLength:
   Max: 154
 
-# Offense count: 18
-Metrics/CyclomaticComplexity:
-  Max: 15
-
-# Offense count: 257
-# Configuration parameters: AllowHeredoc, AllowURI, URISchemes.
+# Offense count: 87
+# Configuration parameters: AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, IgnoredPatterns.
 # URISchemes: http, https
 Metrics/LineLength:
   Max: 247
 
-# Offense count: 110
-# Configuration parameters: CountComments.
-Metrics/MethodLength:
-  Max: 97
-
 # Offense count: 1
 # Configuration parameters: CountKeywordArgs.
 Metrics/ParameterLists:
@@ -95,20 +87,45 @@ Metrics/ParameterLists:
 Metrics/PerceivedComplexity:
   Max: 19
 
+# Offense count: 7
+# Configuration parameters: EnforcedStyle.
+# SupportedStyles: snake_case, camelCase
+Naming/MethodName:
+  Exclude:
+    - 'lib/fog/aliyun/compute.rb'
+    - 'lib/fog/aliyun/requests/storage/get_bucket.rb'
+
+# Offense count: 48
+# Configuration parameters: MinNameLength, AllowNamesEndingInNumbers, AllowedNames, ForbiddenNames.
+# AllowedNames: io, id, to, by, on, in, at
+Naming/UncommunicativeMethodParamName:
+  Enabled: false
+
+# Offense count: 5
+Performance/Caller:
+  Exclude:
+    - 'lib/fog/aliyun/models/compute/images.rb'
+    - 'lib/fog/aliyun/models/compute/snapshots.rb'
+    - 'lib/fog/aliyun/models/compute/volumes.rb'
+    - 'lib/fog/aliyun/models/compute/vpcs.rb'
+    - 'lib/fog/aliyun/models/compute/vrouters.rb'
+
 # Offense count: 1
 Style/ClassVars:
   Exclude:
     - 'lib/fog/bin/aliyun.rb'
 
-# Offense count: 138
-Style/Documentation:
-  Enabled: false
-
 # Offense count: 7
-# Configuration parameters: EnforcedStyle, SupportedStyles.
-# SupportedStyles: for, each
+# Configuration parameters: EnforcedStyle.
+# SupportedStyles: each, for
 Style/For:
-  Enabled: false
+  Exclude:
+    - 'lib/fog/aliyun/models/storage/files.rb'
+    - 'lib/fog/aliyun/requests/compute/list_images.rb'
+    - 'lib/fog/aliyun/requests/compute/list_route_tables.rb'
+    - 'lib/fog/aliyun/requests/compute/list_servers.rb'
+    - 'lib/fog/aliyun/requests/compute/list_vrouters.rb'
+    - 'lib/fog/aliyun/requests/storage/put_object.rb'
 
 # Offense count: 4
 # Configuration parameters: AllowedVariables.
@@ -119,12 +136,21 @@ Style/GlobalVars:
     - 'lib/fog/aliyun/models/compute/vrouter.rb'
     - 'lib/fog/aliyun/models/compute/vswitch.rb'
 
-# Offense count: 2
+# Offense count: 11
 # Configuration parameters: MinBodyLength.
 Style/GuardClause:
   Exclude:
+    - 'lib/fog/aliyun/models/compute/security_groups.rb'
+    - 'lib/fog/aliyun/models/compute/snapshots.rb'
+    - 'lib/fog/aliyun/models/compute/volumes.rb'
+    - 'lib/fog/aliyun/models/storage/file.rb'
+    - 'lib/fog/aliyun/requests/compute/delete_security_group.rb'
+    - 'lib/fog/aliyun/requests/compute/delete_server.rb'
     - 'lib/fog/aliyun/requests/compute/delete_vpc.rb'
+    - 'lib/fog/aliyun/requests/compute/delete_vpn_connection.rb'
+    - 'lib/fog/aliyun/requests/compute/delete_vpn_customergateway.rb'
     - 'lib/fog/aliyun/requests/compute/delete_vswitch.rb'
+    - 'lib/fog/aliyun/requests/compute/list_security_group_rules.rb'
 
 # Offense count: 2
 Style/IdenticalConditionalBranches:
@@ -136,14 +162,16 @@ Style/IfInsideElse:
   Exclude:
     - 'lib/fog/aliyun/models/compute/security_group_rule.rb'
 
-# Offense count: 4
-# Configuration parameters: EnforcedStyle, SupportedStyles.
-# SupportedStyles: snake_case, camelCase
-Style/MethodName:
-  Enabled: false
+# Offense count: 2
+Style/MultipleComparison:
+  Exclude:
+    - 'lib/fog/aliyun/requests/storage/get_object_http_url.rb'
+    - 'lib/fog/aliyun/requests/storage/get_object_https_url.rb'
 
-# Offense count: 741
-# Configuration parameters: EnforcedStyle, SupportedStyles.
-# SupportedStyles: snake_case, camelCase
-Style/VariableName:
-  Enabled: false
+# Offense count: 1
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle, AllowInnerSlashes.
+# SupportedStyles: slashes, percent_r, mixed
+Style/RegexpLiteral:
+  Exclude:
+    - 'lib/fog/aliyun/models/storage/files.rb'

Gemfile

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 source 'https://rubygems.org'
 
 # Specify your gem's dependencies in fog-aliyun.gemspec

Rakefile

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'bundler/gem_tasks'
 require 'rspec/core/rake_task'
 

bin/console

@@ -1,7 +1,8 @@
 #!/usr/bin/env ruby
+# frozen_string_literal: true
 
-require "bundler/setup"
-require "fog/aliyun"
+require 'bundler/setup'
+require 'fog/aliyun'
 
 # You can add fixtures and/or initialization code here to make experimenting
 # with your gem easier. You can also use a different console, if you like.
@@ -10,5 +11,5 @@ require "fog/aliyun"
 # require "pry"
 # Pry.start
 
-require "irb"
+require 'irb'
 IRB.start

fog-aliyun.gemspec

@@ -1,33 +1,34 @@
-# coding: utf-8
+# frozen_string_literal: true
+
 lib = File.expand_path('../lib', __FILE__)
 $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 require 'fog/aliyun/version'
 
 Gem::Specification.new do |spec|
-  spec.name          = 'fog-aliyun'
-  spec.version       = Fog::Aliyun::VERSION
-  spec.authors       = ['Qinsi Deng, Jianxun Li, Jane Han']
-  spec.email         = ['dengqinsi@sina.com']
+  spec.name = 'fog-aliyun'
+  spec.version = Fog::Aliyun::VERSION
+  spec.authors = ['Qinsi Deng, Jianxun Li, Jane Han']
+  spec.email = ['dengqinsi@sina.com']
 
-  spec.summary       = 'Fog provider for Aliyun Web Services.'
-  spec.description   = 'As a FOG provider, fog-aliyun support aliyun OSS/ECS. It will support more aliyun services later.'
-  spec.homepage      = 'https://github.com/fog/fog-aliyun'
-  spec.license       = 'MIT'
+  spec.summary = 'Fog provider for Aliyun Web Services.'
+  spec.description = 'As a FOG provider, fog-aliyun support aliyun OSS/ECS. It will support more aliyun services later.'
+  spec.homepage = 'https://github.com/fog/fog-aliyun'
+  spec.license = 'MIT'
 
-  spec.files         = `git ls-files -z`.split("\x0").reject { |f| f.match(%r{^(test|spec|features)/}) }
-  spec.bindir        = 'exe'
-  spec.executables   = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
+  spec.files = `git ls-files -z`.split("\x0").reject { |f| f.match(%r{^(test|spec|features)/}) }
+  spec.bindir = 'exe'
+  spec.executables = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
   spec.require_paths = ['lib']
 
-  spec.add_development_dependency 'bundler', '~> 1.10'
-  spec.add_development_dependency 'rake', '~> 10.0'
-  spec.add_development_dependency 'rspec', '~> 3.3'
-  spec.add_development_dependency 'rubocop', '~> 0.49.0'
+  spec.add_development_dependency 'bundler'
   spec.add_development_dependency 'mime-types', '~> 2.6', '>= 2.6.2'
   spec.add_development_dependency 'pry-nav'
+  spec.add_development_dependency 'rake'
+  spec.add_development_dependency 'rspec'
+  spec.add_development_dependency 'rubocop'
 
-  spec.add_dependency 'fog-core',  '~> 1.27'
-  spec.add_dependency 'fog-json',  '~> 1.0'
+  spec.add_dependency 'fog-core'
+  spec.add_dependency 'fog-json'
   spec.add_dependency 'ipaddress', '~> 0.8'
   spec.add_dependency 'xml-simple', '~> 1.1'
 end

lib/fog/aliyun.rb

@@ -1,14 +1,16 @@
+# frozen_string_literal: true
+
 require 'fog/core'
 require 'fog/json'
 require 'fog/aliyun/version'
 
 module Fog
   module Compute
-    ret = autoload :Aliyun, 'fog/aliyun/compute'
+    autoload :Aliyun, 'fog/aliyun/compute'
   end
 
   module Storage
-    ret = autoload :Aliyun, 'fog/aliyun/storage'
+    autoload :Aliyun, 'fog/aliyun/storage'
   end
 
   module Aliyun