Skip to content

Commit b8fa552

Browse files
Fix the ordering
1 parent 569947c commit b8fa552

File tree

6 files changed

+15
-4
lines changed

6 files changed

+15
-4
lines changed

packages/google_maps_flutter/google_maps_flutter_ios/ios/Classes/FGMGroundOverlayController.m

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -72,6 +72,8 @@ + (void)updateGroundOverlay:(GMSGroundOverlay *)groundOverlay
7272
groundOverlay.position = CLLocationCoordinate2DMake(platformGroundOverlay.position.latitude,
7373
platformGroundOverlay.position.longitude);
7474
}
75+
76+
// This must be done last, to avoid visual flickers of default property values.
7577
groundOverlay.map = platformGroundOverlay.visible ? mapView : nil;
7678
}
7779

packages/google_maps_flutter/google_maps_flutter_ios/ios/Classes/FLTGoogleMapHeatmapController.m

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -86,6 +86,7 @@ + (void)updateHeatmap:(GMUHeatmapTileLayer *)heatmapTileLayer
8686
}
8787

8888
// The map must be set each time for options to update.
89+
// This must be done last, to avoid visual flickers of default property values.
8990
heatmapTileLayer.map = mapView;
9091
}
9192
@end

packages/google_maps_flutter/google_maps_flutter_ios/ios/Classes/FLTGoogleMapTileOverlayController.m

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,11 +47,13 @@ - (void)updateFromPlatformTileOverlay:(FGMPlatformTileOverlay *)overlay {
4747
+ (void)updateTileLayer:(GMSTileLayer *)tileLayer
4848
fromPlatformTileOverlay:(FGMPlatformTileOverlay *)platformOverlay
4949
withMapView:(GMSMapView *)mapView {
50-
tileLayer.map = platformOverlay.visible ? mapView : nil;
5150
tileLayer.opacity = 1.0 - platformOverlay.transparency;
5251
tileLayer.zIndex = (int)platformOverlay.zIndex;
5352
tileLayer.fadeIn = platformOverlay.fadeIn;
5453
tileLayer.tileSize = platformOverlay.tileSize;
54+
55+
// This must be done last, to avoid visual flickers of default property values.
56+
tileLayer.map = platformOverlay.visible ? mapView : nil;
5557
}
5658

5759
@end

packages/google_maps_flutter/google_maps_flutter_ios/ios/Classes/GoogleMapCircleController.m

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,13 +45,15 @@ + (void)updateCircle:(GMSCircle *)circle
4545
fromPlatformCircle:(FGMPlatformCircle *)platformCircle
4646
withMapView:(GMSMapView *)mapView {
4747
circle.tappable = platformCircle.consumeTapEvents;
48-
circle.map = platformCircle.visible ? mapView : nil;
4948
circle.zIndex = platformCircle.zIndex;
5049
circle.position = FGMGetCoordinateForPigeonLatLng(platformCircle.center);
5150
circle.radius = platformCircle.radius;
5251
circle.strokeColor = FGMGetColorForRGBA(platformCircle.strokeColor);
5352
circle.strokeWidth = platformCircle.strokeWidth;
5453
circle.fillColor = FGMGetColorForRGBA(platformCircle.fillColor);
54+
55+
// This must be done last, to avoid visual flickers of default property values.
56+
circle.map = platformCircle.visible ? mapView : nil;
5557
}
5658

5759
@end

packages/google_maps_flutter/google_maps_flutter_ios/ios/Classes/GoogleMapPolygonController.m

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,14 +53,16 @@ + (void)updatePolygon:(GMSPolygon *)polygon
5353
fromPlatformPolygon:(FGMPlatformPolygon *)platformPolygon
5454
withMapView:(GMSMapView *)mapView {
5555
polygon.tappable = platformPolygon.consumesTapEvents;
56-
polygon.map = platformPolygon.visible ? mapView : nil;
5756
polygon.zIndex = (int)platformPolygon.zIndex;
5857
polygon.path = FGMGetPathFromPoints(FGMGetPointsForPigeonLatLngs(platformPolygon.points));
5958
polygon.holes =
6059
FMGPathHolesFromLocationHoles(FGMGetHolesForPigeonLatLngArrays(platformPolygon.holes));
6160
polygon.fillColor = FGMGetColorForRGBA(platformPolygon.fillColor);
6261
polygon.strokeColor = FGMGetColorForRGBA(platformPolygon.strokeColor);
6362
polygon.strokeWidth = platformPolygon.strokeWidth;
63+
64+
// This must be done last, to avoid visual flickers of default property values.
65+
polygon.map = platformPolygon.visible ? mapView : nil;
6466
}
6567

6668
@end

packages/google_maps_flutter/google_maps_flutter_ios/ios/Classes/GoogleMapPolylineController.m

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,6 @@ + (void)updatePolyline:(GMSPolyline *)polyline
4242
fromPlatformPolyline:(FGMPlatformPolyline *)platformPolyline
4343
withMapView:(GMSMapView *)mapView {
4444
polyline.tappable = platformPolyline.consumesTapEvents;
45-
polyline.map = platformPolyline.visible ? mapView : nil;
4645
polyline.zIndex = (int)platformPolyline.zIndex;
4746
GMSMutablePath *path =
4847
FGMGetPathFromPoints(FGMGetPointsForPigeonLatLngs(platformPolyline.points));
@@ -54,6 +53,9 @@ + (void)updatePolyline:(GMSPolyline *)polyline
5453
polyline.spans =
5554
GMSStyleSpans(path, FGMGetStrokeStylesFromPatterns(platformPolyline.patterns, strokeColor),
5655
FGMGetSpanLengthsFromPatterns(platformPolyline.patterns), kGMSLengthRhumb);
56+
57+
// This must be done last, to avoid visual flickers of default property values.
58+
polyline.map = platformPolyline.visible ? mapView : nil;
5759
}
5860

5961
@end

0 commit comments

Comments
 (0)