Skip to content

Commit e5d0cba

Browse files
committed
refactor(app_configuration): adjust layout of general app config form
- Remove outer Padding widget - Change main Column to be full-size to fill the parent Row - Update description text to match the section content (app URLs)
1 parent c7b7a61 commit e5d0cba

File tree

1 file changed

+40
-43
lines changed

1 file changed

+40
-43
lines changed

lib/app_configuration/widgets/general_app_config_form.dart

Lines changed: 40 additions & 43 deletions
Original file line numberDiff line numberDiff line change
@@ -66,54 +66,51 @@ class _GeneralAppConfigFormState extends State<GeneralAppConfigForm> {
6666
final appConfig = widget.remoteConfig.app;
6767
final generalConfig = appConfig.general;
6868

69-
return Padding(
70-
padding: const EdgeInsets.all(AppSpacing.lg),
71-
child: Column(
72-
crossAxisAlignment: CrossAxisAlignment.start,
73-
children: [
74-
Text(
75-
l10n.generalAppConfigDescription,
76-
style: Theme.of(context).textTheme.bodySmall?.copyWith(
77-
color: Theme.of(context).colorScheme.onSurface.withOpacity(0.7),
78-
),
69+
return Column(
70+
crossAxisAlignment: CrossAxisAlignment.start,
71+
children: [
72+
Text(
73+
l10n.appUrlsDescription,
74+
style: Theme.of(context).textTheme.bodySmall?.copyWith(
75+
color: Theme.of(context).colorScheme.onSurface.withOpacity(0.7),
7976
),
80-
const SizedBox(height: AppSpacing.lg),
81-
AppConfigTextField(
82-
label: l10n.termsOfServiceUrlLabel,
83-
description: l10n.termsOfServiceUrlDescription,
84-
value: generalConfig.termsOfServiceUrl,
85-
onChanged: (value) {
86-
widget.onConfigChanged(
87-
widget.remoteConfig.copyWith(
88-
app: appConfig.copyWith(
89-
general: generalConfig.copyWith(
90-
termsOfServiceUrl: value,
91-
),
77+
),
78+
const SizedBox(height: AppSpacing.lg),
79+
AppConfigTextField(
80+
label: l10n.termsOfServiceUrlLabel,
81+
description: l10n.termsOfServiceUrlDescription,
82+
value: generalConfig.termsOfServiceUrl,
83+
onChanged: (value) {
84+
widget.onConfigChanged(
85+
widget.remoteConfig.copyWith(
86+
app: appConfig.copyWith(
87+
general: generalConfig.copyWith(
88+
termsOfServiceUrl: value,
9289
),
9390
),
94-
);
95-
},
96-
controller: _termsUrlController,
97-
),
98-
AppConfigTextField(
99-
label: l10n.privacyPolicyUrlLabel,
100-
description: l10n.privacyPolicyUrlDescription,
101-
value: generalConfig.privacyPolicyUrl,
102-
onChanged: (value) {
103-
widget.onConfigChanged(
104-
widget.remoteConfig.copyWith(
105-
app: appConfig.copyWith(
106-
general: generalConfig.copyWith(
107-
privacyPolicyUrl: value,
108-
),
91+
),
92+
);
93+
},
94+
controller: _termsUrlController,
95+
),
96+
AppConfigTextField(
97+
label: l10n.privacyPolicyUrlLabel,
98+
description: l10n.privacyPolicyUrlDescription,
99+
value: generalConfig.privacyPolicyUrl,
100+
onChanged: (value) {
101+
widget.onConfigChanged(
102+
widget.remoteConfig.copyWith(
103+
app: appConfig.copyWith(
104+
general: generalConfig.copyWith(
105+
privacyPolicyUrl: value,
109106
),
110107
),
111-
);
112-
},
113-
controller: _privacyUrlController,
114-
),
115-
],
116-
),
108+
),
109+
);
110+
},
111+
controller: _privacyUrlController,
112+
),
113+
],
117114
);
118115
}
119116
}

0 commit comments

Comments
 (0)