Skip to content

Commit ca35dd9

Browse files
committed
fix(user_management): update user filter dialog
- Add null safety to authentication and subscription filters - Update dashboard role filter values and selection logic - Modify filter section to handle nullable values consistently
1 parent 2f01319 commit ca35dd9

File tree

1 file changed

+10
-8
lines changed

1 file changed

+10
-8
lines changed

lib/user_management/widgets/user_filter_dialog/user_filter_dialog.dart

Lines changed: 10 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -125,7 +125,7 @@ class _UserFilterDialogState extends State<UserFilterDialog> {
125125
onSelected: (value) =>
126126
context.read<UserFilterDialogBloc>().add(
127127
UserFilterDialogAuthenticationChanged(
128-
value,
128+
value!,
129129
),
130130
),
131131
chipLabelBuilder: (value) => value.l10n(context),
@@ -140,7 +140,7 @@ class _UserFilterDialogState extends State<UserFilterDialog> {
140140
onSelected: (value) =>
141141
context.read<UserFilterDialogBloc>().add(
142142
UserFilterDialogSubscriptionChanged(
143-
value,
143+
value!,
144144
),
145145
),
146146
chipLabelBuilder: (value) => value.l10n(context),
@@ -151,13 +151,15 @@ class _UserFilterDialogState extends State<UserFilterDialog> {
151151
_FilterSection<DashboardUserRole>(
152152
title: l10n.dashboardRole,
153153
selectedValue: filterDialogState.dashboardRole,
154-
values: DashboardUserRole.values
155-
.where((role) => role != DashboardUserRole.admin)
156-
.toList(),
154+
values: const [
155+
DashboardUserRole.admin,
156+
DashboardUserRole.publisher,
157+
DashboardUserRole.none,
158+
],
157159
onSelected: (value) =>
158160
context.read<UserFilterDialogBloc>().add(
159161
UserFilterDialogDashboardRoleChanged(
160-
value as DashboardUserRole?,
162+
value,
161163
),
162164
),
163165
chipLabelBuilder: (value) => value.l10n(context),
@@ -186,7 +188,7 @@ class _FilterSection<T> extends StatelessWidget {
186188
final String title;
187189
final T? selectedValue;
188190
final List<T> values;
189-
final ValueChanged<T> onSelected;
191+
final ValueChanged<T?> onSelected;
190192
final String Function(T) chipLabelBuilder;
191193
final bool includeAllOption;
192194

@@ -216,7 +218,7 @@ class _FilterSection<T> extends StatelessWidget {
216218
label: Text(label),
217219
selected: isSelected,
218220
onSelected: (_) {
219-
onSelected(value as T);
221+
onSelected(value);
220222
},
221223
);
222224
}).toList(),

0 commit comments

Comments
 (0)