chore: misc

Author: fulleni

analysis_options.yaml

@@ -3,9 +3,12 @@ analyzer:
     avoid_catches_without_on_clauses: ignore
     avoid_print: ignore
     avoid_redundant_argument_values: ignore
+    comment_references: ignore
+    deprecated_member_use: ignore
     document_ignores: ignore
     flutter_style_todos: ignore
     lines_longer_than_80_chars: ignore
+    prefer_asserts_with_message: ignore
     use_if_null_to_convert_nulls_to_bools: ignore
 include: package:very_good_analysis/analysis_options.7.0.0.yaml
 linter:

lib/account/view/saved_headlines_page.dart

@@ -7,7 +7,7 @@ import 'package:ht_main/app/bloc/app_bloc.dart';
 import 'package:ht_main/l10n/l10n.dart';
 import 'package:ht_main/router/routes.dart';
 import 'package:ht_main/shared/shared.dart';
-import 'package:ht_shared/ht_shared.dart' show Headline, HeadlineImageStyle;
+import 'package:ht_shared/ht_shared.dart';
 
 /// {@template saved_headlines_page}
 /// Displays the list of headlines saved by the user.

lib/app/bloc/app_bloc.dart

@@ -62,7 +62,7 @@ class AppBloc extends Bloc<AppEvent, AppState> {
   ) async {
     // Determine the AppStatus based on the user object and its role
     final AppStatus status;
-    final User? oldUser = state.user;
+    final oldUser = state.user;
 
     switch (event.user?.role) {
       case null:
@@ -71,6 +71,7 @@ class AppBloc extends Bloc<AppEvent, AppState> {
         status = AppStatus.authenticated;
       case UserRole.guestUser: // Explicitly map guestUser to anonymous
         status = AppStatus.anonymous;
+      // ignore: no_default_cases
       default: // Fallback for any other roles not explicitly handled
         status = AppStatus.anonymous;
     }

lib/bootstrap.dart

@@ -210,7 +210,7 @@ Future<Widget> bootstrap(
   );
 
   // Conditionally instantiate DemoDataMigrationService
-  final DemoDataMigrationService? demoDataMigrationService =
+  final demoDataMigrationService =
       appConfig.environment == app_config.AppEnvironment.demo
       ? DemoDataMigrationService(
           userAppSettingsRepository: userAppSettingsRepository,

lib/entity_details/bloc/entity_details_bloc.dart

@@ -1,3 +1,5 @@
+// ignore_for_file: avoid_dynamic_calls
+
 import 'dart:async';
 
 import 'package:bloc/bloc.dart';

lib/entity_details/view/entity_details_page.dart

@@ -53,8 +53,8 @@ class EntityDetailsPage extends StatelessWidget {
           accountBloc: context.read<AccountBloc>(),
           appBloc: context.read<AppBloc>(),
           feedInjectorService: feedInjectorService,
-        );
-        entityDetailsBloc.add(
+        )
+        ..add(
           EntityDetailsLoadRequested(
             entityId: args.entityId,
             entityType: args.entityType,
@@ -118,10 +118,7 @@ class _EntityDetailsViewState extends State<EntityDetailsView> {
         name = l10n.entityDetailsCategoryTitle;
       case EntityType.source:
         name = l10n.entityDetailsSourceTitle;
-      // EntityType.country does not exist, remove or map if added later
-      default:
-        name = l10n.detailsPageTitle;
-    }
+      }
     // Manual capitalization
     return name.isNotEmpty
         ? '${name[0].toUpperCase()}${name.substring(1)}'

lib/headline-details/view/headline_details_page.dart

@@ -13,8 +13,7 @@ import 'package:ht_main/headline-details/bloc/similar_headlines_bloc.dart';
 import 'package:ht_main/l10n/l10n.dart';
 import 'package:ht_main/router/routes.dart';
 import 'package:ht_main/shared/shared.dart';
-import 'package:ht_shared/ht_shared.dart'
-    show Category, Headline, HeadlineImageStyle, Source;
+import 'package:ht_shared/ht_shared.dart';
 import 'package:intl/intl.dart';
 import 'package:share_plus/share_plus.dart';
 import 'package:url_launcher/url_launcher_string.dart';

lib/headlines-feed/view/category_filter_page.dart

@@ -101,7 +101,6 @@ class _CategoryFilterPageState extends State<CategoryFilterPage> {
 
     final theme = Theme.of(context);
     final textTheme = theme.textTheme;
-    final colorScheme = theme.colorScheme;
 
     return Scaffold(
       appBar: AppBar(

lib/headlines-feed/view/headlines_filter_page.dart

@@ -1,5 +1,5 @@
 //
-// ignore_for_file: lines_longer_than_80_chars, public_member_api_docs
+// ignore_for_file: lines_longer_than_80_chars, public_member_api_docs, unused_field
 
 import 'package:flutter/material.dart';
 import 'package:flutter_bloc/flutter_bloc.dart';
@@ -11,15 +11,7 @@ import 'package:ht_main/headlines-feed/models/headline_filter.dart';
 import 'package:ht_main/l10n/l10n.dart';
 import 'package:ht_main/router/routes.dart';
 import 'package:ht_main/shared/constants/constants.dart';
-import 'package:ht_shared/ht_shared.dart'
-    show
-        Category,
-        HtHttpException,
-        NotFoundException,
-        Source,
-        SourceType,
-        User,
-        UserContentPreferences;
+import 'package:ht_shared/ht_shared.dart';
 
 // Keys for passing data to/from SourceFilterPage
 const String keySelectedSources = 'selectedSources';

lib/headlines-search/models/search_model_type.dart

@@ -9,7 +9,7 @@ enum SearchModelType {
   ///
   /// This should ideally be localized using context.l10n,
   /// but for simplicity in this step, we'll use direct strings.
-  /// TODO(Cline): Localize these display names.
+  /// TODO(fulleni): Localize these display names.
   String get displayName {
     switch (this) {
       case SearchModelType.headline: