Skip to content

Commit 3971c2d

Browse files
committed
refactor(headline-details): improve ad visibility logic
- Extract ad visibility conditions to separate boolean variables - Rename variables for better clarity (isAboveButtonAdVisible, isBelowButtonAdVisible) - Simplify if statements by moving condition checks outside of them
1 parent 9ee0c10 commit 3971c2d

File tree

1 file changed

+10
-4
lines changed

1 file changed

+10
-4
lines changed

lib/headline-details/view/headline_details_page.dart

Lines changed: 10 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -373,14 +373,17 @@ class _HeadlineDetailsPageState extends State<HeadlineDetailsPage> {
373373
];
374374

375375
// Add ad above continue reading button if configured
376-
if (adConfig != null &&
376+
final isAboveButtonAdVisible =
377+
adConfig != null &&
377378
adConfig.enabled &&
378379
adConfig.articleAdConfiguration.enabled &&
379380
(adConfig
380381
.articleAdConfiguration
381382
.visibleTo[userRole]?[InArticleAdSlotType
382383
.aboveArticleContinueReadingButton] ??
383-
false)) {
384+
false);
385+
386+
if (isAboveButtonAdVisible) {
384387
slivers.add(
385388
SliverToBoxAdapter(
386389
child: Column(
@@ -434,14 +437,17 @@ class _HeadlineDetailsPageState extends State<HeadlineDetailsPage> {
434437
]);
435438

436439
// Add ad below continue reading button if configured
437-
if (adConfig != null &&
440+
final isBelowButtonAdVisible =
441+
adConfig != null &&
438442
adConfig.enabled &&
439443
adConfig.articleAdConfiguration.enabled &&
440444
(adConfig
441445
.articleAdConfiguration
442446
.visibleTo[userRole]?[InArticleAdSlotType
443447
.belowArticleContinueReadingButton] ??
444-
false)) {
448+
false);
449+
450+
if (isBelowButtonAdVisible) {
445451
slivers.add(
446452
SliverToBoxAdapter(
447453
child: Column(

0 commit comments

Comments
 (0)