Skip to content

Commit 07c6b09

Browse files
committed
output: add metrics in delayed_commit
Signed-off-by: Shizuo Fujita <fujita@clear-code.com>
1 parent 83759af commit 07c6b09

File tree

2 files changed

+3
-0
lines changed

2 files changed

+3
-0
lines changed

lib/fluent/plugin/output.rb

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1214,6 +1214,7 @@ def try_flush
12141214
if output.delayed_commit
12151215
log.trace "executing delayed write and commit", chunk: dump_unique_id_hex(chunk.unique_id)
12161216
@write_count_metrics.inc
1217+
@write_secondary_count_metrics.inc if using_secondary
12171218
@dequeued_chunks_mutex.synchronize do
12181219
# delayed_commit_timeout for secondary is configured in <buffer> of primary (<secondary> don't get <buffer>)
12191220
@dequeued_chunks << DequeuedChunkInfo.new(chunk.unique_id, Time.now, self.delayed_commit_timeout)

test/plugin/test_output_as_buffered_secondary.rb

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -446,6 +446,8 @@ def dummy_event_stream
446446
assert{ @i.buffer.dequeued[chunks[0].unique_id].nil? }
447447
assert{ chunks.first.empty? }
448448

449+
assert{ @i.instance_variable_get(:@write_secondary_count_metrics).get > 0 }
450+
449451
assert_nil @i.retry
450452

451453
logs = @i.log.out.logs

0 commit comments

Comments
 (0)