add validator back to simulation for incorrect auto impedance mode spec

Author: dmarek-flex

tests/test_components/test_microwave.py

@@ -10,6 +10,7 @@
 import pydantic.v1 as pd
 import pytest
 import xarray as xr
+from shapely import LineString
 
 import tidy3d as td
 import tidy3d.components.microwave.path_integrals.current_spec
@@ -22,6 +23,9 @@
     mutual_inductance_colinear_wire_segments,
     total_inductance_colinear_rectangular_wire_segments,
 )
+from tidy3d.components.microwave.path_integrals.mode_plane_analyzer import (
+    ModePlaneAnalyzer,
+)
 from tidy3d.components.microwave.path_integrals.path_integral_factory import (
     make_current_integral,
     make_path_integrals,
@@ -466,6 +470,51 @@ def test_path_integral_creation():
         )
 
 
+def test_mode_plane_analyzer_errors():
+    """Check that the ModePlaneAnalyzer reports errors properly."""
+
+    path_spec_gen = ModePlaneAnalyzer(size=(0, 2, 2), field_data_colocated=False)
+
+    # First some quick sanity checks with the helper
+    test_path = td.Box(center=(0, 0, 0), size=(0, 0.9, 0.1))
+    test_shapely = [LineString([(-1, 0), (1, 0)])]
+    assert path_spec_gen._check_box_intersects_with_conductors(test_shapely, test_path)
+
+    test_path = td.Box(center=(0, 0, 0), size=(0, 2.1, 0.1))
+    test_shapely = [LineString([(-1, 0), (1, 0)])]
+    assert not path_spec_gen._check_box_intersects_with_conductors(test_shapely, test_path)
+
+    sim = make_mw_sim(False, False, "microstrip")
+    coax = td.GeometryGroup(
+        geometries=(
+            td.ClipOperation(
+                operation="difference",
+                geometry_a=td.Cylinder(axis=0, radius=2 * mm, center=(0, 0, 5 * mm), length=td.inf),
+                geometry_b=td.Cylinder(
+                    axis=0, radius=1.4 * mm, center=(0, 0, 5 * mm), length=td.inf
+                ),
+            ),
+            td.Cylinder(axis=0, radius=1 * mm, center=(0, 0, 5 * mm), length=td.inf),
+        )
+    )
+    coax_struct = td.Structure(geometry=coax, medium=td.PEC)
+    sim = sim.updated_copy(structures=[coax_struct])
+    mode_monitor = sim.monitors[0]
+    modal_plane = td.Box(center=mode_monitor.center, size=mode_monitor.size)
+    path_spec_gen = ModePlaneAnalyzer(
+        center=modal_plane.center,
+        size=modal_plane.size,
+        field_data_colocated=mode_monitor.colocate,
+    )
+    with pytest.raises(SetupError):
+        path_spec_gen.get_conductor_bounding_boxes(
+            sim.structures,
+            sim.grid,
+            sim.symmetry,
+            sim.bounding_box,
+        )
+
+
 def test_impedance_spec_validation():
     """Check that the various allowed methods for supplying path specifications are validated."""
 

tests/test_components/test_simulation.py

@@ -3778,3 +3778,60 @@ def test_structures_per_medium(monkeypatch):
             grid_spec=td.GridSpec.uniform(dl=0.02),
             structures=structs,
         )
+
+
+def test_validate_microwave_mode_spec_generation():
+    """Test that auto generation of path specs is correctly validated for currently unsupported structures."""
+    freq0 = 10e9
+    mm = 1e3
+    run_time_spec = td.RunTimeSpec(quality_factor=3.0)
+    size = (10 * mm, 10 * mm, 10 * mm)
+    size_mon = (0, 8 * mm, 8 * mm)
+
+    # Currently limited to generation of axis aligned boxes around conductors,
+    # so the path may intersect other nearby conductors, like in this coaxial cable
+    coaxial = td.Structure(
+        geometry=td.GeometryGroup(
+            geometries=(
+                td.ClipOperation(
+                    operation="difference",
+                    geometry_a=td.Cylinder(
+                        axis=0, radius=2.5 * mm, center=(0, 0, 0), length=td.inf
+                    ),
+                    geometry_b=td.Cylinder(
+                        axis=0, radius=1.3 * mm, center=(0, 0, 0), length=td.inf
+                    ),
+                ),
+                td.Cylinder(axis=0, radius=1 * mm, center=(0, 0, 0), length=td.inf),
+            )
+        ),
+        medium=td.PEC,
+    )
+    mode_spec = td.ModeSpec(
+        num_modes=2,
+        target_neff=1.8,
+        microwave_spec=td.MicrowaveModeSpec(
+            impedance_specs=(td.AutoImpedanceSpec(), td.AutoImpedanceSpec())
+        ),
+    )
+
+    mode_mon = td.ModeMonitor(
+        center=(0, 0, 0),
+        size=size_mon,
+        freqs=[freq0],
+        name="mode_1",
+        colocate=False,
+        mode_spec=mode_spec,
+    )
+    sim = td.Simulation(
+        run_time=run_time_spec,
+        size=size,
+        sources=[],
+        structures=[coaxial],
+        grid_spec=td.GridSpec.uniform(dl=0.1 * mm),
+        monitors=[mode_mon],
+    )
+
+    # check that validation error is caught
+    with pytest.raises(SetupError):
+        sim._validate_microwave_mode_specs()