fix: raise error when _finalized simulation fails

Author: dbochkov-flexcompute

tests/test_components/test_source_frames.py

@@ -68,5 +68,5 @@ def test_source_absorber_frames():
             )
         ],
     )
-    with pytest.raises(pydantic.ValidationError):
-        _ = bad_sim._finalized
+    with pytest.raises(td.exceptions.Tidy3dError):
+        _ = bad_sim._validate_finalized()

tidy3d/components/simulation.py

@@ -2243,11 +2243,11 @@ def _validate_finalized(self):
 
         try:
             _ = self._finalized
-        except Exception:
-            log.error(
+        except Exception as e:
+            raise Tidy3dError(
                 "Simulation fails after requested mode source PEC frames are added. "
                 "Please inspect '._finalized'."
-            )
+            ) from e
 
 
 class Simulation(AbstractYeeGridSimulation):