Commit 91bd28f
committed
remove scaffold getPlatformVersion across all platform plugins
`getPlatformVersion` was the example method from
`flutter create --template=plugin` — a sanity-check that returns a
string like "macOS 14.5.0". Nothing in this workspace nor flet itself
ever called `SeriousPython.getPlatformVersion()`; the only consumers
were the scaffold-generated plugin tests for Linux and Windows. Drop
it everywhere before the dart-bridge release.
Touches all six packages:
- Top-level facade + platform-interface + method-channel impl: drop
the declaration / forwarding wrapper.
- Linux & Windows Dart impls: drop the override and the now-unused
`methodChannel` field; trim the corresponding flutter/services and
flutter/foundation imports.
- Linux native plugin (C): drop the `get_platform_version()` function,
collapse the method-call handler to a `NotImplemented` stub, and
remove the now-orphan `<sys/utsname.h>`, `<cstring>`, and
`_plugin_private.h` includes. Delete `_plugin_private.h` (only ever
declared this function) and `linux/test/` (only tested this function;
not referenced by CMakeLists).
- Windows native plugin (C++): same shape — drop the case, the
`<VersionHelpers.h>` + `<sstream>` includes, and the entire
`windows/test/` scaffold.
- Darwin Swift: drop the `getPlatformVersion` case; the `getResourcePath`
case stays. Tighten the file docstring accordingly.
- Android Java: drop the `getPlatformVersion` if-arm;
`getAppVersion` / `getNativeLibraryDir` stay.
flutter analyze: clean across all six packages (the 6 remaining
warnings are pre-existing path-dep / missing-asset notes from local
dev setup, unrelated to this change).
Technically a public API break — `SeriousPython.getPlatformVersion()`
is part of the published Dart API — but folded in here with the
dart-bridge wire-format break already in flight.1 parent 212efe7 commit 91bd28f
14 files changed
Lines changed: 11 additions & 199 deletions
File tree
- src
- serious_python_android
- android/src/main/java/com/flet/serious_python_android
- lib
- serious_python_darwin
- darwin/Classes
- lib
- serious_python_linux
- lib
- linux
- test
- serious_python_platform_interface/lib
- src
- serious_python_windows
- lib
- windows
- test
- serious_python/lib
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
9 | 9 | | |
10 | 10 | | |
11 | 11 | | |
12 | | - | |
13 | | - | |
14 | | - | |
15 | | - | |
16 | | - | |
17 | 12 | | |
18 | 13 | | |
19 | 14 | | |
| |||
Lines changed: 1 addition & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
58 | 58 | | |
59 | 59 | | |
60 | 60 | | |
61 | | - | |
62 | | - | |
63 | | - | |
| 61 | + | |
64 | 62 | | |
65 | 63 | | |
66 | 64 | | |
| |||
Lines changed: 0 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
26 | 26 | | |
27 | 27 | | |
28 | 28 | | |
29 | | - | |
30 | | - | |
31 | | - | |
32 | | - | |
33 | 29 | | |
34 | 30 | | |
35 | 31 | | |
| |||
Lines changed: 3 additions & 10 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
16 | 16 | | |
17 | 17 | | |
18 | 18 | | |
19 | | - | |
20 | | - | |
21 | | - | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
22 | 22 | | |
23 | 23 | | |
24 | 24 | | |
| |||
44 | 44 | | |
45 | 45 | | |
46 | 46 | | |
47 | | - | |
48 | | - | |
49 | | - | |
50 | | - | |
51 | | - | |
52 | | - | |
53 | | - | |
54 | 47 | | |
55 | 48 | | |
56 | 49 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
17 | 17 | | |
18 | 18 | | |
19 | 19 | | |
20 | | - | |
21 | | - | |
22 | | - | |
23 | | - | |
24 | 20 | | |
25 | 21 | | |
26 | 22 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | | - | |
4 | | - | |
5 | 3 | | |
6 | 4 | | |
7 | 5 | | |
| |||
20 | 18 | | |
21 | 19 | | |
22 | 20 | | |
23 | | - | |
24 | | - | |
25 | | - | |
26 | 21 | | |
27 | 22 | | |
28 | 23 | | |
29 | 24 | | |
30 | | - | |
31 | | - | |
32 | | - | |
33 | | - | |
34 | | - | |
35 | | - | |
36 | | - | |
37 | 25 | | |
38 | 26 | | |
39 | 27 | | |
| |||
Lines changed: 4 additions & 28 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2 | 2 | | |
3 | 3 | | |
4 | 4 | | |
5 | | - | |
6 | 5 | | |
7 | | - | |
8 | | - | |
9 | | - | |
10 | | - | |
11 | | - | |
12 | | - | |
| 6 | + | |
| 7 | + | |
13 | 8 | | |
14 | 9 | | |
15 | 10 | | |
| |||
26 | 21 | | |
27 | 22 | | |
28 | 23 | | |
29 | | - | |
30 | | - | |
31 | | - | |
32 | | - | |
33 | | - | |
34 | | - | |
35 | | - | |
36 | | - | |
37 | | - | |
38 | | - | |
39 | | - | |
40 | | - | |
| 24 | + | |
| 25 | + | |
41 | 26 | | |
42 | 27 | | |
43 | 28 | | |
44 | | - | |
45 | | - | |
46 | | - | |
47 | | - | |
48 | | - | |
49 | | - | |
50 | | - | |
51 | | - | |
52 | | - | |
53 | 29 | | |
54 | 30 | | |
55 | 31 | | |
| |||
Lines changed: 0 additions & 10 deletions
This file was deleted.
Lines changed: 0 additions & 31 deletions
This file was deleted.
Lines changed: 0 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
26 | 26 | | |
27 | 27 | | |
28 | 28 | | |
29 | | - | |
30 | | - | |
31 | | - | |
32 | | - | |
33 | 29 | | |
34 | 30 | | |
35 | 31 | | |
| |||
0 commit comments