Use recommended Robolectric setup for gradle plugin 3.0 (#1071)

SUPERCILEX · samtstern · commit e102cc196d11 · 2018-01-02T10:16:34.000-08:00
diff --git a/auth/src/test/java/com/firebase/ui/auth/AuthUITest.java b/auth/src/test/java/com/firebase/ui/auth/AuthUITest.java
@@ -27,14 +27,12 @@
 import org.junit.runner.RunWith;
 import org.robolectric.RobolectricTestRunner;
 import org.robolectric.RuntimeEnvironment;
-import org.robolectric.annotation.Config;
 
 import java.util.Arrays;
 
 import static junit.framework.Assert.assertEquals;
 
 @RunWith(RobolectricTestRunner.class)
-@Config(constants = BuildConfig.class, sdk = 25)
 public class AuthUITest {
     private FirebaseApp mFirebaseApp;
 
diff --git a/auth/src/test/java/com/firebase/ui/auth/ui/email/EmailActivityTest.java b/auth/src/test/java/com/firebase/ui/auth/ui/email/EmailActivityTest.java
@@ -20,7 +20,6 @@
 import android.widget.EditText;
 
 import com.firebase.ui.auth.AuthUI;
-import com.firebase.ui.auth.BuildConfig;
 import com.firebase.ui.auth.R;
 import com.firebase.ui.auth.data.model.User;
 import com.firebase.ui.auth.testhelpers.AuthHelperShadow;
@@ -48,7 +47,6 @@
 import static org.mockito.Mockito.when;
 
 @RunWith(RobolectricTestRunner.class)
-@Config(constants = BuildConfig.class, sdk = 25)
 public class EmailActivityTest {
 
     private EmailActivity createActivity() {
diff --git a/auth/src/test/java/com/firebase/ui/auth/ui/email/RecoverPasswordActivityTest.java b/auth/src/test/java/com/firebase/ui/auth/ui/email/RecoverPasswordActivityTest.java
@@ -17,7 +17,6 @@
 import android.content.Intent;
 import android.widget.Button;
 
-import com.firebase.ui.auth.BuildConfig;
 import com.firebase.ui.auth.R;
 import com.firebase.ui.auth.testhelpers.AuthHelperShadow;
 import com.firebase.ui.auth.testhelpers.AutoCompleteTask;
@@ -38,7 +37,6 @@
 import static org.mockito.Mockito.when;
 
 @RunWith(RobolectricTestRunner.class)
-@Config(constants = BuildConfig.class, sdk = 25)
 public class RecoverPasswordActivityTest {
 
     @Before
diff --git a/auth/src/test/java/com/firebase/ui/auth/ui/email/WelcomeBackPasswordPromptTest.java b/auth/src/test/java/com/firebase/ui/auth/ui/email/WelcomeBackPasswordPromptTest.java
@@ -20,7 +20,6 @@
 import android.widget.EditText;
 
 import com.firebase.ui.auth.AuthUI;
-import com.firebase.ui.auth.BuildConfig;
 import com.firebase.ui.auth.IdpResponse;
 import com.firebase.ui.auth.R;
 import com.firebase.ui.auth.data.model.User;
@@ -51,7 +50,6 @@
 import static org.mockito.Mockito.when;
 
 @RunWith(RobolectricTestRunner.class)
-@Config(constants = BuildConfig.class, sdk = 25)
 public class WelcomeBackPasswordPromptTest {
     @Before
     public void setUp() {
diff --git a/auth/src/test/java/com/firebase/ui/auth/ui/idp/AuthMethodPickerActivityTest.java b/auth/src/test/java/com/firebase/ui/auth/ui/idp/AuthMethodPickerActivityTest.java
@@ -20,7 +20,6 @@
 import android.widget.LinearLayout;
 
 import com.firebase.ui.auth.AuthUI;
-import com.firebase.ui.auth.BuildConfig;
 import com.firebase.ui.auth.R;
 import com.firebase.ui.auth.testhelpers.AuthHelperShadow;
 import com.firebase.ui.auth.testhelpers.AutoCompleteTask;
@@ -58,12 +57,11 @@
 import static org.mockito.Mockito.when;
 
 @RunWith(RobolectricTestRunner.class)
-@Config(constants = BuildConfig.class,
-        shadows = {
-                GoogleProviderShadow.class,
-                FacebookProviderShadow.class,
-                LoginManagerShadow.class
-        }, sdk = 25)
+@Config(shadows = {
+        GoogleProviderShadow.class,
+        FacebookProviderShadow.class,
+        LoginManagerShadow.class
+})
 public class AuthMethodPickerActivityTest {
     @Test
     public void testAllProvidersArePopulated() {
diff --git a/auth/src/test/java/com/firebase/ui/auth/ui/idp/CredentialSignInHandlerTest.java b/auth/src/test/java/com/firebase/ui/auth/ui/idp/CredentialSignInHandlerTest.java
@@ -16,7 +16,6 @@
 
 import android.content.Intent;
 
-import com.firebase.ui.auth.BuildConfig;
 import com.firebase.ui.auth.IdpResponse;
 import com.firebase.ui.auth.data.model.FlowParameters;
 import com.firebase.ui.auth.data.model.User;
@@ -59,7 +58,6 @@
 import static org.mockito.Mockito.when;
 
 @RunWith(RobolectricTestRunner.class)
-@Config(constants = BuildConfig.class, sdk = 25)
 public class CredentialSignInHandlerTest {
     private static final int RC_ACCOUNT_LINK = 3;
     private static final String LINKING_ERROR = "ERROR_TEST_LINKING";
diff --git a/auth/src/test/java/com/firebase/ui/auth/ui/phone/BucketedTextChangeListenerTest.java b/auth/src/test/java/com/firebase/ui/auth/ui/phone/BucketedTextChangeListenerTest.java
@@ -19,22 +19,19 @@
 
 import android.widget.EditText;
 
-import com.firebase.ui.auth.BuildConfig;
 import com.firebase.ui.auth.util.ui.BucketedTextChangeListener;
 
 import org.junit.Before;
 import org.junit.Test;
 import org.junit.runner.RunWith;
 import org.mockito.InOrder;
 import org.robolectric.RobolectricTestRunner;
-import org.robolectric.annotation.Config;
 
 import static org.mockito.Mockito.inOrder;
 import static org.mockito.Mockito.mock;
 import static org.mockito.Mockito.verify;
 
 @RunWith(RobolectricTestRunner.class)
-@Config(constants = BuildConfig.class, sdk = 21)
 public class BucketedTextChangeListenerTest {
     private static final int EXPECTED_LENGTH = 6;
     private static final String PLACE_HOLDER = "-";
diff --git a/auth/src/test/java/com/firebase/ui/auth/ui/phone/CountryInfoTests.java b/auth/src/test/java/com/firebase/ui/auth/ui/phone/CountryInfoTests.java
@@ -17,13 +17,11 @@
  */
 package com.firebase.ui.auth.ui.phone;
 
-import com.firebase.ui.auth.BuildConfig;
 import com.firebase.ui.auth.data.model.CountryInfo;
 
 import org.junit.Test;
 import org.junit.runner.RunWith;
 import org.robolectric.RobolectricTestRunner;
-import org.robolectric.annotation.Config;
 
 import java.util.Locale;
 
@@ -32,7 +30,6 @@
 import static org.junit.Assert.assertNotSame;
 
 @RunWith(RobolectricTestRunner.class)
-@Config(constants = BuildConfig.class, sdk = 25)
 public class CountryInfoTests {
     private static final Locale COUNTRY_NAME_US = new Locale("", "US");
     private static final int COUNTRY_CODE_US = 1;
diff --git a/auth/src/test/java/com/firebase/ui/auth/ui/phone/CountryListLoadTaskTests.java b/auth/src/test/java/com/firebase/ui/auth/ui/phone/CountryListLoadTaskTests.java
@@ -18,15 +18,13 @@
 
 package com.firebase.ui.auth.ui.phone;
 
-import com.firebase.ui.auth.BuildConfig;
 import com.firebase.ui.auth.data.client.CountryListLoadTask;
 import com.firebase.ui.auth.data.model.CountryInfo;
 
 import org.junit.Before;
 import org.junit.Test;
 import org.junit.runner.RunWith;
 import org.robolectric.RobolectricTestRunner;
-import org.robolectric.annotation.Config;
 
 import java.util.ArrayList;
 import java.util.Collections;
@@ -40,7 +38,6 @@
 import static org.mockito.Mockito.verify;
 
 @RunWith(RobolectricTestRunner.class)
-@Config(constants = BuildConfig.class, sdk = 25)
 public class CountryListLoadTaskTests {
     private static final ArrayList<CountryInfo> COUNTRY_LIST = new ArrayList<>();
 
diff --git a/auth/src/test/java/com/firebase/ui/auth/ui/phone/PhoneActivityTest.java b/auth/src/test/java/com/firebase/ui/auth/ui/phone/PhoneActivityTest.java
@@ -23,7 +23,6 @@
 import android.widget.TextView;
 
 import com.firebase.ui.auth.AuthUI;
-import com.firebase.ui.auth.BuildConfig;
 import com.firebase.ui.auth.R;
 import com.firebase.ui.auth.data.model.CountryInfo;
 import com.firebase.ui.auth.testhelpers.AuthHelperShadow;
@@ -74,7 +73,6 @@
 import static org.mockito.MockitoAnnotations.initMocks;
 
 @RunWith(RobolectricTestRunner.class)
-@Config(constants = BuildConfig.class, sdk = 25)
 public class PhoneActivityTest {
     private PhoneActivity mActivity;
     private TextInputLayout mPhoneLayout;
diff --git a/auth/src/test/java/com/firebase/ui/auth/ui/phone/PhoneNumberTest.java b/auth/src/test/java/com/firebase/ui/auth/ui/phone/PhoneNumberTest.java
@@ -17,19 +17,16 @@
  */
 package com.firebase.ui.auth.ui.phone;
 
-import com.firebase.ui.auth.BuildConfig;
 import com.firebase.ui.auth.data.model.PhoneNumber;
 
 import org.junit.Test;
 import org.junit.runner.RunWith;
 import org.robolectric.RobolectricTestRunner;
-import org.robolectric.annotation.Config;
 
 import static org.junit.Assert.assertFalse;
 import static org.junit.Assert.assertTrue;
 
 @RunWith(RobolectricTestRunner.class)
-@Config(constants = BuildConfig.class, sdk = 21)
 public class PhoneNumberTest {
     @Test
     public void testIsValid_emptyPhone() {
diff --git a/auth/src/test/java/com/firebase/ui/auth/ui/phone/PhoneNumberUtilsTest.java b/auth/src/test/java/com/firebase/ui/auth/ui/phone/PhoneNumberUtilsTest.java
@@ -43,7 +43,6 @@
 import static org.mockito.Mockito.when;
 
 @RunWith(RobolectricTestRunner.class)
-@Config(constants = BuildConfig.class, sdk = 21)
 public class PhoneNumberUtilsTest {
     @Test
     public void testGetPhoneNumber() {
diff --git a/auth/src/test/java/com/firebase/ui/auth/ui/phone/SpacedEditTextTest.java b/auth/src/test/java/com/firebase/ui/auth/ui/phone/SpacedEditTextTest.java
@@ -23,22 +23,19 @@
 import android.text.style.ScaleXSpan;
 import android.util.AttributeSet;
 
-import com.firebase.ui.auth.BuildConfig;
 import com.firebase.ui.auth.R;
 
 import org.junit.Before;
 import org.junit.Test;
 import org.junit.runner.RunWith;
 import org.robolectric.RobolectricTestRunner;
 import org.robolectric.RuntimeEnvironment;
-import org.robolectric.annotation.Config;
 
 import static junit.framework.Assert.assertEquals;
 import static org.mockito.Mockito.mock;
 import static org.mockito.Mockito.when;
 
 @RunWith(RobolectricTestRunner.class)
-@Config(constants = BuildConfig.class, sdk = 21)
 public class SpacedEditTextTest {
     private static final float SPACING_PROPORTION = 1.1f;
 
