Password visibility toggle fix (#349)

SUPERCILEX · samtstern · commit 8438c49e6761 · 2016-10-13T08:21:59.000-07:00
* Update dependencies

* Update tests

* Update test dependencies

* Add workaround for password toggle

* Update .travis.yml
diff --git a/.travis.yml b/.travis.yml
@@ -5,15 +5,13 @@ android:
   components:
     - platform-tools
     - tools
-    - build-tools-23.0.3
-    - android-23
+    - build-tools-24.0.3
+    - android-24
+
+    # Extras
     - extra-google-google_play_services
     - extra-google-m2repository
     - extra-android-m2repository
     - addon-google_apis-google-24
-  licenses:
-    - 'android-sdk-preview-license-52d11cd2'
-    - 'android-sdk-license-.+'
-    - 'google-gdk-license-.+'
 script:
   - ./gradlew clean :library:testAll :library:prepareArtifacts
diff --git a/auth/build.gradle b/auth/build.gradle
@@ -31,9 +31,11 @@ android {
 
 dependencies {
     testCompile 'junit:junit:4.12'
-    testCompile 'org.mockito:mockito-core:1.10.19'
-    testCompile "org.robolectric:robolectric:3.1.1"
-    compile "com.android.support:appcompat-v7:${project.ext.support_library_version}"
+    testCompile 'org.mockito:mockito-core:2.2.0'
+    testCompile 'org.robolectric:robolectric:3.1.2'
+    // See https://github.com/robolectric/robolectric/issues/1932#issuecomment-219796474
+    testCompile 'org.khronos:opengl-api:gl1.1-android-2.1_r1'
+    
     compile 'com.facebook.android:facebook-android-sdk:4.14.1'
     compile "com.android.support:design:${project.ext.support_library_version}"
 
diff --git a/auth/src/main/java/com/firebase/ui/auth/ui/account_link/WelcomeBackIDPPrompt.java b/auth/src/main/java/com/firebase/ui/auth/ui/account_link/WelcomeBackIDPPrompt.java
@@ -90,8 +90,7 @@ protected void onCreate(Bundle savedInstanceState) {
         if (mIdpProvider == null) {
             getIntent().putExtra(
                     ExtraConstants.EXTRA_ERROR_MESSAGE,
-                    "Firebase login successful. Account linking failed due to provider not "
-                            + "enabled by application");
+                    "Firebase login successful. Account linking failed due to provider not enabled by application");
             finish(RESULT_CANCELED, getIntent());
             return;
         }
diff --git a/auth/src/main/java/com/firebase/ui/auth/ui/account_link/WelcomeBackPasswordPrompt.java b/auth/src/main/java/com/firebase/ui/auth/ui/account_link/WelcomeBackPasswordPrompt.java
@@ -81,6 +81,8 @@ protected void onCreate(Bundle savedInstanceState) {
         TextView bodyTextView = ((TextView) findViewById(R.id.welcome_back_password_body));
         bodyTextView.setText(spannableStringBuilder);
 
+        ((TextInputLayout) findViewById(R.id.password_layout)).setPasswordVisibilityToggleEnabled(false);
+
         // Click listeners
         findViewById(R.id.button_done).setOnClickListener(this);
         findViewById(R.id.toggle_visibility).setOnClickListener(
diff --git a/auth/src/main/java/com/firebase/ui/auth/ui/email/ImageFocusTransparencyChanger.java b/auth/src/main/java/com/firebase/ui/auth/ui/email/ImageFocusTransparencyChanger.java
@@ -39,6 +39,5 @@ public void onFocusChange(View v, boolean hasFocus) {
         } else {
             mTogglePasswordImage.setAlpha(mSlightlyVisible);
         }
-
     }
 }
diff --git a/auth/src/main/java/com/firebase/ui/auth/ui/email/RegisterEmailActivity.java b/auth/src/main/java/com/firebase/ui/auth/ui/email/RegisterEmailActivity.java
@@ -66,7 +66,6 @@ public class RegisterEmailActivity extends AppCompatBase implements View.OnClick
     private EmailFieldValidator mEmailFieldValidator;
     private PasswordFieldValidator mPasswordFieldValidator;
     private RequiredFieldValidator mNameValidator;
-    private ImageView mTogglePasswordImage;
 
     @Override
     protected void onCreate(Bundle savedInstanceState) {
@@ -83,14 +82,15 @@ protected void onCreate(Bundle savedInstanceState) {
         getResources().getValue(R.dimen.slightly_visible_icon, slightlyVisibleIcon, true);
 
         mPasswordEditText = (EditText) findViewById(R.id.password);
-        mTogglePasswordImage = (ImageView) findViewById(R.id.toggle_visibility);
+        ((TextInputLayout) findViewById(R.id.password_layout)).setPasswordVisibilityToggleEnabled(false);
+        ImageView togglePasswordImage = (ImageView) findViewById(R.id.toggle_visibility);
 
         mPasswordEditText.setOnFocusChangeListener(new ImageFocusTransparencyChanger(
-                mTogglePasswordImage,
+                togglePasswordImage,
                 visibleIcon.getFloat(),
                 slightlyVisibleIcon.getFloat()));
 
-        mTogglePasswordImage.setOnClickListener(new PasswordToggler(mPasswordEditText));
+        togglePasswordImage.setOnClickListener(new PasswordToggler(mPasswordEditText));
 
         mNameEditText = (EditText) findViewById(R.id.name);
 
diff --git a/auth/src/main/java/com/firebase/ui/auth/ui/email/SignInActivity.java b/auth/src/main/java/com/firebase/ui/auth/ui/email/SignInActivity.java
@@ -50,7 +50,6 @@ public class SignInActivity extends AppCompatBase implements View.OnClickListene
     private EditText mPasswordEditText;
     private EmailFieldValidator mEmailValidator;
     private RequiredFieldValidator mPasswordValidator;
-    private ImageView mTogglePasswordImage;
 
     @Override
     protected void onCreate(Bundle savedInstanceState) {
@@ -68,14 +67,15 @@ protected void onCreate(Bundle savedInstanceState) {
         getResources().getValue(R.dimen.slightly_visible_icon, slightlyVisibleIcon, true);
 
         mPasswordEditText = (EditText) findViewById(R.id.password);
-        mTogglePasswordImage = (ImageView) findViewById(R.id.toggle_visibility);
+        ((TextInputLayout) findViewById(R.id.password_layout)).setPasswordVisibilityToggleEnabled(false);
+        ImageView togglePasswordImage = (ImageView) findViewById(R.id.toggle_visibility);
 
         mPasswordEditText.setOnFocusChangeListener(new ImageFocusTransparencyChanger(
-                mTogglePasswordImage,
+                togglePasswordImage,
                 visibleIcon.getFloat(),
                 slightlyVisibleIcon.getFloat()));
 
-        mTogglePasswordImage.setOnClickListener(new PasswordToggler(mPasswordEditText));
+        togglePasswordImage.setOnClickListener(new PasswordToggler(mPasswordEditText));
 
         mEmailValidator = new EmailFieldValidator((TextInputLayout) findViewById(R.id
                 .email_layout));
diff --git a/auth/src/main/res/layout/sign_in_layout.xml b/auth/src/main/res/layout/sign_in_layout.xml
@@ -34,7 +34,7 @@
         android:layout_height="wrap_content">
 
         <EditText
-            style="@style/FirebaseUI.EditText"
+            style="@style/FirebaseUI.EditText.PasswordField"
             android:id="@+id/password"
             android:hint="@string/password_hint"
             />
diff --git a/auth/src/main/res/layout/welcome_back_password_prompt_layout.xml b/auth/src/main/res/layout/welcome_back_password_prompt_layout.xml
@@ -28,7 +28,7 @@
             android:layout_height="wrap_content">
 
             <EditText
-                style="@style/FirebaseUI.EditText"
+                style="@style/FirebaseUI.EditText.PasswordField"
                 android:id="@+id/password"
                 android:hint="@string/password_hint"
                 />
diff --git a/auth/src/main/res/values/styles.xml b/auth/src/main/res/values/styles.xml
@@ -160,7 +160,7 @@
         <item name="android:inputType">textPassword</item>
     </style>
 
-    <style name="FirebaseUI.ImageView"></style>
+    <style name="FirebaseUI.ImageView"/>
 
     <style name="FirebaseUI.ImageView.VisibilityToggle">
         <item name="android:layout_marginBottom">12dp</item>
diff --git a/auth/src/test/java/com/firebase/ui/auth/AuthUITest.java b/auth/src/test/java/com/firebase/ui/auth/AuthUITest.java
@@ -14,8 +14,6 @@
 
 package com.firebase.ui.auth;
 
-import static junit.framework.Assert.assertEquals;
-
 import android.content.Intent;
 
 import com.firebase.ui.auth.test_helpers.CustomRobolectricGradleTestRunner;
@@ -31,8 +29,10 @@
 import org.robolectric.RuntimeEnvironment;
 import org.robolectric.annotation.Config;
 
+import static junit.framework.Assert.assertEquals;
+
 @RunWith(CustomRobolectricGradleTestRunner.class)
-@Config(constants = BuildConfig.class, sdk = 21)
+@Config(constants = BuildConfig.class, sdk = 23)
 public class AuthUITest {
     private FirebaseApp mFirebaseApp;
 
diff --git a/auth/src/test/java/com/firebase/ui/auth/test_helpers/CustomRobolectricGradleTestRunner.java b/auth/src/test/java/com/firebase/ui/auth/test_helpers/CustomRobolectricGradleTestRunner.java
@@ -23,11 +23,11 @@
 import com.firebase.ui.auth.util.FirebaseAuthWrapperImpl;
 
 import org.junit.runners.model.InitializationError;
-import org.robolectric.RobolectricGradleTestRunner;
+import org.robolectric.RobolectricTestRunner;
 import org.robolectric.annotation.Config;
 import org.robolectric.internal.bytecode.InstrumentationConfiguration;
 
-public class CustomRobolectricGradleTestRunner extends RobolectricGradleTestRunner {
+public class CustomRobolectricGradleTestRunner extends RobolectricTestRunner {
     public CustomRobolectricGradleTestRunner(Class<?> klass) throws InitializationError {
         super(klass);
     }
diff --git a/auth/src/test/java/com/firebase/ui/auth/ui/ChooseAccountActivityTest.java b/auth/src/test/java/com/firebase/ui/auth/ui/ChooseAccountActivityTest.java
@@ -53,7 +53,7 @@
 import static org.mockito.Mockito.when;
 
 @RunWith(CustomRobolectricGradleTestRunner.class)
-@Config(constants = BuildConfig.class, shadows = {ActivityHelperShadow.class}, sdk = 21)
+@Config(constants = BuildConfig.class, shadows = {ActivityHelperShadow.class}, sdk = 23)
 public class ChooseAccountActivityTest {
     private FirebaseApp mFirebaseApp;
     @Mock private CredentialsAPI mCredentialsAPI;
diff --git a/auth/src/test/java/com/firebase/ui/auth/ui/email/RecoverPasswordActivityTest.java b/auth/src/test/java/com/firebase/ui/auth/ui/email/RecoverPasswordActivityTest.java
@@ -14,18 +14,14 @@
 
 package com.firebase.ui.auth.ui.email;
 
-import static junit.framework.Assert.assertEquals;
-import static org.mockito.Mockito.verify;
-import static org.mockito.Mockito.when;
-
 import android.content.Intent;
 import android.widget.Button;
 
+import com.firebase.ui.auth.BuildConfig;
+import com.firebase.ui.auth.R;
 import com.firebase.ui.auth.test_helpers.ActivityHelperShadow;
 import com.firebase.ui.auth.test_helpers.AutoCompleteTask;
-import com.firebase.ui.auth.BuildConfig;
 import com.firebase.ui.auth.test_helpers.CustomRobolectricGradleTestRunner;
-import com.firebase.ui.auth.R;
 import com.firebase.ui.auth.test_helpers.TestConstants;
 import com.firebase.ui.auth.test_helpers.TestHelper;
 import com.firebase.ui.auth.ui.ExtraConstants;
@@ -40,8 +36,12 @@
 
 import java.util.Collections;
 
+import static junit.framework.Assert.assertEquals;
+import static org.mockito.Mockito.verify;
+import static org.mockito.Mockito.when;
+
 @RunWith(CustomRobolectricGradleTestRunner.class)
-@Config(constants = BuildConfig.class, sdk = 21)
+@Config(constants = BuildConfig.class, sdk = 23)
 public class RecoverPasswordActivityTest {
 
     @Before
diff --git a/auth/src/test/java/com/firebase/ui/auth/ui/email/RegisterEmailActivityTest.java b/auth/src/test/java/com/firebase/ui/auth/ui/email/RegisterEmailActivityTest.java
@@ -53,7 +53,7 @@
 
 
 @RunWith(CustomRobolectricGradleTestRunner.class)
-@Config(constants = BuildConfig.class, sdk = 21)
+@Config(constants = BuildConfig.class, sdk = 23)
 public class RegisterEmailActivityTest {
 
     private RegisterEmailActivity createActivity(String email) {
diff --git a/auth/src/test/java/com/firebase/ui/auth/ui/email/SignInActivityTest.java b/auth/src/test/java/com/firebase/ui/auth/ui/email/SignInActivityTest.java
@@ -51,7 +51,7 @@
 import static org.mockito.Mockito.when;
 
 @RunWith(CustomRobolectricGradleTestRunner.class)
-@Config(constants = BuildConfig.class, sdk = 21)
+@Config(constants = BuildConfig.class, sdk = 23)
 public class SignInActivityTest {
 
     @Before
diff --git a/auth/src/test/java/com/firebase/ui/auth/ui/email/SignInNoPasswordActivityTest.java b/auth/src/test/java/com/firebase/ui/auth/ui/email/SignInNoPasswordActivityTest.java
@@ -14,21 +14,18 @@
 
 package com.firebase.ui.auth.ui.email;
 
-import static org.junit.Assert.assertEquals;
-import static org.mockito.Mockito.when;
-
 import android.content.Intent;
 import android.support.design.widget.TextInputLayout;
 import android.widget.Button;
 import android.widget.EditText;
 
-import com.firebase.ui.auth.test_helpers.ActivityHelperShadow;
 import com.firebase.ui.auth.AuthUI;
-import com.firebase.ui.auth.test_helpers.AutoCompleteTask;
 import com.firebase.ui.auth.BuildConfig;
+import com.firebase.ui.auth.R;
+import com.firebase.ui.auth.test_helpers.ActivityHelperShadow;
+import com.firebase.ui.auth.test_helpers.AutoCompleteTask;
 import com.firebase.ui.auth.test_helpers.CustomRobolectricGradleTestRunner;
 import com.firebase.ui.auth.test_helpers.FakeProviderQueryResult;
-import com.firebase.ui.auth.R;
 import com.firebase.ui.auth.test_helpers.TestConstants;
 import com.firebase.ui.auth.test_helpers.TestHelper;
 import com.firebase.ui.auth.ui.ExtraConstants;
@@ -47,9 +44,12 @@
 import java.util.Arrays;
 import java.util.Collections;
 
+import static org.junit.Assert.assertEquals;
+import static org.mockito.Mockito.when;
+
 
 @RunWith(CustomRobolectricGradleTestRunner.class)
-@Config(constants = BuildConfig.class, sdk = 21)
+@Config(constants = BuildConfig.class, sdk = 23)
 public class SignInNoPasswordActivityTest {
     @Before
     public void setUp() {
diff --git a/auth/src/test/java/com/firebase/ui/auth/ui/idp/AuthMethodPickerActivityTest.java b/auth/src/test/java/com/firebase/ui/auth/ui/idp/AuthMethodPickerActivityTest.java
@@ -66,7 +66,7 @@
                 GoogleProviderShadow.class,
                 FacebookProviderShadow.class,
                 LoginManagerShadow.class
-        }, sdk = 21)
+        }, sdk = 23)
 public class AuthMethodPickerActivityTest {
 
     @Before
diff --git a/auth/src/test/java/com/firebase/ui/auth/ui/idp/CredentialSignInHandlerTest.java b/auth/src/test/java/com/firebase/ui/auth/ui/idp/CredentialSignInHandlerTest.java
@@ -66,7 +66,7 @@
 
 
 @RunWith(CustomRobolectricGradleTestRunner.class)
-@Config(constants = BuildConfig.class, sdk = 21, shadows = {ActivityHelperShadow.class})
+@Config(constants = BuildConfig.class, sdk = 23, shadows = {ActivityHelperShadow.class})
 public class CredentialSignInHandlerTest {
     private static final int RC_ACCOUNT_LINK = 3;
     private static final int RC_SAVE_CREDENTIALS = 4;
diff --git a/auth/src/test/java/com/firebase/ui/auth/util/HeadlessAPIWrapperImplTest.java b/auth/src/test/java/com/firebase/ui/auth/util/HeadlessAPIWrapperImplTest.java
@@ -24,16 +24,16 @@
 import org.junit.runner.RunWith;
 import org.mockito.Mock;
 import org.mockito.MockitoAnnotations;
-import org.robolectric.RobolectricGradleTestRunner;
+import org.robolectric.RobolectricTestRunner;
 import org.robolectric.RuntimeEnvironment;
 import org.robolectric.annotation.Config;
 
 import static junit.framework.Assert.assertFalse;
 import static junit.framework.Assert.assertTrue;
 import static org.mockito.Mockito.when;
 
-@RunWith(RobolectricGradleTestRunner.class)
-@Config(constants = BuildConfig.class, sdk=23)
+@RunWith(RobolectricTestRunner.class)
+@Config(constants = BuildConfig.class, sdk = 23)
 public class HeadlessAPIWrapperImplTest {
 
     private FirebaseAuthWrapperImpl mHeadlessAPIWrapperImpl;
diff --git a/common/constants.gradle b/common/constants.gradle
@@ -1,10 +1,10 @@
-project.ext.firebase_version = '9.6.0'
-project.ext.support_library_version = '23.4.0'
+project.ext.firebase_version = '9.6.1'
+project.ext.support_library_version = '24.2.1'
 
 project.ext.submodules = ['database', 'auth', 'storage']
 project.ext.group = 'com.firebaseui'
 project.ext.version = '0.6.0'
 project.ext.pomdesc = 'Firebase UI Android'
-project.ext.buildtools = '23.0.3'
-project.ext.compileSdk = 23
-project.ext.targetSdk = 23
+project.ext.buildtools = '24.0.3'
+project.ext.compileSdk = 24
+project.ext.targetSdk = 24

Original file line number	Diff line number	Diff line change
`@@ -39,6 +39,5 @@ public void onFocusChange(View v, boolean hasFocus) {`
`39`	`39`	`} else {`
`40`	`40`	`mTogglePasswordImage.setAlpha(mSlightlyVisible);`
`41`	`41`	`}`
`42`		`-`
`43`	`42`	`}`
`44`	`43`	`}`