fix use after free in index_lock (#546)

Alexey-N-Chernyshov · web-flow · commit 5fcc3bb13778 · 2021-12-03T14:36:35.000+03:00
Signed-off-by: Alexey Chernyshov &lt;alexey.n.chernyshov@gmail.com&gt;
diff --git a/core/sector_storage/stores/impl/index_lock.cpp b/core/sector_storage/stores/impl/index_lock.cpp
@@ -66,9 +66,10 @@ namespace fc::sector_storage::stores {
     }
     sector.write = static_cast<SectorFileType>(sector.write & ~lock.write);
     --sector.refs;
+    sector.cv.notify_all();
+    sector_lock.unlock();
     if (!sector.refs) {
       sectors.erase(lock.sector);
     }
-    sector.cv.notify_all();
   }
 }  // namespace fc::sector_storage::stores

Original file line number	Diff line number	Diff line change
`@@ -66,9 +66,10 @@ namespace fc::sector_storage::stores {`
`66`	`66`	`}`
`67`	`67`	`sector.write = static_cast<SectorFileType>(sector.write & ~lock.write);`
`68`	`68`	`--sector.refs;`
	`69`	`+ sector.cv.notify_all();`
	`70`	`+ sector_lock.unlock();`
`69`	`71`	`if (!sector.refs) {`
`70`	`72`	`sectors.erase(lock.sector);`
`71`	`73`	`}`
`72`		`- sector.cv.notify_all();`
`73`	`74`	`}`
`74`	`75`	`} // namespace fc::sector_storage::stores`