Add conditional accept header support.

Author: benubois

lib/feedkit/request.rb

@@ -27,7 +27,7 @@ def initialize(url, on_redirect: nil, auto_inflate: true, username: nil, passwor
     end
 
     def download
-      if @url.respond_to?(:host) && curl_hosts.include?(@url.host)
+      if curl_host?
         return Curl.download(@parsed_url.url)
       end
 
@@ -81,10 +81,11 @@ def client
     def headers
       Hash.new.tap do |hash|
         hash[:user_agent]        = @user_agent || "Feedbin"
-        hash[:accept_encoding]   = "gzip, deflate" if @auto_inflate
-        hash[:if_none_match]     = @etag           unless @etag.nil?
-        hash[:if_modified_since] = @last_modified  unless @last_modified.nil?
-        hash[:authorization]     = basic_auth      unless basic_auth.nil?
+        hash[:accept_encoding]   = "gzip, deflate"   if @auto_inflate
+        hash[:accept]            = "application/xml" if accept_header_host?
+        hash[:if_none_match]     = @etag             unless @etag.nil?
+        hash[:if_modified_since] = @last_modified    unless @last_modified.nil?
+        hash[:authorization]     = basic_auth        unless basic_auth.nil?
       end
     end
 
@@ -152,8 +153,14 @@ def request_error!(exception)
       end
     end
 
-    def curl_hosts
-      ENV["FEEDKIT_CURL_HOSTS"]&.split(",") || []
+    def curl_host?
+      hosts = ENV["FEEDKIT_CURL_HOSTS"]&.split(",") || []
+      @url.respond_to?(:host) && hosts.include?(@url.host)
+    end
+
+    def accept_header_host?
+      hosts = ENV["FEEDKIT_ACCEPT_HOSTS"]&.split(",") || []
+      @url.respond_to?(:host) && hosts.include?(@url.host)
     end
   end
 end

test/feedkit/request_test.rb

@@ -232,4 +232,20 @@ def test_should_allow_setting_auto_inflate
 
     assert_requested(:get, without_auto_inflate) { |request| request.headers["Accept-Encoding"] == nil }
   end
+
+  def test_should_use_accept_header
+    ENV["FEEDKIT_ACCEPT_HOSTS"] = "www.example.com"
+    with_accept_url = "http://www.example.com"
+    stub_request(:any, with_accept_url)
+
+    ::Feedkit::Request.download(with_accept_url)
+
+    assert_requested :get, with_accept_url, headers: {"Accept" => "application/xml"}
+
+    without_accept_url = "http://www.example2.com"
+    stub_request(:any, without_accept_url)
+    ::Feedkit::Request.download(without_accept_url)
+
+    assert_requested(:get, without_accept_url) { |request| request.headers["Accept"] == nil }
+  end
 end