Skip to content

Commit 44947db

Browse files
committed
Start cleaning up comments
1 parent 7eda831 commit 44947db

File tree

3 files changed

+2
-3
lines changed

3 files changed

+2
-3
lines changed

L1Trigger/Phase2L1ParticleFlow/interface/egamma/pftkegalgo_ref.h

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -413,7 +413,6 @@ namespace l1ct {
413413
const pt_t ptCorr,
414414
const id_score_t bdtScore) const;
415415

416-
// FIXME: reimplemented from PFAlgoEmulatorBase
417416
template <typename T>
418417
void ptsort_ref(int nIn, int nOut, const std::vector<T> &in, std::vector<T> &out) const {
419418
out.resize(nOut);

L1Trigger/Phase2L1ParticleFlow/interface/l1-converters/hgcalinput_ref.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,7 @@ namespace l1ct {
7979
UseEmInterp setEmInterpScenario(const std::string &emInterpScenario);
8080
bool slim_;
8181
l1ct::HgcalClusterDecoderEmulator::MultiClassID multiclass_id_;
82-
l1tpf::corrector corrector_; // FIXME: need to use it in "emulator" mode to be used in firmware testbench
82+
l1tpf::corrector corrector_;
8383
UseEmInterp emInterpScenario_;
8484
};
8585
} // namespace l1ct

L1Trigger/Phase2L1ParticleFlow/python/l1ctLayer1_cff.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -200,7 +200,7 @@
200200
),
201201
corrector = cms.string("L1Trigger/Phase2L1ParticleFlow/data/hadcorr_HGCal3D_TC.root"),
202202
correctorEmfMax = cms.double(1.125),
203-
emulateCorrections = cms.bool(False), # FIXME: should switch this on!
203+
emulateCorrections = cms.bool(False), # NOTE: should switch this on for FW bit-wise agreement!
204204
emInterpScenario = cms.string("allKeepHad"), # for all clusters, use EM intepretation to redefine the EM part of the energy
205205
),
206206
regionizerAlgo = cms.string("Multififo"),

0 commit comments

Comments
 (0)