Skip to content

fastly::log::Endpoint doesn't implement the <iostream> interfaces. #86

Description

@harmony7

I've noticed that while the code comment for fastly::log::Endpoint says I should write to the endpoint using the <iostream> interfaces, the code for the class doesn't actually implement std::ostream.

So currently it seems there is no way to output to an Endpoint instantiated using fastly::log::Endpoint::from_name().

Note this class doesn't inherit from anything:

/// A Fastly logging endpoint.
///
/// To write to this endpoint, use the `<iostream>` interface:
///
/// ```cpp
/// auto endpoint{fastly::log::Endpoint::from_name("my_log_endpoint")};
/// endpoint << "stuff happened y'all";
/// ```
class Endpoint {

Additionally, the code comment above shows fastly::log::Endpoint::from_name() being used as though it returns an fastly::log::Endpoint instance directly, but the actual SDK returns expected<fastly::log::Endpoint>.

fastly::expected<Endpoint> Endpoint::from_name(std::string_view name) {

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions