Releases: v2.55.0 #2049

This release (v2.55.0) introduces parallel command execution by default to improve performance, refines disk detection by moving folder/filesystem filtering to the detection stage, and adds support for using media cover art as logos. It also implements native GPU detection for OpenBSD and NetBSD without requiring libpciaccess.

Parallel command execution is now enabled by default with a new queue-based implementation
Media cover art can be used as logo source with support for local files
GPU detection improvements including native BSD support and refined device ID handling

Reviewed Changes

Copilot reviewed 69 out of 69 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
src/modules/media/media.c	Adds cover field to JSON output but contains a bug copying wrong field
src/detection/command/command.c	New file implementing parallel command execution queue
src/common/processing.h	Refactors process spawning to separate spawn and read operations
src/common/processing_linux.c	Splits process handling into spawn and read functions
src/common/processing_windows.c	Implements async process handling with thread-safety concern
src/detection/gpu/gpu.h	Adds helper functions for GPU device ID standardization
src/detection/gpu/gpu_*.c	Updates GPU detection across platforms to use new device ID format
src/detection/disk/disk*.c	Moves folder/filesystem filtering to detection stage for performance
src/logo/logo.c	Adds media cover art logo support with potential performance issue
src/logo/builtin.c	Adds MacaroniOS and VincentOS logos with minor formatting issue
CMakeLists.txt	Updates version to 2.55.0 and refines library configuration
debian/publish.sh	Complete rewrite with improved safety and multi-distribution support

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2025-11-11T03:13:18Z

src/logo/builtin.c

+        .colors = {
+            FF_COLOR_FG_YELLOW,
+            FF_COLOR_FG_WHITE,
+		},


Inconsistent indentation: tabs are used instead of spaces. This file appears to use spaces for indentation elsewhere.

Copilot · 2025-11-11T03:13:18Z

src/logo/logo.c

+    if (ffStrbufIgnCaseEqualS(&options->source, "mediacover"))
+    {
+        const FFMediaResult* media = ffDetectMedia(true);
+        if (media->cover.length == 0)
+            return false;
+        ffStrbufSet(&options->source, &media->cover);
+        if (media->removeCoverAfterUse) atexit(removeMediaCoverFile);


Calling ffDetectMedia(true) twice may be inefficient. The first call at line 500 already retrieves the media result, which includes the removeCoverAfterUse flag. Consider storing the result and reusing it to avoid redundant detection.

Copilot · 2025-11-11T03:13:19Z

src/common/processing_windows.c

+    static unsigned pidCounter = 0;
+    swprintf(pipeName, ARRAY_SIZE(pipeName), L"\\\\.\\pipe\\FASTFETCH-%u-%u", GetCurrentProcessId(), ++pidCounter);


The pidCounter variable is not thread-safe. If multiple threads call ffProcessSpawn concurrently, race conditions could occur leading to duplicate pipe names. Consider using atomic operations or adding thread safety documentation.

Suggested change

static unsigned pidCounter = 0;

swprintf(pipeName, ARRAY_SIZE(pipeName), L"\\\\.\\pipe\\FASTFETCH-%u-%u", GetCurrentProcessId(), ++pidCounter);

static volatile LONG pidCounter = 0;

swprintf(pipeName, ARRAY_SIZE(pipeName), L"\\\\.\\pipe\\FASTFETCH-%u-%u", GetCurrentProcessId(), InterlockedIncrement(&pidCounter));

Copilot · 2025-11-11T03:13:19Z

src/modules/media/media.c

    yyjson_mut_obj_add_strbuf(doc, song, "album", &media->album);
    yyjson_mut_obj_add_strbuf(doc, song, "status", &media->status);
+    if (media->cover.length > 0)
+        yyjson_mut_obj_add_strbuf(doc, song, "cover", &media->status);


The cover field is incorrectly assigned &media->status instead of &media->cover. This will output the wrong data in the JSON result.

…or media cover logo sources

Copilot

Pull Request Overview

Copilot reviewed 71 out of 71 changed files in this pull request and generated 6 comments.

Comments suppressed due to low confidence (1)

debian/changelog.tpl:12

The changelog template contains entries for versions 2.54.1 and 2.54.0, but the CMakeLists.txt sets the version to 2.55.0 and the PR title is "Releases: v2.55.0". The changelog template should be updated with a 2.55.0 entry to match the release version.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2025-11-11T07:02:47Z

src/common/processing.h

 static inline const char* ffProcessAppendStdOut(FFstrbuf* buffer, char* const argv[])
 {
-    const char* error = ffProcessAppendOutput(buffer, argv, false);
+    FFProcessHandle handle;


Uninitialized struct: The FFProcessHandle handle is declared without initialization. On Windows, if ffProcessSpawn returns early with an error, the handle's fields could contain garbage values. While the current code doesn't use the handle if spawn fails, it's safer to initialize it (e.g., FFProcessHandle handle = {};) to avoid potential issues if the code changes in the future.

Copilot · 2025-11-11T07:02:47Z

src/common/processing.h

 static inline const char* ffProcessAppendStdErr(FFstrbuf* buffer, char* const argv[])
 {
-    const char* error = ffProcessAppendOutput(buffer, argv, true);
+    FFProcessHandle handle;


Uninitialized struct: The FFProcessHandle handle is declared without initialization. On Windows, if ffProcessSpawn returns early with an error, the handle's fields could contain garbage values. While the current code doesn't use the handle if spawn fails, it's safer to initialize it (e.g., FFProcessHandle handle = {};) to avoid potential issues if the code changes in the future.

Copilot · 2025-11-11T07:02:47Z

src/detection/media/media_linux.c

+                        if (path.chars[i] == '%')
+                        {
+                            if (i + 2 >= path.length)
+                                break;
+                            char str[] = { path.chars[i + 1], path.chars[i + 2], 0 };
+                            const char decodedChar = (char) strtoul(str, NULL, 16);
+                            i += 2;
+                            ffStrbufAppendC(&result->cover, decodedChar);


Potential buffer overflow: The URL decoding logic doesn't validate that strtoul successfully parsed the hex value. If the hex string is invalid, this could append incorrect characters. Consider checking the result or using safer parsing.

Copilot · 2025-11-11T07:02:47Z

src/detection/media/media.c

+        if (saveCover && result.removeCoverAfterUse)
+            atexit(removeMediaCoverFile);


Potential issue with atexit: Registering removeMediaCoverFile with atexit means it will only be called once at program termination. However, if ffDetectMedia(true) is called multiple times with different cover files, only the last cover file path will be stored in the static result.cover, and previous temporary cover files won't be cleaned up. Consider tracking multiple cover files or cleaning up the previous file before creating a new one.

Copilot · 2025-11-11T07:02:48Z

src/detection/command/command.c

+// FIFO, non-thread-safe list of running commands
+static FFlist commandQueue = {
+    .elementSize = sizeof(FFCommandResultBundle),
+};


The comment says "non-thread-safe list" which is good documentation, but the global static commandQueue could be problematic if commands are executed concurrently from multiple threads. Consider adding a mutex or documenting that this module should only be used from a single thread.

Copilot · 2025-11-11T07:02:48Z

src/detection/terminalshell/terminalshell.c

+    //fish, version 4.0.2-1 (Built by MSYS2 project) // version can be localized if LC_ALL is set
+    if (version->length < strlen("fish, v")) return false;
+    uint32_t index = ffStrbufNextIndexC(version, strlen("fish, "), ' ');
+    ffStrbufSubstrAfter(version, index);


Missing validation: The fish version detection assumes the string has at least strlen("fish, v") characters but doesn't validate the actual format after finding the space. If the output format changes or is localized differently, the index could point beyond the string bounds when passed to ffStrbufSubstrAfter. Consider adding bounds checking after finding the space index.

Copilot

Pull Request Overview

Copilot reviewed 71 out of 71 changed files in this pull request and generated 3 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2025-11-11T08:03:30Z

src/detection/weather/weather.c

+    state = (FFNetworkingState){};
+    status = FF_UNITIALIZED;


Resetting state after reading response prevents module reuse. The module resets state and status to their initial values after reading the response, which contradicts the error message in ffPrepareWeather stating "Weather module can only be used once due to internal limitations". Either remove the reset (lines 48-49) or remove the restriction in ffPrepareWeather.

Copilot · 2025-11-11T08:03:30Z

src/util/apple/cf_helpers.h


 static inline void cfReleaseWrapper(void* type)
 {
+    assert(type);


Unnecessary assert statement. The assert(type) is redundant because type is a pointer to the stack variable and can never be NULL. The actual null check needed is on line 28 for *(CFTypeRef*) type. Consider removing line 27.

Copilot · 2025-11-11T08:03:30Z

src/detection/command/command.c

+    FFCommandResultBundle* bundle = ffListAdd(&commandQueue);
+    bundle->error = spawnProcess(options, &bundle->handle);
+


Potential resource leak when parallel execution is enabled. If spawnProcess fails on line 38, the bundle is added to the queue with an error, but the process handle may contain allocated resources that are never cleaned up. The handle should be initialized or the bundle should not be added to the queue if spawning fails.

Suggested change

FFCommandResultBundle* bundle = ffListAdd(&commandQueue);

bundle->error = spawnProcess(options, &bundle->handle);

FFCommandResultBundle bundle = {};

bundle.error = spawnProcess(options, &bundle.handle);

if (bundle.error)

return false;

*(FFCommandResultBundle*)ffListAdd(&commandQueue) = bundle;

CarterLi and others added 30 commits October 18, 2025 18:38

JsonSchema: fixes copy-paste errors [ci skip]

dc3e4a2

Fixes #2013

Shell: fix fish version detection when LC_ALL is set

6a31736

Fixes #2014

Shell: supports brush version detection

ff28f58

Merge remote-tracking branch 'origin/master' into dev

8f15c96

Packaging: builds for all Ubuntu versions [ci skip]

904f860

Logo (Builtin): adds MacaroniOS

f71bb68

Fixes #2018

Doc: adds code-signing credit and privacy statement in README [ci skip]

3fe926d

As required by signpath

Utils (macOS): adds ffCfDictGetDataAsString

5cf3ab2

Media (macOS): adds media cover extraction

64afaa0

Media (Linux): adds media cover extraction

2d9bbc8

Media (Windows): adds media cover extraction

faddef7

Media: save media cover to temp file

5d73cc1

Logo: adds support for using media cover as logo source

338b552

Logo: adds automatic cleanup of temporary media cover files

c353bf3

CI (Linux): adds Debian i386 packaging and verify deb package in CI

db623b9

Fixes #2019

Icons (Windows): hides module when no icons are found

758f96d

Fixes #2023

CMake: refines yyjson config and Apple rpath handling

ac62442

Fixes #1998

GPU: unifies GPU PCI device ID calculation logic across different pla…

7d665b2

…tforms

GPU: unifies non-pci GPU device ID formatting across platforms

25e84de

GPU: skips auxiliary display controllers

11d1754

Fixes #2034

GPU (NetBSD): adds native GPU detection support

04d6b14

OS (Linux): prints debian version on Raspbery Pi OS

b761034

Fixes #2032

Logo (Builtin): add Vincent OS

e0fd730

Fixes #2030

GPU (NetBSD): improves performance; drops libpciaccess dependency

907567f

GPU: handles missing GPU type as null in JSON output

e63b777

GPU (NetBSD): don't use system function name

cc6273f

GPU (OpenBSD): adds native GPU detection support

2e73a90

GPU (Hurd): adds support (requires libpciaccess)

578ca23

Linux (Host): improves Mac family detection by using prefix match

6b8a62d

PublicIP / Weather: cleans up states after detection

c51a164

CarterLi and others added 8 commits November 10, 2025 16:34

Command: adds parallel and useStdErr options

ea92ad3

Fixes #2045

Processing: adds a missing header

9401a4b

Command: makes compiler happy

448de9a

Examples: improves clang version extraction method in 25.jsonc [ci …

298c043

…skip]

[Command] enables parallel command execution by default

cb0a88d

Examples/25: removes parallel: true since we had it enabled by defa…

056fe21

…ult [ci skip]

TerminalShell (Linux): ignores run-parts

8b8eb6f

Ref: #2048

Releases: v2.55.0

f8bc1cb

CarterLi requested a review from Copilot November 11, 2025 03:03

Copilot started reviewing on behalf of CarterLi November 11, 2025 03:08 View session

Copilot finished reviewing on behalf of CarterLi November 11, 2025 03:10

Copilot AI reviewed Nov 11, 2025

View reviewed changes

CarterLi added 6 commits November 11, 2025 13:53

Logo (Builtin): tidy [ci skip]

11cd715

Media: fixes album cover serialization in JSON result

e6b0bd3

Media: moves media cover cleanup logic to media detection

df15bbc

Chore: silenses some compiler warnings

0aed890

Doc: update changelog

a9f1f9a

Media: updates naming convention from mediacover to media-cover f…

084f929

…or media cover logo sources

CarterLi requested a review from Copilot November 11, 2025 06:47

Copilot started reviewing on behalf of CarterLi November 11, 2025 06:55 View session

Copilot finished reviewing on behalf of CarterLi November 11, 2025 06:58

Copilot AI reviewed Nov 11, 2025

View reviewed changes

CarterLi added 3 commits November 11, 2025 15:16

Media (Linux): handles invalid percent-encoding in cover metadata

9f24e43

Shell: makes fish shell version detection more robust

fb91175

Shell: makes fish shell version detection more robust (v2)

662f512

CarterLi requested a review from Copilot November 11, 2025 07:58

Copilot started reviewing on behalf of CarterLi November 11, 2025 07:58 View session

Copilot finished reviewing on behalf of CarterLi November 11, 2025 08:02

Copilot AI reviewed Nov 11, 2025

View reviewed changes

CarterLi merged commit 7a2bf4e into master Nov 11, 2025
51 checks passed

		static unsigned pidCounter = 0;
		swprintf(pipeName, ARRAY_SIZE(pipeName), L"\\\\.\\pipe\\FASTFETCH-%u-%u", GetCurrentProcessId(), ++pidCounter);

		if (saveCover && result.removeCoverAfterUse)
		atexit(removeMediaCoverFile);

		FFCommandResultBundle* bundle = ffListAdd(&commandQueue);
		bundle->error = spawnProcess(options, &bundle->handle);

-    FFCommandResultBundle* bundle = ffListAdd(&commandQueue);
-    bundle->error = spawnProcess(options, &bundle->handle);
+    FFCommandResultBundle bundle = {};
+    bundle.error = spawnProcess(options, &bundle.handle);
+    if (bundle.error)
+        return false;
+    *(FFCommandResultBundle*)ffListAdd(&commandQueue) = bundle;

Uh oh!

Releases: v2.55.0 #2049

Releases: v2.55.0 #2049

Uh oh!

Conversation

CarterLi commented Nov 11, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Nov 11, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 11, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 11, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 11, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Copilot AI Nov 11, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 11, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 11, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 11, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 11, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 11, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Copilot AI Nov 11, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 11, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 11, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants