feat(broadcasting): add Broadcast.pyi stub + full broadcasting test suite#94
Merged
Merged
Conversation
…b + full test suite Adds the complete Reverb broadcasting module (Pusher-protocol WebSocket server + Laravel-style broadcast API), the Broadcast.pyi type stub, and a 31-test suite covering channels, events, drivers, the Reverb WS server, manager, and helper. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- test_channels.py: remove unused `import pytest` - test_log_driver.py: remove unused `import logging` and `MagicMock` Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
broadcasting/) — Pusher-protocol WebSocket server + Laravel-style broadcast APIfacades/Broadcast.pyitype stub exposingevent()andchannel()with correct signaturestest_channels.py— Channel, PrivateChannel (private-), PresenceChannel (presence-) prefixestest_event.py— BroadcastEvent methods, ShouldBroadcast ABC enforcementtest_log_driver.py— LogDriver logs correct channel/event/datatest_reverb_server.py— WS connect → connection_established, ping/pong, subscribe → succeeded, broadcast deliverytest_manager.py— driver resolution, unknown driver error, event dispatchtest_broadcast_helper.py— helper resolvesbroadcastingkey and callsmanager.event()Test plan
uv run pytest tests/broadcasting/ -v→ 31 passed🤖 Generated with Claude Code