fix(sqlite): emit INTEGER PRIMARY KEY AUTOINCREMENT inline for id() c…#92
Merged
Conversation
…olumns SQLite requires AUTOINCREMENT as an inline column constraint, not a table-level constraint. big_increments and increments columns now emit `INTEGER PRIMARY KEY AUTOINCREMENT` directly, and the redundant CONSTRAINT...PRIMARY KEY table clause is suppressed for those columns. Also skip the sqlite_sequence system table during test teardown to prevent drop errors introduced by AUTOINCREMENT usage. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
bedus-creation
commented
Jun 6, 2026
|
|
||
| async with await self.schema.create("users") as blueprint: | ||
| blueprint.increments("id") | ||
| blueprint.string("name") |
Contributor
Author
There was a problem hiding this comment.
does just blueprint.id() works as well?
Filter out SQLite internal system tables (sqlite_sequence, sqlite_stat*) in Migrator.drop_all_tables() before issuing DROP TABLE, preventing the OperationalError raised when migrate:fresh encounters auto-created system tables after AUTOINCREMENT columns are used. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…olumns
SQLite requires AUTOINCREMENT as an inline column constraint, not a table-level constraint. big_increments and increments columns now emit
INTEGER PRIMARY KEY AUTOINCREMENTdirectly, and the redundant CONSTRAINT...PRIMARY KEY table clause is suppressed for those columns. Also skip the sqlite_sequence system table during test teardown to prevent drop errors introduced by AUTOINCREMENT usage.