From 69c8a0d019f3ec1b6bdcc55198caa274ba1ac6f9 Mon Sep 17 00:00:00 2001 From: Pieter De Baets Date: Wed, 22 Apr 2026 00:54:51 -0700 Subject: [PATCH] Flatten ReactCxxPlatform timer registry directory structure (#56536) Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/56536 Move `PlatformTimerRegistryImpl.{h,cpp}` from `platform/cxx/react/runtime/` to the top level of `ReactCxxPlatform/react/runtime/`. The `platform/cxx/` nesting was an artifact of the multi-platform build setup that is no longer needed since `:timer_registry` is a standalone target. - Remove dead `platform/cxx/react/runtime/*` glob patterns from `:runtime` BUCK target - Remove `platform/cxx/` include directory from CMakeLists.txt - Exported header path unchanged: `react/runtime/PlatformTimerRegistryImpl.h` Changelog: [Internal] Reviewed By: christophpurrer Differential Revision: D101811797 --- .../ReactCxxPlatform/react/runtime/CMakeLists.txt | 5 ++--- .../cxx/react/runtime => }/PlatformTimerRegistryImpl.cpp | 0 .../cxx/react/runtime => }/PlatformTimerRegistryImpl.h | 0 3 files changed, 2 insertions(+), 3 deletions(-) rename packages/react-native/ReactCxxPlatform/react/runtime/{platform/cxx/react/runtime => }/PlatformTimerRegistryImpl.cpp (100%) rename packages/react-native/ReactCxxPlatform/react/runtime/{platform/cxx/react/runtime => }/PlatformTimerRegistryImpl.h (100%) diff --git a/packages/react-native/ReactCxxPlatform/react/runtime/CMakeLists.txt b/packages/react-native/ReactCxxPlatform/react/runtime/CMakeLists.txt index 0151f15a2b4e..01bf276bb49d 100644 --- a/packages/react-native/ReactCxxPlatform/react/runtime/CMakeLists.txt +++ b/packages/react-native/ReactCxxPlatform/react/runtime/CMakeLists.txt @@ -8,13 +8,12 @@ set(CMAKE_VERBOSE_MAKEFILE on) include(${REACT_COMMON_DIR}/cmake-utils/react-native-flags.cmake) -file(GLOB react_cxx_platform_react_runtime_SRC CONFIGURE_DEPENDS *.cpp platform/cxx/react/runtime/*.cpp) +file(GLOB react_cxx_platform_react_runtime_SRC CONFIGURE_DEPENDS *.cpp) add_library(react_cxx_platform_react_runtime OBJECT ${react_cxx_platform_react_runtime_SRC}) target_include_directories(react_cxx_platform_react_runtime PUBLIC - ${REACT_CXX_PLATFORM_DIR} - ${CMAKE_CURRENT_SOURCE_DIR}/platform/cxx/) + ${REACT_CXX_PLATFORM_DIR}) target_link_libraries(react_cxx_platform_react_runtime bridgeless diff --git a/packages/react-native/ReactCxxPlatform/react/runtime/platform/cxx/react/runtime/PlatformTimerRegistryImpl.cpp b/packages/react-native/ReactCxxPlatform/react/runtime/PlatformTimerRegistryImpl.cpp similarity index 100% rename from packages/react-native/ReactCxxPlatform/react/runtime/platform/cxx/react/runtime/PlatformTimerRegistryImpl.cpp rename to packages/react-native/ReactCxxPlatform/react/runtime/PlatformTimerRegistryImpl.cpp diff --git a/packages/react-native/ReactCxxPlatform/react/runtime/platform/cxx/react/runtime/PlatformTimerRegistryImpl.h b/packages/react-native/ReactCxxPlatform/react/runtime/PlatformTimerRegistryImpl.h similarity index 100% rename from packages/react-native/ReactCxxPlatform/react/runtime/platform/cxx/react/runtime/PlatformTimerRegistryImpl.h rename to packages/react-native/ReactCxxPlatform/react/runtime/PlatformTimerRegistryImpl.h