Skip to content

Commit d805bb0

Browse files
generatedunixname89002005287564meta-codesync[bot]
authored andcommitted
Fix CQS signal modernize-use-equals-default in fbcode/proxygen/lib [B]
Differential Revision: D89560764 fbshipit-source-id: 27c504a02ddd404da0cadc80b0c0dbcc87ce9bab
1 parent 0c4c027 commit d805bb0

File tree

12 files changed

+16
-32
lines changed

12 files changed

+16
-32
lines changed

proxygen/lib/http/codec/compress/experimental/simulator/CompressionScheme.h

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -20,13 +20,11 @@ class CompressionScheme : public folly::EventBase::LoopCallback {
2020
public:
2121
explicit CompressionScheme(CompressionSimulator* sim) : simulator_(sim) {
2222
}
23-
~CompressionScheme() override {
24-
}
23+
~CompressionScheme() override = default;
2524

2625
/* Parent class for acks */
2726
struct Ack {
28-
virtual ~Ack() {
29-
}
27+
virtual ~Ack() = default;
3028
};
3129

3230
/* Generate an ack for the given sequence number */

proxygen/lib/http/codec/test/HQFramerTest.cpp

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -46,8 +46,7 @@ bool isValidPushId(folly::Optional<PushId> maxAllowedPushId, PushId pushId) {
4646
template <class T>
4747
class HQFramerTestFixture : public T {
4848
public:
49-
HQFramerTestFixture() {
50-
}
49+
HQFramerTestFixture() = default;
5150

5251
template <typename Func, typename... Args>
5352
void parse(ParseResult parseError,

proxygen/lib/http/codec/test/HTTP1xCodecTest.cpp

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,8 +23,7 @@ using namespace testing;
2323

2424
class HTTP1xCodecCallback : public HTTPCodec::Callback {
2525
public:
26-
HTTP1xCodecCallback() {
27-
}
26+
HTTP1xCodecCallback() = default;
2827

2928
void onMessageBegin(HTTPCodec::StreamID /*stream*/,
3029
HTTPMessage* /*msg*/) override {

proxygen/lib/http/codec/test/HTTP2CodecTest.cpp

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1892,10 +1892,8 @@ TEST_F(HTTP2CodecTest, BadRFC9218Priority) {
18921892

18931893
class DummyQueue : public HTTPCodec::PriorityQueue {
18941894
public:
1895-
DummyQueue() {
1896-
}
1897-
~DummyQueue() override {
1898-
}
1895+
DummyQueue() = default;
1896+
~DummyQueue() override = default;
18991897
void addPriorityNode(HTTPCodec::StreamID id, HTTPCodec::StreamID) override {
19001898
nodes_.push_back(id);
19011899
}

proxygen/lib/http/codec/test/HTTP2FramerTest.cpp

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -35,8 +35,7 @@ void writeFrameHeaderManual(IOBufQueue& queue,
3535

3636
class HTTP2FramerTest : public testing::Test {
3737
public:
38-
HTTP2FramerTest() {
39-
}
38+
HTTP2FramerTest() = default;
4039

4140
template <typename ParseFunc, typename... Args>
4241
void parse(ParseFunc&& parseFn, FrameHeader& outHeader, Args&&... outArgs) {

proxygen/lib/http/codec/test/TestUtils.h

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -116,8 +116,7 @@ size_t parseUnidirectional(
116116

117117
class FakeHTTPCodecCallback : public HTTPCodec::Callback {
118118
public:
119-
FakeHTTPCodecCallback() {
120-
}
119+
FakeHTTPCodecCallback() = default;
121120

122121
void onMessageBegin(HTTPCodec::StreamID /*stream*/, HTTPMessage*) override {
123122
messageBegin++;

proxygen/lib/http/connpool/ServerIdleSessionController.h

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,8 +23,7 @@ namespace proxygen {
2323
*/
2424
class ServerIdleSessionController {
2525
public:
26-
explicit ServerIdleSessionController() {
27-
}
26+
explicit ServerIdleSessionController() = default;
2827

2928
/**
3029
* Transfer idle session from another thread, if available.

proxygen/lib/http/connpool/SessionHolder.h

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -26,8 +26,7 @@ class SessionHolder : private HTTPSessionBase::InfoCallback {
2626
public:
2727
class Callback {
2828
public:
29-
virtual ~Callback() {
30-
}
29+
virtual ~Callback() = default;
3130
virtual void detachIdle(SessionHolder*) = 0;
3231
virtual void detachPartiallyFilled(SessionHolder*) = 0;
3332
virtual void detachFilled(SessionHolder*) = 0;
@@ -39,8 +38,7 @@ class SessionHolder : private HTTPSessionBase::InfoCallback {
3938

4039
class Stats {
4140
public:
42-
virtual ~Stats() {
43-
}
41+
virtual ~Stats() = default;
4442
virtual void onConnectionCreated() = 0;
4543
virtual void onConnectionClosed() = 0;
4644
virtual void onConnectionActivated() = 0;

proxygen/lib/http/coro/HTTPCoroSession.h

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -91,8 +91,7 @@ using HTTPSessionContextPtr = detail::KeepAlivePtr<HTTPSessionContext>;
9191
*/
9292
class HTTPHandler {
9393
public:
94-
virtual ~HTTPHandler() {
95-
}
94+
virtual ~HTTPHandler() = default;
9695
virtual folly::coro::Task<HTTPSourceHolder> handleRequest(
9796
folly::EventBase* evb,
9897
HTTPSessionContextPtr ctx,

proxygen/lib/http/coro/HTTPSource.h

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -66,8 +66,7 @@ namespace proxygen::coro {
6666
*/
6767
class HTTPSource {
6868
public:
69-
virtual ~HTTPSource() {
70-
}
69+
virtual ~HTTPSource() = default;
7170

7271
virtual folly::coro::Task<HTTPHeaderEvent> readHeaderEvent() = 0;
7372

0 commit comments

Comments
 (0)