fix: use string types for open

Author: dbrattli

.config/dotnet-tools.json

@@ -3,13 +3,13 @@
   "isRoot": true,
   "tools": {
     "paket": {
-      "version": "6.2.1",
+      "version": "7.1.5",
       "commands": [
         "paket"
       ]
     },
     "fantomas-tool": {
-      "version": "4.5.10",
+      "version": "4.7.9",
       "commands": [
         "fantomas"
       ]

src/stdlib/Ast.fs

@@ -8,7 +8,7 @@ type _identifier = string
 
 
 type AST =
-    abstract foo : int
+    abstract foo: int
 
 type ``mod`` =
     inherit AST
@@ -18,11 +18,11 @@ type expr =
 
 type Module =
     inherit ``mod``
-    abstract body : stmt array
+    abstract body: stmt array
 
 type Expression =
     inherit ``mod``
-    abstract body : expr
+    abstract body: expr
 
 type stmt =
     inherit AST
@@ -31,74 +31,74 @@ type stmt =
 type FunctionDef =
     inherit stmt
 
-    abstract name : _identifier
-    abstract args : arguments
-    abstract body : stmt array
-    abstract decorator_list : expr array
-    abstract returns : expr option
+    abstract name: _identifier
+    abstract args: arguments
+    abstract body: stmt array
+    abstract decorator_list: expr array
+    abstract returns: expr option
 
 type ClassDef =
     inherit stmt
-    abstract name : _identifier
-    abstract bases : expr array
-    abstract keywords : keyword array
-    abstract body : stmt array
-    abstract decorator_list : expr array
+    abstract name: _identifier
+    abstract bases: expr array
+    abstract keywords: keyword array
+    abstract body: stmt array
+    abstract decorator_list: expr array
 
 type Return =
     inherit stmt
-    abstract value : expr option
+    abstract value: expr option
 
 type Delete =
     inherit stmt
-    abstract targets : expr array
+    abstract targets: expr array
 
 type Assign =
     inherit stmt
-    abstract targets : expr array
-    abstract value : expr
+    abstract targets: expr array
+    abstract value: expr
 
 type Import =
     inherit stmt
-    abstract names : alias array
+    abstract names: alias array
 
 type ImportFrom =
     inherit stmt
-    abstract ``module`` : _identifier option
-    abstract names : alias array
-    abstract level : int
+    abstract ``module``: _identifier option
+    abstract names: alias array
+    abstract level: int
 
 type If =
     inherit stmt
-    abstract test : expr
-    abstract body : stmt array
-    abstract orelse : stmt array
+    abstract test: expr
+    abstract body: stmt array
+    abstract orelse: stmt array
 
 type arguments =
     inherit AST
 
-    abstract posonlyargs : arg array
-    abstract args : arg array
-    abstract vararg : arg option
-    abstract kwonlyargs : arg array
-    abstract kw_defaults : expr option list
-    abstract kwarg : arg option
-    abstract defaults : expr array
+    abstract posonlyargs: arg array
+    abstract args: arg array
+    abstract vararg: arg option
+    abstract kwonlyargs: arg array
+    abstract kw_defaults: expr option list
+    abstract kwarg: arg option
+    abstract defaults: expr array
 
 type arg =
     inherit AST
-    abstract arg : _identifier
-    abstract annotation : expr option
+    abstract arg: _identifier
+    abstract annotation: expr option
 
 type keyword =
     inherit AST
-    abstract arg : _identifier option
-    abstract value : expr
+    abstract arg: _identifier option
+    abstract value: expr
 
 type alias =
     inherit AST
-    abstract name : _identifier
-    abstract asname : _identifier option
+    abstract name: _identifier
+    abstract asname: _identifier option
 
 
 [<StringEnum>]
@@ -108,17 +108,17 @@ type Mode =
 
 type IExports =
     /// Parse the source into an AST node
-    abstract parse : string -> AST
-    abstract parse : string * filename: string -> AST
-    abstract parse : string * filename: string * mode: Mode -> AST
-    abstract unparse : astObj: AST -> string
-    abstract walk : node: AST -> AST array
+    abstract parse: string -> AST
+    abstract parse: string * filename: string -> AST
+    abstract parse: string * filename: string * mode: Mode -> AST
+    abstract unparse: astObj: AST -> string
+    abstract walk: node: AST -> AST array
     /// Return a formatted dump of the tree in node.
-    abstract dump : node: AST -> string
+    abstract dump: node: AST -> string
     /// Return a formatted dump of the tree in node.
-    abstract dump : node: AST * annotate_fields: bool -> string
+    abstract dump: node: AST * annotate_fields: bool -> string
     /// Return a formatted dump of the tree in node.
-    abstract dump : node: AST * annotate_fields: bool * include_attributes: bool -> string
+    abstract dump: node: AST * annotate_fields: bool * include_attributes: bool -> string
 
 [<ImportAll("ast")>]
 let ast: IExports = nativeOnly

src/stdlib/Builtins.fs

@@ -15,70 +15,54 @@ type TextIOWrapper =
     inherit IDisposable
     inherit TextIOBase
 
-[<StringEnum>]
-type OpenTextModeUpdating =
-    | [<CompiledName("r+")>] ReadUpdate
-    | [<CompiledName("+r")>] UpdateRead
-    | [<CompiledName("rt+")>] ReadTextUpdate
-    | [<CompiledName("r+t")>] ReadUpdateText
-    | [<CompiledName("+rt")>] UpdateReadText
-    | [<CompiledName("tr+")>] TextReadUpdate
-    | [<CompiledName("t+r")>] TextUpdateRead
-    | [<CompiledName("+tr")>] UpdateTextRead
-    | [<CompiledName("w+")>] WriteUpdate
-    | [<CompiledName("+w")>] UpdateWrite
-    | [<CompiledName("wt+")>] WriteTextUpdate
-    | [<CompiledName("w+t")>] WriteUpdateText
-    | [<CompiledName("+wt")>] UpdateWriteText
-    | [<CompiledName("tw+")>] TextWriteUpdate
-    | [<CompiledName("t+w")>] TextUpdateWrite
-    | [<CompiledName("+tw")>] UpdateTextWrite
-    | [<CompiledName("a+")>] AppendUpdate
-    | [<CompiledName("+a")>] UpdateAppend
-    | [<CompiledName("at+")>] AppendTextUpdate
-    | [<CompiledName("a+t")>] AppendUpdateText
-    | [<CompiledName("+at")>] UpdateAppendText
-    | [<CompiledName("ta+")>] TextAppendUpdate
-    | [<CompiledName("t+a")>] TextUpdateAppend
-    | [<CompiledName("+ta")>] UpdateTextAppend
-    | [<CompiledName("x+")>] CreateUpdate
-    | [<CompiledName("+x")>] UpdateCreate
-    | [<CompiledName("xt+")>] CreateTextUpdate
-    | [<CompiledName("x+t")>] CreateUpdateText
-    | [<CompiledName("+xt")>] UpdateCreateText
-    | [<CompiledName("tx+")>] TextCreateUpdate
-    | [<CompiledName("t+x")>] TextUpdateCreate
-    | [<CompiledName("+tx")>] UpdateTextCreate
+module OpenTextMode =
+    let [<Literal>] ReadUpdate = "r+"
+    let [<Literal>] UpdateRead = "+r"
+    let [<Literal>] ReadTextUpdate = "rt+"
+    let [<Literal>] ReadUpdateText = "r+t"
+    let [<Literal>] UpdateReadText = "+rt"
+    let [<Literal>] TextReadUpdate = "tr+"
+    let [<Literal>] TextUpdateRead = "t+r"
+    let [<Literal>] UpdateTextRead = "+tr"
+    let [<Literal>] WriteUpdate = "w+"
+    let [<Literal>] UpdateWrite = "+w"
+    let [<Literal>] WriteTextUpdate = "wt+"
+    let [<Literal>] WriteUpdateText = "w+t"
+    let [<Literal>] UpdateWriteText = "+wt"
+    let [<Literal>] TextWriteUpdate = "tw+"
+    let [<Literal>] TextUpdateWrite = "t+w"
+    let [<Literal>] UpdateTextWrite = "+tw"
+    let [<Literal>] AppendUpdate = "a+"
+    let [<Literal>] UpdateAppend = "+a"
+    let [<Literal>] AppendTextUpdate = "at+"
+    let [<Literal>] AppendUpdateText = "a+t"
+    let [<Literal>] UpdateAppendText = "+at"
+    let [<Literal>] TextAppendUpdate = "ta+"
+    let [<Literal>] TextUpdateAppend = "t+a"
+    let [<Literal>] UpdateTextAppend = "+ta"
+    let [<Literal>] CreateUpdate = "x+"
+    let [<Literal>] UpdateCreate = "+x"
+    let [<Literal>] CreateTextUpdate = "xt+"
+    let [<Literal>] CreateUpdateText = "x+t"
+    let [<Literal>] UpdateCreateText = "+xt"
+    let [<Literal>] TextCreateUpdate = "tx+"
+    let [<Literal>] TextUpdateCreate = "t+x"
+    let [<Literal>] UpdateTextCreate = "+tx"
+
+    let [<Literal>] Read = "rt"
+    let [<Literal>] ReadText = "rt"
+    let [<Literal>] TextRead = "tr"
+
+    let [<Literal>] Write = "w"
+    let [<Literal>] WriteText = "wt"
+    let [<Literal>] TextWrite = "tw"
+    let [<Literal>] Append = "a"
+    let [<Literal>] AppendText = "at"
+    let [<Literal>] TextAppend = "ta"
+    let [<Literal>] Create = "x"
+    let [<Literal>] CreateText = "xt"
+    let [<Literal>] TextCreate = "tx"
 
-[<StringEnum>]
-type OpenTextModeReading =
-    | [<CompiledName("rt")>] Read
-    | [<CompiledName("rt")>] ReadText
-    | [<CompiledName("tr")>] TextRead
-
-[<StringEnum>]
-type OpenTextModeWriting =
-    | [<CompiledName("w")>] Write
-    | [<CompiledName("wt")>] WriteText
-    | [<CompiledName("tw")>] TextWrite
-    | [<CompiledName("a")>] Append
-    | [<CompiledName("at")>] AppendText
-    | [<CompiledName("ta")>] TextAppend
-    | [<CompiledName("x")>] Create
-    | [<CompiledName("xt")>] CreateText
-    | [<CompiledName("tx")>] TextCreate
-
-[<Erase>]
-type OpenTextMode =
-    | OpenTextModeUpdating
-    | OpenTextModeWriting
-    | OpenTextModeReading
-
-
-[<Erase>]
-type _OpenFile =
-    | StringPath of string
-    | FileDescriptor of int
 
 type _Opener = Tuple<string, int> -> int
 
@@ -120,7 +104,8 @@ type IExports =
     abstract float : obj -> float
     abstract print : obj: obj -> unit
 
-    [<NamedParams(fromIndex=1)>] abstract ``open`` : file: _OpenFile * ?mode: OpenTextMode * ?buffering: int * ?encoding: string * ?errors: string * ?newline: string * ?closefd: bool * ?opener: _Opener -> TextIOWrapper
+    [<NamedParams(fromIndex=1)>] abstract ``open`` : file: int * ?mode: string * ?buffering: int * ?encoding: string * ?errors: string * ?newline: string * ?closefd: bool * ?opener: _Opener -> TextIOWrapper
+    [<NamedParams(fromIndex=1)>] abstract ``open`` : file: string * ?mode: string * ?buffering: int * ?encoding: string * ?errors: string * ?newline: string * ?closefd: bool * ?opener: _Opener -> TextIOWrapper
 
 [<ImportAll("builtins")>]
 let builtins: IExports = nativeOnly

src/stdlib/Json.fs

@@ -5,8 +5,8 @@ open Fable.Core
 // fsharplint:disable MemberNames
 
 type IExports =
-    abstract dumps : obj: obj -> string
-    abstract loads : string -> obj
+    abstract dumps: obj: obj -> string
+    abstract loads: string -> obj
 
 [<ImportAll("json")>]
 let json: IExports = nativeOnly