Refactor generate-artifacts-executor.js: keep schema in memory instead of writing/reading from disk (facebook#41554)

Summary:
Pull Request resolved: facebook#41554

This diff removes inefficiency where we first write schema to disk in `combine-js-to-schema.js`, and then read it from disk in `generate-specs-cli-executor.js`. With this change we can just pass it as an argument.
Changelog: [Internal]

Reviewed By: cipolleschi

Differential Revision: D51161162

fbshipit-source-id: 35d14ca3e53e4bf999520c635c66909c20081096

Author: dmytrorykun

packages/react-native-codegen/src/cli/combine/combine-js-to-schema-cli.js

@@ -11,9 +11,11 @@
 
 'use strict';
 
-const {combineSchemasInFileList} = require('./combine-js-to-schema');
+const {
+  combineSchemasInFileListAndWriteToFile,
+} = require('./combine-js-to-schema');
 const {parseArgs} = require('./combine-utils');
 
 const {platform, outfile, fileList} = parseArgs(process.argv);
 
-combineSchemasInFileList(fileList, platform, outfile);
+combineSchemasInFileListAndWriteToFile(fileList, platform, outfile);

packages/react-native-codegen/src/cli/combine/combine-js-to-schema.js

@@ -72,20 +72,29 @@ function expandDirectoriesIntoFiles(
 function combineSchemasInFileList(
   fileList: Array<string>,
   platform: ?string,
-  outfile: string,
-): void {
+): SchemaType {
   const expandedFileList = expandDirectoriesIntoFiles(fileList, platform);
   const combined = combineSchemas(expandedFileList);
   if (Object.keys(combined.modules).length === 0) {
     console.error(
       'No modules to process in combine-js-to-schema-cli. If this is unexpected, please check if you set up your NativeComponent correctly. See combine-js-to-schema.js for how codegen finds modules.',
     );
   }
+  return combined;
+}
+
+function combineSchemasInFileListAndWriteToFile(
+  fileList: Array<string>,
+  platform: ?string,
+  outfile: string,
+): void {
+  const combined = combineSchemasInFileList(fileList, platform);
   const formattedSchema = JSON.stringify(combined, null, 2);
   fs.writeFileSync(outfile, formattedSchema);
 }
 
 module.exports = {
   combineSchemas,
   combineSchemasInFileList,
+  combineSchemasInFileListAndWriteToFile,
 };

packages/react-native/scripts/codegen/generate-artifacts-executor.js

@@ -256,31 +256,28 @@ function computeIOSOutputDir(outputPath, appRootDir) {
   return path.join(outputPath ? outputPath : appRootDir, 'build/generated/ios');
 }
 
-function generateSchema(tmpDir, library) {
-  const pathToSchema = path.join(tmpDir, 'schema.json');
+function generateSchema(library) {
   const pathToJavaScriptSources = path.join(
     library.libraryPath,
     library.config.jsSrcsDir,
   );
   console.log(`\n\n[Codegen] >>>>> Processing ${library.config.name}`);
   // Generate one schema for the entire library...
-  utils
+  return utils
     .getCombineJSToSchema()
-    .combineSchemasInFileList([pathToJavaScriptSources], 'ios', pathToSchema);
-  console.log(`[Codegen] Generated schema: ${pathToSchema}`);
-  return pathToSchema;
+    .combineSchemasInFileList([pathToJavaScriptSources], 'ios');
 }
 
-function generateCode(iosOutputDir, library, tmpDir, pathToSchema) {
+function generateCode(iosOutputDir, library, tmpDir, schema) {
   // ...then generate native code artifacts.
   const libraryTypeArg = library.config.type ? `${library.config.type}` : '';
 
   const tmpOutputDir = path.join(tmpDir, 'out');
   fs.mkdirSync(tmpOutputDir, {recursive: true});
 
-  generateSpecsCLIExecutor.execute(
+  generateSpecsCLIExecutor.generateSpecFromInMemorySchema(
     'ios',
-    pathToSchema,
+    schema,
     tmpOutputDir,
     library.config.name,
     'com.facebook.fbreact.specs',
@@ -295,34 +292,31 @@ function generateCode(iosOutputDir, library, tmpDir, pathToSchema) {
   console.log(`[Codegen] Generated artifacts: ${iosOutputDir}`);
 }
 
-function generateNativeCodegenFiles(libraries, iosOutputDir, schemaPaths) {
+function generateNativeCodegenFiles(libraries, iosOutputDir) {
+  const schemas = {};
   libraries.forEach(library => {
     const tmpDir = fs.mkdtempSync(path.join(os.tmpdir(), library.config.name));
-    const pathToSchema = generateSchema(tmpDir, library);
-    generateCode(iosOutputDir, library, tmpDir, pathToSchema);
+    const schema = generateSchema(library);
+    generateCode(iosOutputDir, library, tmpDir, schema);
 
     // Filter the react native core library out.
     // In the future, core library and third party library should
     // use the same way to generate/register the fabric components.
     if (!isReactNativeCoreLibrary(library.config.name)) {
-      schemaPaths[library.config.name] = pathToSchema;
+      schemas[library.config.name] = schema;
     }
   });
+  return schemas;
 }
 
-function createComponentProvider(schemaPaths) {
+function createComponentProvider(schemas) {
   console.log('\n\n>>>>> Creating component provider');
   const outputDir = path.join(
     REACT_NATIVE_PACKAGE_ROOT_FOLDER,
     'React',
     'Fabric',
   );
   mkdirp.sync(outputDir);
-  const schemas = {};
-  for (const libraryName of Object.keys(schemaPaths)) {
-    const tmpSchemaText = fs.readFileSync(schemaPaths[libraryName], 'utf-8');
-    schemas[libraryName] = JSON.parse(tmpSchemaText);
-  }
   utils.getCodegen().generateFromSchemas(
     {
       schemas: schemas,
@@ -413,13 +407,11 @@ function execute(appRootDir, outputPath, baseCodegenConfigFileDir) {
       return;
     }
 
-    const schemaPaths = {};
-
     const iosOutputDir = computeIOSOutputDir(outputPath, appRootDir);
 
-    generateNativeCodegenFiles(libraries, iosOutputDir, schemaPaths);
+    const schemas = generateNativeCodegenFiles(libraries, iosOutputDir);
 
-    createComponentProvider(schemaPaths);
+    createComponentProvider(schemas);
     cleanupEmptyFilesAndFolders(iosOutputDir);
   } catch (err) {
     console.error(err);

packages/react-native/scripts/codegen/generate-specs-cli-executor.js

@@ -70,18 +70,15 @@ function validateLibraryType(libraryType) {
   }
 }
 
-function generateSpec(
+function generateSpecFromInMemorySchema(
   platform,
-  schemaPath,
+  schema,
   outputDirectory,
   libraryName,
   packageName,
   libraryType,
 ) {
   validateLibraryType(libraryType);
-
-  let schema = readAndParseSchema(schemaPath);
-
   createOutputDirectoryIfNeeded(outputDirectory, libraryName);
   function composePath(intermediate) {
     return path.join(outputDirectory, intermediate, libraryName);
@@ -121,6 +118,25 @@ function generateSpec(
   }
 }
 
+function generateSpec(
+  platform,
+  schemaPath,
+  outputDirectory,
+  libraryName,
+  packageName,
+  libraryType,
+) {
+  generateSpecFromInMemorySchema(
+    platform,
+    readAndParseSchema(schemaPath),
+    outputDirectory,
+    libraryName,
+    packageName,
+    libraryType,
+  );
+}
+
 module.exports = {
   execute: generateSpec,
+  generateSpecFromInMemorySchema: generateSpecFromInMemorySchema,
 };