From 103ac29db1f573a78bd5b7753558b9a0691df2b4 Mon Sep 17 00:00:00 2001
From: KroshSputnik <135224011+KroshSputnik@users.noreply.github.com>
Date: Wed, 29 Jan 2025 21:27:12 +1100
Subject: [PATCH 01/12] Added new feature to simplify file size.

I added a new option to enable to show the files in B, MB, GB, TB, PB. Not sure if I need to divide the size by 1024 or 1000. Feedback will be appreciated.
---
 index.js | 26 +++++++++++++++++++++-----
 1 file changed, 21 insertions(+), 5 deletions(-)

diff --git a/index.js b/index.js
index e95390e..e5df122 100644
--- a/index.js
+++ b/index.js
@@ -97,6 +97,7 @@ function serveIndex(root, options) {
   var stylesheet = opts.stylesheet || defaultStylesheet;
   var template = opts.template || defaultTemplate;
   var view = opts.view || 'tiles';
+  var simplifyFileSize = opts.simplifyFileSize;
 
   return function (req, res, next) {
     if (req.method !== 'GET' && req.method !== 'HEAD') {
@@ -164,7 +165,7 @@ function serveIndex(root, options) {
 
         // not acceptable
         if (!type) return next(createError(406));
-        serveIndex[mediaType[type]](req, res, files, next, originalDir, showUp, icons, path, view, template, stylesheet);
+        serveIndex[mediaType[type]](req, res, files, next, originalDir, showUp, icons, path, view, template, stylesheet, simplifyFileSize);
       });
     });
   };
@@ -174,7 +175,7 @@ function serveIndex(root, options) {
  * Respond with text/html.
  */
 
-serveIndex.html = function _html(req, res, files, next, dir, showUp, icons, path, view, template, stylesheet) {
+serveIndex.html = function _html(req, res, files, next, dir, showUp, icons, path, view, template, stylesheet, simplifyFileSize) {
   var render = typeof template !== 'function'
     ? createHtmlRender(template)
     : template
@@ -201,7 +202,8 @@ serveIndex.html = function _html(req, res, files, next, dir, showUp, icons, path
         fileList: fileList,
         path: path,
         style: style,
-        viewName: view
+        viewName: view,
+        simplifyFileSize:Boolean(simplifyFileSize)
       };
 
       // render html
@@ -260,7 +262,7 @@ serveIndex.plain = function _plain (req, res, files, next, dir, showUp, icons, p
  * @private
  */
 
-function createHtmlFileList(files, dir, useIcons, view) {
+function createHtmlFileList(files, dir, useIcons, view, simplifyFileSize) {
   var html = '<ul id="files" class="view-' + escapeHtml(view) + '">'
     + (view === 'details' ? (
       '<li class="header">'
@@ -301,6 +303,20 @@ function createHtmlFileList(files, dir, useIcons, view) {
       ? file.stat.size
       : '';
 
+    if(simplifyFileSize && size !== ''){
+      
+      const fileSizes = ['B', 'KB', 'MB', 'GB', 'TB', 'PB']
+      var index = 0
+      if (size !== 0){
+        index = Math.floor(Math.log(size)/Math.log(1000))
+        if ( index > size.length - 1){
+          index = 5
+        }
+      }
+
+      size = size / Math.pow(1000,index) + ' ' + fileSizes[index]
+    }
+
     return '<li><a href="'
       + escapeHtml(normalizeSlashes(normalize(path.join('/'))))
       + '" class="' + escapeHtml(classes.join(' ')) + '"'
@@ -328,7 +344,7 @@ function createHtmlRender(template) {
 
       var body = str
         .replace(/\{style\}/g, locals.style.concat(iconStyle(locals.fileList, locals.displayIcons)))
-        .replace(/\{files\}/g, createHtmlFileList(locals.fileList, locals.directory, locals.displayIcons, locals.viewName))
+        .replace(/\{files\}/g, createHtmlFileList(locals.fileList, locals.directory, locals.displayIcons, locals.viewName, locals.simplifyFileSize))
         .replace(/\{directory\}/g, escapeHtml(locals.directory))
         .replace(/\{linked-path\}/g, htmlPath(locals.directory));
 

From 5518769c817022122d622991a233487ed1b2a689 Mon Sep 17 00:00:00 2001
From: KroshSputnik <135224011+KroshSputnik@users.noreply.github.com>
Date: Fri, 31 Jan 2025 11:43:02 +1100
Subject: [PATCH 02/12] Update index.js

Fixed the es6 issue of using `const`.
---
 index.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/index.js b/index.js
index e5df122..d1fb3bd 100644
--- a/index.js
+++ b/index.js
@@ -305,7 +305,7 @@ function createHtmlFileList(files, dir, useIcons, view, simplifyFileSize) {
 
     if(simplifyFileSize && size !== ''){
       
-      const fileSizes = ['B', 'KB', 'MB', 'GB', 'TB', 'PB']
+      var fileSizes = ['B', 'KB', 'MB', 'GB', 'TB', 'PB']
       var index = 0
       if (size !== 0){
         index = Math.floor(Math.log(size)/Math.log(1000))

From 50479be7ba3bf2f57df06f673617b909f6670c65 Mon Sep 17 00:00:00 2001
From: KroshSputnik <135224011+KroshSputnik@users.noreply.github.com>
Date: Fri, 31 Jan 2025 14:11:48 +1100
Subject: [PATCH 03/12] Update README.md

Updated readme about the new functionality
---
 README.md | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/README.md b/README.md
index f720b0d..0de3efa 100644
--- a/README.md
+++ b/README.md
@@ -88,6 +88,16 @@ provided locals:
 
 Display mode. `tiles` and `details` are available. Defaults to `tiles`.
 
+##### simplifyFileSize
+
+Configures the unit in the size. Defaults to `false`.
+
+By default, the size is display only in bytes. 
+
+Set it to `true` and it will automatically simplify the size to the highest size 
+from the following 
+- KB, MB, GB, TB PB
+
 ## Examples
 
 ### Serve directory indexes with vanilla node.js http server

From 295d9b856a8426d69dccd50ad451825823501c0b Mon Sep 17 00:00:00 2001
From: KroshSputnik <135224011+KroshSputnik@users.noreply.github.com>
Date: Sat, 1 Feb 2025 23:25:28 +1100
Subject: [PATCH 04/12] Created tests for new feature

Created tests for the new `simplifyFileSize` option.
---
 test/fixtures/collect/sample | 99 ++++++++++++++++++++++++++++++++++++
 test/test.js                 | 19 +++++++
 2 files changed, 118 insertions(+)

diff --git a/test/fixtures/collect/sample b/test/fixtures/collect/sample
index e69de29..7d35be4 100644
--- a/test/fixtures/collect/sample
+++ b/test/fixtures/collect/sample
@@ -0,0 +1,99 @@
+1234567890
+1234567890
+1234567890
+1234567890
+1234567890
+1234567890
+1234567890
+1234567890
+1234567890
+1234567890
+1234567890
+1234567890
+1234567890
+1234567890
+1234567890
+1234567890
+1234567890
+1234567890
+1234567890
+1234567890
+1234567890
+1234567890
+1234567890
+1234567890
+1234567890
+1234567890
+1234567890
+1234567890
+1234567890
+1234567890
+1234567890
+1234567890
+1234567890
+1234567890
+1234567890
+1234567890
+1234567890
+1234567890
+1234567890
+1234567890
+1234567890
+1234567890
+1234567890
+1234567890
+1234567890
+1234567890
+1234567890
+1234567890
+1234567890
+1234567890
+1234567890
+1234567890
+1234567890
+1234567890
+1234567890
+1234567890
+1234567890
+1234567890
+1234567890
+1234567890
+1234567890
+1234567890
+1234567890
+1234567890
+1234567890
+1234567890
+1234567890
+1234567890
+1234567890
+1234567890
+1234567890
+1234567890
+1234567890
+1234567890
+1234567890
+1234567890
+1234567890
+1234567890
+1234567890
+1234567890
+1234567890
+1234567890
+1234567890
+1234567890
+1234567890
+1234567890
+1234567890
+1234567890
+1234567890
+1234567890
+1234567890
+1234567890
+1234567890
+1234567890
+1234567890
+1234567890
+1234567890
+1234567890
+1234567890
\ No newline at end of file
diff --git a/test/test.js b/test/test.js
index c1509a4..bf4acfb 100644
--- a/test/test.js
+++ b/test/test.js
@@ -395,6 +395,25 @@ describe('serveIndex(root)', function () {
     });
   });
 
+  describe('with "simplifyFileSize" option', function () {
+    it('should simplify file sizes', function (done) {
+      var server = createServer(fixtures, {'simplifyFileSize': true})
+
+      request(server)
+        .get('/collect')
+        .expect(/1\.186 KB/)
+        .expect(200, done)
+    });
+    it('should not simplify file sizes', function (done) {
+      var server = createServer(fixtures, {'simplifyFileSize': false})
+
+      request(server)
+        .get('/collect')
+        .expect(/1186/)
+        .expect(200, done)
+    });
+  });
+
   describe('with "template" option', function () {
     describe('when setting a custom template file', function () {
       var server;

From e05ba52f4527ebc201f8dcfa3b060b59ec0a7035 Mon Sep 17 00:00:00 2001
From: KroshSputnik <135224011+KroshSputnik@users.noreply.github.com>
Date: Sun, 2 Feb 2025 09:31:56 +1100
Subject: [PATCH 05/12] Updated the logic of simplifyFileSize.

Now using the package bytes, to convert.
---
 index.js     | 13 ++-----------
 package.json |  3 ++-
 test/test.js |  2 +-
 3 files changed, 5 insertions(+), 13 deletions(-)

diff --git a/index.js b/index.js
index d1fb3bd..d5285da 100644
--- a/index.js
+++ b/index.js
@@ -27,6 +27,7 @@ var Batch = require('batch');
 var mime = require('mime-types');
 var parseUrl = require('parseurl');
 var resolve = require('path').resolve;
+var bytes = require('bytes');
 
 /**
  * Module exports.
@@ -304,17 +305,7 @@ function createHtmlFileList(files, dir, useIcons, view, simplifyFileSize) {
       : '';
 
     if(simplifyFileSize && size !== ''){
-      
-      var fileSizes = ['B', 'KB', 'MB', 'GB', 'TB', 'PB']
-      var index = 0
-      if (size !== 0){
-        index = Math.floor(Math.log(size)/Math.log(1000))
-        if ( index > size.length - 1){
-          index = 5
-        }
-      }
-
-      size = size / Math.pow(1000,index) + ' ' + fileSizes[index]
+      size = bytes(size, {unitSeparator: ' '})
     }
 
     return '<li><a href="'
diff --git a/package.json b/package.json
index c7f520e..cc1bd89 100644
--- a/package.json
+++ b/package.json
@@ -8,6 +8,7 @@
   "dependencies": {
     "accepts": "~1.3.7",
     "batch": "0.6.1",
+    "bytes": "^3.1.2",
     "debug": "2.6.9",
     "escape-html": "~1.0.3",
     "http-errors": "~1.8.0",
@@ -37,4 +38,4 @@
     "test-ci": "nyc --reporter=lcov --reporter=text npm test",
     "test-cov": "nyc --reporter=html --reporter=text npm test"
   }
-}
\ No newline at end of file
+}
diff --git a/test/test.js b/test/test.js
index bf4acfb..51889d0 100644
--- a/test/test.js
+++ b/test/test.js
@@ -401,7 +401,7 @@ describe('serveIndex(root)', function () {
 
       request(server)
         .get('/collect')
-        .expect(/1\.186 KB/)
+        .expect(/1\.16 KB/)
         .expect(200, done)
     });
     it('should not simplify file sizes', function (done) {

From 2310bba0006e0466e77b58d1e8cc51405f7fa62c Mon Sep 17 00:00:00 2001
From: KroshSputnik <135224011+KroshSputnik@users.noreply.github.com>
Date: Sun, 2 Feb 2025 09:43:36 +1100
Subject: [PATCH 06/12] Update README.md

Added the decimal places.
---
 README.md | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/README.md b/README.md
index 0de3efa..9b0a266 100644
--- a/README.md
+++ b/README.md
@@ -94,9 +94,9 @@ Configures the unit in the size. Defaults to `false`.
 
 By default, the size is display only in bytes. 
 
-Set it to `true` and it will automatically simplify the size to the highest size 
-from the following 
-- KB, MB, GB, TB PB
+Set it to `true` and it will try to automatically simplify the size to 
+the highest possible unit from the following to two decimal places.
+- KB, MB, GB, TB, PB
 
 ## Examples
 

From d051690328f1617be5de51d1bcd9b0e46a8a0889 Mon Sep 17 00:00:00 2001
From: KroshSputnik <135224011+KroshSputnik@users.noreply.github.com>
Date: Sun, 2 Feb 2025 21:22:46 +1100
Subject: [PATCH 07/12] Update package.json
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Supporting Node@0.8 versions.

Co-authored-by: Ulises Gascón <ulisesgascongonzalez@gmail.com>
---
 package.json | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/package.json b/package.json
index cc1bd89..9705d89 100644
--- a/package.json
+++ b/package.json
@@ -8,7 +8,7 @@
   "dependencies": {
     "accepts": "~1.3.7",
     "batch": "0.6.1",
-    "bytes": "^3.1.2",
+    "bytes": "~3.1.2",
     "debug": "2.6.9",
     "escape-html": "~1.0.3",
     "http-errors": "~1.8.0",

From 8b864afa2f41c6ca57afa54df4749b8afb2b724d Mon Sep 17 00:00:00 2001
From: KroshSputnik <135224011+KroshSputnik@users.noreply.github.com>
Date: Sun, 2 Feb 2025 21:23:32 +1100
Subject: [PATCH 08/12] Update test/test.js
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Added another check for default config.

Co-authored-by: Ulises Gascón <ulisesgascongonzalez@gmail.com>
---
 test/test.js | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/test/test.js b/test/test.js
index 51889d0..0c84312 100644
--- a/test/test.js
+++ b/test/test.js
@@ -407,6 +407,14 @@ describe('serveIndex(root)', function () {
     it('should not simplify file sizes', function (done) {
       var server = createServer(fixtures, {'simplifyFileSize': false})
 
+      request(server)
+        .get('/collect')
+        .expect(/1186/)
+        .expect(200, done)
+    });
+    it('should not simplify file sizes by default', function (done) {
+      var server = createServer(fixtures)
+
       request(server)
         .get('/collect')
         .expect(/1186/)

From d033721b0d727efd95d109ea085e34f61abdffc8 Mon Sep 17 00:00:00 2001
From: KroshSputnik <135224011+KroshSputnik@users.noreply.github.com>
Date: Sun, 2 Feb 2025 21:32:07 +1100
Subject: [PATCH 09/12] Update HISTORY.md

History about new simplifyFileSize feature and dependency of bytes.
---
 HISTORY.md | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/HISTORY.md b/HISTORY.md
index 3f5c295..5f876ef 100644
--- a/HISTORY.md
+++ b/HISTORY.md
@@ -1,6 +1,7 @@
 unreleased
 ==========
-
+  * Added `simplifyFileSize` option
+  * deps: bytes": "~3.1.2
   * Fix icons for MIME types with `+`
   * Fix text and json responses to match html sorting
   * Show font icon for more font types

From 9827cff49c04c9fdf08983553c052e9efd8d07fd Mon Sep 17 00:00:00 2001
From: KroshSputnik <135224011+KroshSputnik@users.noreply.github.com>
Date: Sun, 2 Feb 2025 21:34:44 +1100
Subject: [PATCH 10/12] Fixed characters in history

---
 HISTORY.md | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/HISTORY.md b/HISTORY.md
index 5f876ef..106a36c 100644
--- a/HISTORY.md
+++ b/HISTORY.md
@@ -1,7 +1,7 @@
 unreleased
 ==========
   * Added `simplifyFileSize` option
-  * deps: bytes": "~3.1.2
+  * deps: bytes@~3.1.2
   * Fix icons for MIME types with `+`
   * Fix text and json responses to match html sorting
   * Show font icon for more font types

From a84754fcaf0adc7bdee0410849861074750acedb Mon Sep 17 00:00:00 2001
From: KroshSputnik <135224011+KroshSputnik@users.noreply.github.com>
Date: Mon, 3 Feb 2025 23:05:48 +1100
Subject: [PATCH 11/12] Update test.js

---
 test/test.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/test/test.js b/test/test.js
index 0c84312..c5d81ed 100644
--- a/test/test.js
+++ b/test/test.js
@@ -401,7 +401,7 @@ describe('serveIndex(root)', function () {
 
       request(server)
         .get('/collect')
-        .expect(/1\.16 KB/)
+        .expect(/1\.06 KB/)
         .expect(200, done)
     });
     it('should not simplify file sizes', function (done) {

From f60cfc54e5f477dec4cdea55dd73006a2039fc43 Mon Sep 17 00:00:00 2001
From: KroshSputnik <135224011+KroshSputnik@users.noreply.github.com>
Date: Mon, 3 Feb 2025 23:21:42 +1100
Subject: [PATCH 12/12] Testing

---
 test/fixtures/collect/sample | 100 +----------------------------------
 test/test.js                 |   6 +--
 2 files changed, 4 insertions(+), 102 deletions(-)

diff --git a/test/fixtures/collect/sample b/test/fixtures/collect/sample
index 7d35be4..30106d4 100644
--- a/test/fixtures/collect/sample
+++ b/test/fixtures/collect/sample
@@ -1,99 +1 @@
-1234567890
-1234567890
-1234567890
-1234567890
-1234567890
-1234567890
-1234567890
-1234567890
-1234567890
-1234567890
-1234567890
-1234567890
-1234567890
-1234567890
-1234567890
-1234567890
-1234567890
-1234567890
-1234567890
-1234567890
-1234567890
-1234567890
-1234567890
-1234567890
-1234567890
-1234567890
-1234567890
-1234567890
-1234567890
-1234567890
-1234567890
-1234567890
-1234567890
-1234567890
-1234567890
-1234567890
-1234567890
-1234567890
-1234567890
-1234567890
-1234567890
-1234567890
-1234567890
-1234567890
-1234567890
-1234567890
-1234567890
-1234567890
-1234567890
-1234567890
-1234567890
-1234567890
-1234567890
-1234567890
-1234567890
-1234567890
-1234567890
-1234567890
-1234567890
-1234567890
-1234567890
-1234567890
-1234567890
-1234567890
-1234567890
-1234567890
-1234567890
-1234567890
-1234567890
-1234567890
-1234567890
-1234567890
-1234567890
-1234567890
-1234567890
-1234567890
-1234567890
-1234567890
-1234567890
-1234567890
-1234567890
-1234567890
-1234567890
-1234567890
-1234567890
-1234567890
-1234567890
-1234567890
-1234567890
-1234567890
-1234567890
-1234567890
-1234567890
-1234567890
-1234567890
-1234567890
-1234567890
-1234567890
-1234567890
\ No newline at end of file
+12345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890
\ No newline at end of file
diff --git a/test/test.js b/test/test.js
index c5d81ed..4b267a5 100644
--- a/test/test.js
+++ b/test/test.js
@@ -401,7 +401,7 @@ describe('serveIndex(root)', function () {
 
       request(server)
         .get('/collect')
-        .expect(/1\.06 KB/)
+        .expect(/1\.07 KB/)
         .expect(200, done)
     });
     it('should not simplify file sizes', function (done) {
@@ -409,7 +409,7 @@ describe('serveIndex(root)', function () {
 
       request(server)
         .get('/collect')
-        .expect(/1186/)
+        .expect(/1100/)
         .expect(200, done)
     });
     it('should not simplify file sizes by default', function (done) {
@@ -417,7 +417,7 @@ describe('serveIndex(root)', function () {
 
       request(server)
         .get('/collect')
-        .expect(/1186/)
+        .expect(/1100/)
         .expect(200, done)
     });
   });