add events to EulerSwapProtocolFeeConfig on admin actions

Spearbit #6

Author: hoytech

src/EulerSwapProtocolFeeConfig.sol

@@ -32,7 +32,18 @@ contract EulerSwapProtocolFeeConfig is IEulerSwapProtocolFeeConfig, EVCUtil {
     error InvalidProtocolFee();
     error InvalidProtocolFeeRecipient();
 
+    /// @notice Emitted when admin is set/changed
+    event AdminUpdated(address indexed oldAdmin, address indexed newAdmin);
+    /// @notice Emitted when the default configuration is changed
+    event DefaultUpdated(address indexed oldRecipient, address indexed newRecipient, uint64 oldFee, uint64 newFee);
+    /// @notice Emitted when a per-pool override is created or changed
+    event OverrideSet(address indexed pool, address indexed recipient, uint64 fee);
+    /// @notice Emitted when a per-pool override is removed (and thus falls back to the default)
+    event OverrideRemoved(address indexed pool);
+
     constructor(address evc, address admin_) EVCUtil(evc) {
+        emit AdminUpdated(address(0), admin_);
+
         admin = admin_;
     }
 
@@ -47,6 +58,8 @@ contract EulerSwapProtocolFeeConfig is IEulerSwapProtocolFeeConfig, EVCUtil {
 
     /// @inheritdoc IEulerSwapProtocolFeeConfig
     function setAdmin(address newAdmin) external onlyAdmin {
+        emit AdminUpdated(admin, newAdmin);
+
         admin = newAdmin;
     }
 
@@ -55,6 +68,8 @@ contract EulerSwapProtocolFeeConfig is IEulerSwapProtocolFeeConfig, EVCUtil {
         require(fee <= MAX_PROTOCOL_FEE, InvalidProtocolFee());
         require(fee == 0 || recipient != address(0), InvalidProtocolFeeRecipient());
 
+        emit DefaultUpdated(defaultRecipient, recipient, defaultFee, fee);
+
         defaultRecipient = recipient;
         defaultFee = fee;
     }
@@ -63,11 +78,15 @@ contract EulerSwapProtocolFeeConfig is IEulerSwapProtocolFeeConfig, EVCUtil {
     function setOverride(address pool, address recipient, uint64 fee) external onlyAdmin {
         require(fee <= MAX_PROTOCOL_FEE, InvalidProtocolFee());
 
+        emit OverrideSet(pool, recipient, fee);
+
         overrides[pool] = Override({exists: true, recipient: recipient, fee: fee});
     }
 
     /// @inheritdoc IEulerSwapProtocolFeeConfig
     function removeOverride(address pool) external onlyAdmin {
+        emit OverrideRemoved(pool);
+
         delete overrides[pool];
     }
 

test/Fees.t.sol

@@ -238,6 +238,8 @@ contract FeesTest is EulerSwapTestBase {
 
         // Override
 
+        vm.expectEmit(true, true, true, true);
+        emit EulerSwapProtocolFeeConfig.OverrideSet(address(eulerSwap), address(9999), 0.07e18);
         vm.prank(protocolFeeAdmin);
         protocolFeeConfig.setOverride(address(eulerSwap), address(9999), 0.07e18);
 
@@ -271,6 +273,8 @@ contract FeesTest is EulerSwapTestBase {
 
         // Remove override
 
+        vm.expectEmit(true, true, true, true);
+        emit EulerSwapProtocolFeeConfig.OverrideRemoved(address(eulerSwap));
         vm.prank(protocolFeeAdmin);
         protocolFeeConfig.removeOverride(address(eulerSwap));
 
@@ -293,17 +297,28 @@ contract FeesTest is EulerSwapTestBase {
     }
 
     function test_fees_protocolFees_setAdmin() public {
-        assertEq(protocolFeeConfig.admin(), protocolFeeAdmin);
+        address origAdmin = protocolFeeConfig.admin();
+        assertEq(origAdmin, protocolFeeAdmin);
 
         vm.expectRevert(EulerSwapProtocolFeeConfig.Unauthorized.selector);
         protocolFeeConfig.setDefault(address(8888), 0.1e18);
 
+        vm.expectEmit(true, true, true, true);
+        emit EulerSwapProtocolFeeConfig.AdminUpdated(origAdmin, address(this));
         vm.prank(protocolFeeAdmin);
         protocolFeeConfig.setAdmin(address(this));
 
         assertEq(protocolFeeConfig.admin(), address(this));
+    }
 
-        protocolFeeConfig.setDefault(address(8888), 0.1e18);
+    function test_fees_protocolFees_defaults() public {
+        address origFefaultRecipient = protocolFeeConfig.defaultRecipient();
+        uint64 origDefaultFee = protocolFeeConfig.defaultFee();
+
+        vm.expectEmit(true, true, true, true);
+        emit EulerSwapProtocolFeeConfig.DefaultUpdated(origFefaultRecipient, address(7654), origDefaultFee, 0.071e18);
+        vm.prank(protocolFeeAdmin);
+        protocolFeeConfig.setDefault(address(7654), 0.071e18);
     }
 
     function test_fuzzFeeRounding(uint256 amount, uint256 fee) public pure {