Skip to content

Commit 9e57364

Browse files
committed
ci: revert accidental max_args_count/_bytes member additions
My earlier 2e803ed (fd_set/socklen_t CI fix) accidentally swept in two const std::size_t members (max_args_count, max_args_bytes) that were sitting uncommitted in the working tree as part of an unrelated in-progress feature. The matching create_webserver setters / private fields were not in HEAD, so the constructor's params._max_args_count referenced a nonexistent member. Walk back the const-member additions in both webserver.hpp and the constructor init in webserver.cpp so HEAD is internally consistent and the CI fix in 2e803ed (fd_set include + dropped socklen_t signedness assert) stands alone. The full max_args feature stays in the working tree where it was, to be committed as one coherent unit later.
1 parent d32dfe3 commit 9e57364

2 files changed

Lines changed: 0 additions & 9 deletions

File tree

src/httpserver/webserver.hpp

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -411,13 +411,6 @@ class webserver {
411411
const struct sockaddr* bind_address;
412412
std::shared_ptr<struct sockaddr_storage> bind_address_storage;
413413
const int max_thread_stack_size;
414-
// 0 sentinel -> compile-time defaults
415-
// (arguments_accumulator::DEFAULT_MAX_ARGS_COUNT / _BYTES).
416-
// webserver_impl::connection_notify copies these into the per-
417-
// connection_state at MHD_CONNECTION_NOTIFY_STARTED; populate_args
418-
// reads them from connection_state via the socket_context.
419-
const std::size_t max_args_count;
420-
const std::size_t max_args_bytes;
421414
const bool use_ssl;
422415
const bool use_ipv6;
423416
const bool use_dual_stack;

src/webserver.cpp

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -200,8 +200,6 @@ webserver::webserver(const create_webserver& params):
200200
bind_address(params._bind_address),
201201
bind_address_storage(params._bind_address_storage),
202202
max_thread_stack_size(params._max_thread_stack_size),
203-
max_args_count(params._max_args_count),
204-
max_args_bytes(params._max_args_bytes),
205203
use_ssl(params._use_ssl),
206204
use_ipv6(params._use_ipv6),
207205
use_dual_stack(params._use_dual_stack),

0 commit comments

Comments
 (0)