From c31b2789eb387090bd49fb664700c1f872e41daf Mon Sep 17 00:00:00 2001 From: satria agan Date: Wed, 12 Nov 2025 21:10:36 +0700 Subject: [PATCH 1/9] Add personal contribution note by Tinu280 Added a personal contribution note to the README. --- README.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/README.md b/README.md index 639286ba9f36..e0f720a255c9 100644 --- a/README.md +++ b/README.md @@ -254,3 +254,5 @@ also included in our repository in the `COPYING.LESSER` file. The go-ethereum binaries (i.e. all code inside of the `cmd` directory) are licensed under the [GNU General Public License v3.0](https://www.gnu.org/licenses/gpl-3.0.en.html), also included in our repository in the `COPYING` file. + +My first contribution test by Tinu280 From 7285021460adf99c7d8079b4ea6d2db64bc93cc6 Mon Sep 17 00:00:00 2001 From: satria agan Date: Thu, 13 Nov 2025 14:42:28 +0700 Subject: [PATCH 2/9] Update README.md --- README.md | 2 -- 1 file changed, 2 deletions(-) diff --git a/README.md b/README.md index e0f720a255c9..639286ba9f36 100644 --- a/README.md +++ b/README.md @@ -254,5 +254,3 @@ also included in our repository in the `COPYING.LESSER` file. The go-ethereum binaries (i.e. all code inside of the `cmd` directory) are licensed under the [GNU General Public License v3.0](https://www.gnu.org/licenses/gpl-3.0.en.html), also included in our repository in the `COPYING` file. - -My first contribution test by Tinu280 From 2b5a92c8965bb2cdefe22abd72dfc01781fd3eba Mon Sep 17 00:00:00 2001 From: Tinu280 Date: Thu, 13 Nov 2025 17:22:38 +0700 Subject: [PATCH 3/9] ethclient: improve doc comment style --- ethclient/ethclient.go | 30 ++++++++++++++++++------------ 1 file changed, 18 insertions(+), 12 deletions(-) diff --git a/ethclient/ethclient.go b/ethclient/ethclient.go index 5008378da6a6..0104023d70f8 100644 --- a/ethclient/ethclient.go +++ b/ethclient/ethclient.go @@ -42,28 +42,34 @@ func Dial(rawurl string) (*Client, error) { return DialContext(context.Background(), rawurl) } -// DialContext connects a client to the given URL with context. +// Dial creates a new RPC client and connects to the given URL endpoint. +func Dial(rawurl string) (*Client, error) { + return DialContext(context.Background(), rawurl) +} + +// DialContext creates a new RPC client using the provided context +// and connects it to the specified URL endpoint. func DialContext(ctx context.Context, rawurl string) (*Client, error) { - c, err := rpc.DialContext(ctx, rawurl) - if err != nil { - return nil, err - } - return NewClient(c), nil + c, err := rpc.DialContext(ctx, rawurl) + if err != nil { + return nil, err + } + return NewClient(c), nil } -// NewClient creates a client that uses the given RPC client. +// NewClient creates a Client instance that wraps the provided RPC client. func NewClient(c *rpc.Client) *Client { - return &Client{c} + return &Client{c} } -// Close closes the underlying RPC connection. +// Close terminates the underlying RPC connection. func (ec *Client) Close() { - ec.c.Close() + ec.c.Close() } -// Client gets the underlying RPC client. +// Client returns the underlying RPC client instance. func (ec *Client) Client() *rpc.Client { - return ec.c + return ec.c } // Blockchain Access From 0ff4d9f456f034472ee1a513cf560ae4d9d1f00b Mon Sep 17 00:00:00 2001 From: Tinu280 Date: Thu, 13 Nov 2025 23:08:15 +0700 Subject: [PATCH 4/9] ethclient: improve doc comment style --- ethclient/ethclient.go | 19 +++++-------------- 1 file changed, 5 insertions(+), 14 deletions(-) diff --git a/ethclient/ethclient.go b/ethclient/ethclient.go index 0104023d70f8..724d89f44bb2 100644 --- a/ethclient/ethclient.go +++ b/ethclient/ethclient.go @@ -37,39 +37,30 @@ type Client struct { c *rpc.Client } -// Dial connects a client to the given URL. -func Dial(rawurl string) (*Client, error) { - return DialContext(context.Background(), rawurl) -} - // Dial creates a new RPC client and connects to the given URL endpoint. func Dial(rawurl string) (*Client, error) { - return DialContext(context.Background(), rawurl) + return DialContext(context.Background(), rawurl) } // DialContext creates a new RPC client using the provided context // and connects it to the specified URL endpoint. func DialContext(ctx context.Context, rawurl string) (*Client, error) { - c, err := rpc.DialContext(ctx, rawurl) - if err != nil { - return nil, err - } - return NewClient(c), nil + ... } // NewClient creates a Client instance that wraps the provided RPC client. func NewClient(c *rpc.Client) *Client { - return &Client{c} + return &Client{c} } // Close terminates the underlying RPC connection. func (ec *Client) Close() { - ec.c.Close() + ec.c.Close() } // Client returns the underlying RPC client instance. func (ec *Client) Client() *rpc.Client { - return ec.c + return ec.c } // Blockchain Access From 1a0f7f52dbac3d59cf2cfe6c8112e5f709a99a33 Mon Sep 17 00:00:00 2001 From: Tinu280 Date: Thu, 13 Nov 2025 23:27:59 +0700 Subject: [PATCH 5/9] ethclient: fix syntax error in comments --- ethclient/ethclient.go | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/ethclient/ethclient.go b/ethclient/ethclient.go index 724d89f44bb2..7ac7d7e22cb9 100644 --- a/ethclient/ethclient.go +++ b/ethclient/ethclient.go @@ -45,7 +45,11 @@ func Dial(rawurl string) (*Client, error) { // DialContext creates a new RPC client using the provided context // and connects it to the specified URL endpoint. func DialContext(ctx context.Context, rawurl string) (*Client, error) { - ... + c, err := rpc.DialContext(ctx, rawurl) + if err != nil { + return nil, err + } + return NewClient(c), nil } // NewClient creates a Client instance that wraps the provided RPC client. From e33df6da627e6a09058d06d07f722ee91335c26a Mon Sep 17 00:00:00 2001 From: Tinu280 Date: Thu, 13 Nov 2025 23:37:30 +0700 Subject: [PATCH 6/9] ethclient: format file and improve documentation comments --- ethclient/ethclient.go | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/ethclient/ethclient.go b/ethclient/ethclient.go index 7ac7d7e22cb9..9fe2efd54bd4 100644 --- a/ethclient/ethclient.go +++ b/ethclient/ethclient.go @@ -39,32 +39,32 @@ type Client struct { // Dial creates a new RPC client and connects to the given URL endpoint. func Dial(rawurl string) (*Client, error) { - return DialContext(context.Background(), rawurl) + return DialContext(context.Background(), rawurl) } // DialContext creates a new RPC client using the provided context // and connects it to the specified URL endpoint. func DialContext(ctx context.Context, rawurl string) (*Client, error) { - c, err := rpc.DialContext(ctx, rawurl) - if err != nil { - return nil, err - } - return NewClient(c), nil + c, err := rpc.DialContext(ctx, rawurl) + if err != nil { + return nil, err + } + return NewClient(c), nil } // NewClient creates a Client instance that wraps the provided RPC client. func NewClient(c *rpc.Client) *Client { - return &Client{c} + return &Client{c} } // Close terminates the underlying RPC connection. func (ec *Client) Close() { - ec.c.Close() + ec.c.Close() } // Client returns the underlying RPC client instance. func (ec *Client) Client() *rpc.Client { - return ec.c + return ec.c } // Blockchain Access From f12755f6e36f684201c39b1b601c4bdb1a2b4433 Mon Sep 17 00:00:00 2001 From: Tinu280 Date: Sun, 16 Nov 2025 00:26:16 +0700 Subject: [PATCH 7/9] docs: small documentation improvement --- README.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/README.md b/README.md index 639286ba9f36..c3421ed22ce5 100644 --- a/README.md +++ b/README.md @@ -254,3 +254,5 @@ also included in our repository in the `COPYING.LESSER` file. The go-ethereum binaries (i.e. all code inside of the `cmd` directory) are licensed under the [GNU General Public License v3.0](https://www.gnu.org/licenses/gpl-3.0.en.html), also included in our repository in the `COPYING` file. + +Small documentation improvement for contribution testing. From 0308236cbf254a120e7338daa9225d121a80c640 Mon Sep 17 00:00:00 2001 From: Tinu280 Date: Sun, 16 Nov 2025 01:54:52 +0700 Subject: [PATCH 8/9] docs: trigger CI rerun --- ethclient/ethclient.go | 1 + 1 file changed, 1 insertion(+) diff --git a/ethclient/ethclient.go b/ethclient/ethclient.go index 9fe2efd54bd4..c1e6a734b40c 100644 --- a/ethclient/ethclient.go +++ b/ethclient/ethclient.go @@ -949,3 +949,4 @@ func (ec *Client) SimulateV1(ctx context.Context, opts SimulateOptions, blockNrO err := ec.c.CallContext(ctx, &result, "eth_simulateV1", opts, blockNrOrHash) return result, err } + From cd961c1f5c38e7bbc206846cb28c02de1c30dc88 Mon Sep 17 00:00:00 2001 From: Tinu280 Date: Sun, 16 Nov 2025 02:03:25 +0700 Subject: [PATCH 9/9] ethclient: fix formatting to satisfy goimports --- accounts/usbwallet/trezor/messages-common.pb.go | 5 +++-- accounts/usbwallet/trezor/messages-ethereum.pb.go | 5 +++-- accounts/usbwallet/trezor/messages-management.pb.go | 5 +++-- accounts/usbwallet/trezor/messages.pb.go | 5 +++-- build/ci.go | 2 +- core/types/bal/bal_encoding_rlp_generated.go | 7 +++++-- core/types/gen_account_rlp.go | 7 +++++-- core/types/gen_header_rlp.go | 7 +++++-- core/types/gen_log_rlp.go | 7 +++++-- core/types/gen_withdrawal_rlp.go | 7 +++++-- ethclient/ethclient.go | 1 - 11 files changed, 38 insertions(+), 20 deletions(-) diff --git a/accounts/usbwallet/trezor/messages-common.pb.go b/accounts/usbwallet/trezor/messages-common.pb.go index 73800802bb30..79b1b78126f0 100644 --- a/accounts/usbwallet/trezor/messages-common.pb.go +++ b/accounts/usbwallet/trezor/messages-common.pb.go @@ -11,10 +11,11 @@ package trezor import ( - protoreflect "google.golang.org/protobuf/reflect/protoreflect" - protoimpl "google.golang.org/protobuf/runtime/protoimpl" reflect "reflect" sync "sync" + + protoreflect "google.golang.org/protobuf/reflect/protoreflect" + protoimpl "google.golang.org/protobuf/runtime/protoimpl" ) const ( diff --git a/accounts/usbwallet/trezor/messages-ethereum.pb.go b/accounts/usbwallet/trezor/messages-ethereum.pb.go index a92123efcdda..0c2f3a857290 100644 --- a/accounts/usbwallet/trezor/messages-ethereum.pb.go +++ b/accounts/usbwallet/trezor/messages-ethereum.pb.go @@ -11,10 +11,11 @@ package trezor import ( - protoreflect "google.golang.org/protobuf/reflect/protoreflect" - protoimpl "google.golang.org/protobuf/runtime/protoimpl" reflect "reflect" sync "sync" + + protoreflect "google.golang.org/protobuf/reflect/protoreflect" + protoimpl "google.golang.org/protobuf/runtime/protoimpl" ) const ( diff --git a/accounts/usbwallet/trezor/messages-management.pb.go b/accounts/usbwallet/trezor/messages-management.pb.go index 983e2d281df3..906f516c960f 100644 --- a/accounts/usbwallet/trezor/messages-management.pb.go +++ b/accounts/usbwallet/trezor/messages-management.pb.go @@ -11,10 +11,11 @@ package trezor import ( - protoreflect "google.golang.org/protobuf/reflect/protoreflect" - protoimpl "google.golang.org/protobuf/runtime/protoimpl" reflect "reflect" sync "sync" + + protoreflect "google.golang.org/protobuf/reflect/protoreflect" + protoimpl "google.golang.org/protobuf/runtime/protoimpl" ) const ( diff --git a/accounts/usbwallet/trezor/messages.pb.go b/accounts/usbwallet/trezor/messages.pb.go index 4518db679e93..5c922e1a0bb5 100644 --- a/accounts/usbwallet/trezor/messages.pb.go +++ b/accounts/usbwallet/trezor/messages.pb.go @@ -11,11 +11,12 @@ package trezor import ( + reflect "reflect" + sync "sync" + protoreflect "google.golang.org/protobuf/reflect/protoreflect" protoimpl "google.golang.org/protobuf/runtime/protoimpl" descriptorpb "google.golang.org/protobuf/types/descriptorpb" - reflect "reflect" - sync "sync" ) const ( diff --git a/build/ci.go b/build/ci.go index e589cd2b405c..50d78f45ca18 100644 --- a/build/ci.go +++ b/build/ci.go @@ -343,7 +343,7 @@ func buildFlags(env build.Environment, staticLinking bool, buildTags []string) ( } ld = append(ld, "-extldflags", "'"+strings.Join(extld, " ")+"'") } - // TODO(gballet): revisit after the input api has been defined + // TODO(gballet): revisit after the input api has been defined if runtime.GOARCH == "wasm" { ld = append(ld, "-gcflags=all=-d=softfloat") } diff --git a/core/types/bal/bal_encoding_rlp_generated.go b/core/types/bal/bal_encoding_rlp_generated.go index 0d5239532904..037d04f46b4a 100644 --- a/core/types/bal/bal_encoding_rlp_generated.go +++ b/core/types/bal/bal_encoding_rlp_generated.go @@ -2,8 +2,11 @@ package bal -import "github.com/ethereum/go-ethereum/rlp" -import "io" +import ( + "io" + + "github.com/ethereum/go-ethereum/rlp" +) func (obj *BlockAccessList) EncodeRLP(_w io.Writer) error { w := rlp.NewEncoderBuffer(_w) diff --git a/core/types/gen_account_rlp.go b/core/types/gen_account_rlp.go index 8b424493afb8..3d2f67ab0f39 100644 --- a/core/types/gen_account_rlp.go +++ b/core/types/gen_account_rlp.go @@ -2,8 +2,11 @@ package types -import "github.com/ethereum/go-ethereum/rlp" -import "io" +import ( + "io" + + "github.com/ethereum/go-ethereum/rlp" +) func (obj *StateAccount) EncodeRLP(_w io.Writer) error { w := rlp.NewEncoderBuffer(_w) diff --git a/core/types/gen_header_rlp.go b/core/types/gen_header_rlp.go index c79aa8a25023..6dc348139366 100644 --- a/core/types/gen_header_rlp.go +++ b/core/types/gen_header_rlp.go @@ -2,8 +2,11 @@ package types -import "github.com/ethereum/go-ethereum/rlp" -import "io" +import ( + "io" + + "github.com/ethereum/go-ethereum/rlp" +) func (obj *Header) EncodeRLP(_w io.Writer) error { w := rlp.NewEncoderBuffer(_w) diff --git a/core/types/gen_log_rlp.go b/core/types/gen_log_rlp.go index 7e8962966842..89f2083d4b15 100644 --- a/core/types/gen_log_rlp.go +++ b/core/types/gen_log_rlp.go @@ -2,8 +2,11 @@ package types -import "github.com/ethereum/go-ethereum/rlp" -import "io" +import ( + "io" + + "github.com/ethereum/go-ethereum/rlp" +) func (obj *Log) EncodeRLP(_w io.Writer) error { w := rlp.NewEncoderBuffer(_w) diff --git a/core/types/gen_withdrawal_rlp.go b/core/types/gen_withdrawal_rlp.go index 6a97c04c8153..7d8b9bad06cb 100644 --- a/core/types/gen_withdrawal_rlp.go +++ b/core/types/gen_withdrawal_rlp.go @@ -2,8 +2,11 @@ package types -import "github.com/ethereum/go-ethereum/rlp" -import "io" +import ( + "io" + + "github.com/ethereum/go-ethereum/rlp" +) func (obj *Withdrawal) EncodeRLP(_w io.Writer) error { w := rlp.NewEncoderBuffer(_w) diff --git a/ethclient/ethclient.go b/ethclient/ethclient.go index c1e6a734b40c..9fe2efd54bd4 100644 --- a/ethclient/ethclient.go +++ b/ethclient/ethclient.go @@ -949,4 +949,3 @@ func (ec *Client) SimulateV1(ctx context.Context, opts SimulateOptions, blockNrO err := ec.c.CallContext(ctx, &result, "eth_simulateV1", opts, blockNrOrHash) return result, err } -