Add 1 favorite locally when you favorite an app #81
+8
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added session tracking for favorited apps and removed unused function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When you favorite an app, the text inside the icon adds one favorite immediately, that is local and will not get pushed to the database. What this PR does is gives the illusion that the website is updating the favorites immediately, adding another layer of feedback that the user has favorited an app. This has been tested, and works with no problems.
Example: When I favorited an app before, the color fill of the heart icon would change, but not the number, since the database is not updating with every favorite. eg. (30 --> 30)
Now, if I favorite the app, the text goes from 30 --> 31, which instantly provides feedback that you indeed favorited the app, and the number has changed.
Hopefully this will help the website feel more snappy and efficient with favorite handling.