From 893dba59ca45909fe50dfaaee61d5234dd458342 Mon Sep 17 00:00:00 2001 From: Piotr Gniado Date: Tue, 11 Nov 2025 16:04:52 +0100 Subject: [PATCH] fix(network): Fix getting fallback DNS server - Fix getting fallback DNS server using NetworkInterface::dnsIP() getter - Remove magic number from NetworkInterface::dnsIP() setter --- libraries/Network/src/NetworkInterface.cpp | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/libraries/Network/src/NetworkInterface.cpp b/libraries/Network/src/NetworkInterface.cpp index 94675e65e12..393d2b9cf7f 100644 --- a/libraries/Network/src/NetworkInterface.cpp +++ b/libraries/Network/src/NetworkInterface.cpp @@ -352,7 +352,7 @@ bool NetworkInterface::enableIPv6(bool en) { } bool NetworkInterface::dnsIP(uint8_t dns_no, IPAddress ip) { - if (_esp_netif == NULL || dns_no > 2) { + if (_esp_netif == NULL || dns_no >= ESP_NETIF_DNS_MAX) { return false; } esp_netif_flags_t flags = esp_netif_get_flags(_esp_netif); @@ -708,11 +708,11 @@ IPAddress NetworkInterface::gatewayIP() const { } IPAddress NetworkInterface::dnsIP(uint8_t dns_no) const { - if (_esp_netif == NULL) { + if (_esp_netif == NULL || dns_no >= ESP_NETIF_DNS_MAX) { return IPAddress(); } esp_netif_dns_info_t d; - if (esp_netif_get_dns_info(_esp_netif, dns_no ? ESP_NETIF_DNS_BACKUP : ESP_NETIF_DNS_MAIN, &d) != ESP_OK) { + if (esp_netif_get_dns_info(_esp_netif, (esp_netif_dns_type_t)dns_no, &d) != ESP_OK) { return IPAddress(); } if (d.ip.type == ESP_IPADDR_TYPE_V6) {