Skip to content

Commit c409993

Browse files
authored
feat(uart): logging for UART signal inversion
Added logging for signal inversion in UART functions.
1 parent 06b2dfa commit c409993

File tree

1 file changed

+21
-4
lines changed

1 file changed

+21
-4
lines changed

cores/esp32/esp32-hal-uart.c

Lines changed: 21 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -879,6 +879,7 @@ uart_t *uartBegin(
879879
retCode &= ESP_OK == uart_set_line_inverse(uart_nr, _inv_mask);
880880
if (retCode) {
881881
uart->inv_mask = _inv_mask;
882+
log_v("Inverted RX and TX signals within UART%d", uart_nr);
882883
}
883884
} else {
884885
// disable invert signal for both Rx and Tx
@@ -1010,19 +1011,35 @@ bool uartPinSignalInversion(uart_t *uart, uint32_t invMask, bool inverted) {
10101011
}
10111012

10121013
bool uartSetRxInvert(uart_t *uart, bool invert) {
1013-
return uartPinSignalInversion(uart, UART_SIGNAL_RXD_INV, invert);
1014+
if (uartPinSignalInversion(uart, UART_SIGNAL_RXD_INV, invert)) {
1015+
log_v("UART%d: RX signal is now inverted", uart->num);
1016+
return true;
1017+
}
1018+
return false;
10141019
}
10151020

10161021
bool uartSetTxInvert(uart_t *uart, bool invert) {
1017-
return uartPinSignalInversion(uart, UART_SIGNAL_TXD_INV, invert);
1022+
if (uartPinSignalInversion(uart, UART_SIGNAL_TXD_INV, invert)) {
1023+
log_v("UART%d: TX signal is now inverted", uart->num);
1024+
return true;
1025+
}
1026+
return false;
10181027
}
10191028

10201029
bool uartSetCtsInvert(uart_t *uart, bool invert) {
1021-
return uartPinSignalInversion(uart, UART_SIGNAL_CTS_INV, invert);
1030+
if (uartPinSignalInversion(uart, UART_SIGNAL_CTS_INV, invert)) {
1031+
log_v("UART%d: CTS signal is now inverted", uart->num);
1032+
return true;
1033+
}
1034+
return false;
10221035
}
10231036

10241037
bool uartSetRtsInvert(uart_t *uart, bool invert) {
1025-
return uartPinSignalInversion(uart, UART_SIGNAL_RTS_INV, invert);
1038+
if (uartPinSignalInversion(uart, UART_SIGNAL_RTS_INV, invert)) {
1039+
log_v("UART%d: RTS signal is now inverted", uart->num);
1040+
return true;
1041+
}
1042+
return false;
10261043
}
10271044

10281045
uint32_t uartAvailable(uart_t *uart) {

0 commit comments

Comments
 (0)