Apply suggestions from code review

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Author: P-R-O-C-H-Y

docs/en/zigbee/ep_color_dimmable_light.rst

@@ -352,8 +352,8 @@ Gets the current active color mode.
     uint8_t getLightColorMode();
 
 This function will return current color mode:
-* ``ZIGBEE_COLOR_MODE_CURRENT_X_Y`` (0x01) - XY/RGB mode
 * ``ZIGBEE_COLOR_MODE_HUE_SATURATION`` (0x00) - HSV mode
+* ``ZIGBEE_COLOR_MODE_CURRENT_X_Y`` (0x01) - XY/RGB mode
 * ``ZIGBEE_COLOR_MODE_TEMPERATURE`` (0x02) - Temperature mode
 
 getLightColorHue

libraries/Zigbee/keywords.txt

@@ -123,7 +123,7 @@ getLightColorMode	KEYWORD2
 getLightColorHue	KEYWORD2
 getLightColorSaturation	KEYWORD2
 getLightColorCapabilities	KEYWORD2
-onLightChange	KEYWORD2	KEYWORD2
+onLightChange	KEYWORD2
 onLightChangeRgb	KEYWORD2
 onLightChangeHsv	KEYWORD2
 onLightChangeTemp	KEYWORD2
@@ -133,7 +133,6 @@ onLightLevelChangeWithSource	KEYWORD2
 onLightStateChange	KEYWORD2
 onLightStateChangeWithSource	KEYWORD2
 
-
 # ZigbeeSwitch + ZigbeeColorDimmerSwitch
 lightToggle	KEYWORD2
 lightOn	KEYWORD2

libraries/Zigbee/src/ep/ZigbeeColorDimmableLight.cpp

@@ -26,15 +26,15 @@ ZigbeeColorDimmableLight::ZigbeeColorDimmableLight(uint8_t endpoint) : ZigbeeEP(
   uint8_t hue = 0;
   uint8_t saturation = 0;
 
-  //Add support for Hue and Saturation
-  uint16_t color_attr = ESP_ZB_ZCL_COLOR_CONTROL_COLOR_TEMPERATURE_DEF_VALUE;
+  // Add support for Color Temperature and Hue Saturation attributes
+  uint16_t color_temperature = ESP_ZB_ZCL_COLOR_CONTROL_COLOR_TEMPERATURE_DEF_VALUE;
   uint16_t min_temp = ESP_ZB_ZCL_COLOR_CONTROL_COLOR_TEMP_PHYSICAL_MIN_MIREDS_DEFAULT_VALUE;
   uint16_t max_temp = ESP_ZB_ZCL_COLOR_CONTROL_COLOR_TEMP_PHYSICAL_MAX_MIREDS_DEFAULT_VALUE;
 
   esp_zb_attribute_list_t *color_cluster = esp_zb_cluster_list_get_cluster(_cluster_list, ESP_ZB_ZCL_CLUSTER_ID_COLOR_CONTROL, ESP_ZB_ZCL_CLUSTER_SERVER_ROLE);
   esp_zb_color_control_cluster_add_attr(color_cluster, ESP_ZB_ZCL_ATTR_COLOR_CONTROL_CURRENT_HUE_ID, &hue);
   esp_zb_color_control_cluster_add_attr(color_cluster, ESP_ZB_ZCL_ATTR_COLOR_CONTROL_CURRENT_SATURATION_ID, &saturation);
-  esp_zb_color_control_cluster_add_attr(color_cluster, ESP_ZB_ZCL_ATTR_COLOR_CONTROL_COLOR_TEMPERATURE_ID, &color_attr);
+  esp_zb_color_control_cluster_add_attr(color_cluster, ESP_ZB_ZCL_ATTR_COLOR_CONTROL_COLOR_TEMPERATURE_ID, &color_temperature);
   esp_zb_color_control_cluster_add_attr(color_cluster, ESP_ZB_ZCL_ATTR_COLOR_CONTROL_COLOR_TEMP_PHYSICAL_MIN_MIREDS_ID, &min_temp);
   esp_zb_color_control_cluster_add_attr(color_cluster, ESP_ZB_ZCL_ATTR_COLOR_CONTROL_COLOR_TEMP_PHYSICAL_MAX_MIREDS_ID, &max_temp);
   uint8_t color_mode = ESP_ZB_ZCL_COLOR_CONTROL_COLOR_MODE_DEFAULT_VALUE;

libraries/Zigbee/src/ep/ZigbeeColorDimmableLight.h

@@ -68,7 +68,7 @@
 #define ZIGBEE_COLOR_CAPABILITY_HUE_SATURATION  (1 << 0)  // Bit 0: Hue/saturation supported
 #define ZIGBEE_COLOR_CAPABILITY_ENHANCED_HUE    (1 << 1)  // Bit 1: Enhanced hue supported
 #define ZIGBEE_COLOR_CAPABILITY_COLOR_LOOP      (1 << 2)  // Bit 2: Color loop supported
-#define ZIGBEE_COLOR_CAPABILITY_X_Y            (1 << 3)  // Bit 3: XY supported
+#define ZIGBEE_COLOR_CAPABILITY_X_Y            (1 << 3)  // Bit 3: X/Y supported
 #define ZIGBEE_COLOR_CAPABILITY_COLOR_TEMP     (1 << 4)  // Bit 4: Color temperature supported
 
 // Color mode enum values (matching ZCL spec)
@@ -146,8 +146,6 @@ class ZigbeeColorDimmableLight : public ZigbeeEP {
     return _color_capabilities;
   }
 
-
-
 private:
   void zbAttributeSet(const esp_zb_zcl_set_attr_value_message_t *message) override;
   bool setLightColorMode(uint8_t color_mode);