Skip to content

Commit c005518

Browse files
authored
Merge pull request #19 from erichlf/update-readme
Update README for latest connect changes
2 parents d5fd47a + cf57130 commit c005518

File tree

2 files changed

+5
-4
lines changed

2 files changed

+5
-4
lines changed

README.md

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -97,13 +97,16 @@ make assumptions about how you work.
9797
-- start from scratch
9898
remove_existing_container = true,
9999
-- By default, if no extra config is added, following nvim_dotfiles are
100-
-- installed: "https://github.com/LazyVim/starter"
100+
-- installed: "https://github.com/erichlf/dotfiles"
101101
-- This is an example for configuring other dotfiles inside the docker container
102102
dotfiles_repository = "https://github.com/erichlf/dotfiles.git",
103103
dotfiles_branch = "main", -- branch to clone from dotfiles_repository`
104104
dotfiles_targetPath = "~/dotfiles", -- location to install dotfiles
105105
dotfiles_intallCommand = "install.sh", -- script to run after dotfiles are cloned
106106
shell = "bash", -- shell to use when executing commands
107+
-- The particular binary to use for connecting to in the devcontainer
108+
-- Most likely this should remain nvim
109+
nvim_binary = "nvim",
107110
},
108111
keys = {
109112
-- stylua: ignore
@@ -203,4 +206,4 @@ make test
203206
5. [x] Add unit tests using plenary.busted lua module.
204207
6. [ ] The logs printed in the floating window when preparing the Devcontainer
205208
are saved and easy to access.
206-
7. [ ] Convert bash scripts in lua code.
209+
7. [x] Convert bash scripts in lua code.

lua/devcontainer-cli/config.lua

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -49,8 +49,6 @@ local default_config = {
4949
-- The shell to use for executing command. Available sh, bash, zsh or any
5050
-- other that uses '-c' to signify a command is to follow
5151
shell = 'bash',
52-
-- The name of the socket file to use
53-
port = "7777",
5452
}
5553

5654
local options

0 commit comments

Comments
 (0)