Skip to content

Commit d3ecde6

Browse files
authored
Remove a couple of asserts from display_list_unittest (flutter#173381)
Skia is updating some of the semantics around SkPath simple shape inference [1]. Specifically, degenerate rounded rects are to be reflected as simple rects instead of rrects. The display list assertions should be sufficient for these tests. This PR unblocks the Skia-side change. [1] https://skia-review.googlesource.com/c/skia/+/1031900 ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [ ] I updated/added relevant documentation (doc comments with `///`). - [ ] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing.
1 parent 601cde6 commit d3ecde6

File tree

1 file changed

+0
-2
lines changed

1 file changed

+0
-2
lines changed

engine/src/flutter/display_list/display_list_unittests.cc

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5251,7 +5251,6 @@ TEST_F(DisplayListTest, ClipRectRRectPathPromoteToClipRect) {
52515251
DlRoundRect clip_rrect = DlRoundRect::MakeRect(clip_rect);
52525252
DlRect draw_rect = clip_rect.Expand(2.0f, 2.0f);
52535253
DlPath clip_path = DlPath::MakeRoundRect(clip_rrect);
5254-
ASSERT_TRUE(clip_path.IsRoundRect());
52555254

52565255
DisplayListBuilder builder;
52575256
builder.ClipPath(clip_path, DlClipOp::kIntersect, false);
@@ -5272,7 +5271,6 @@ TEST_F(DisplayListTest, ClipOvalRRectPathPromoteToClipOval) {
52725271
DlRoundRect clip_rrect = DlRoundRect::MakeOval(clip_rect);
52735272
DlRect draw_rect = clip_rect.Expand(2.0f, 2.0f);
52745273
DlPath clip_path = DlPath::MakeRoundRect(clip_rrect);
5275-
ASSERT_TRUE(clip_path.IsRoundRect());
52765274

52775275
DisplayListBuilder builder;
52785276
builder.ClipPath(clip_path, DlClipOp::kIntersect, false);

0 commit comments

Comments
 (0)