libsdl.js and self-compiled SDL2 confusion

[magist3r]

Emscripten v. 3.1.46, but also present in main.

It's more like a question then a bugreport, but please help me understand this.
If I build my own SDL2 library for Emscripten and provide -sUSE_SDL=0 (which is the default anyway), why old SDL1 libsdl.js is pulled by default?

emscripten/src/modules.mjs

Lines 146 to 148 in efa2897

	if (USE_SDL != 2) {
	libraries.push('libsdl.js');
	}

It is not needed for -sUSE_SDL2 based on this line

emscripten/src/modules.mjs

Lines 156 to 158 in efa2897

	if (USE_SDL == 2) {
	libraries.push('libegl.js', 'libwebgl.js', 'libhtml5_webgl.js');
	}

Is it a bug or is it intentional?

Thanks.

[sbc100]

Yes line 146 should probably be if (USE_SDL == 1) {. In practice is probably doesn't matter since your SDL2 library will take precedence of the JS one.

I will update line 146 now..

[sbc100]

Fix is in #26275