Fix other.test_embind (#18866)

The test was not actually using the three compiler flags we tried to test there.
Use getCompilerSetting which is a standard way to do this, that also asserts
internally on the setting being properly defined.

Author: kripken

test/embind/embind.test.js

@@ -378,7 +378,7 @@ module({
     });
 
     BaseFixture.extend("string", function() {
-        var stdStringIsUTF8 = (cm['EMBIND_STD_STRING_IS_UTF8'] === true);
+        var stdStringIsUTF8 = (cm.getCompilerSetting('EMBIND_STD_STRING_IS_UTF8') === true);
 
         test("non-ascii strings", function() {
 
@@ -642,7 +642,7 @@ module({
             assert.throws(TypeError, function() { cm.const_ref_adder(0n, 1); });
         });
 
-        if (cm['ASSERTIONS']) {
+        if (cm.getCompilerSetting('ASSERTIONS')) {
             test("can pass only number and boolean as floats with assertions", function() {
                 assert.throws(TypeError, function() { cm.const_ref_adder(1, undefined); });
                 assert.throws(TypeError, function() { cm.const_ref_adder(1, null); });
@@ -824,7 +824,7 @@ module({
             assert.equal("-2147483648", cm.long_to_string(-2147483648));
 
             // passing out of range values should fail with assertions.
-            if (cm['ASSERTIONS']) {
+            if (cm.getCompilerSetting('ASSERTIONS')) {
                 assert.throws(TypeError, function() { cm.char_to_string(-129); });
                 assert.throws(TypeError, function() { cm.char_to_string(128); });
                 assert.throws(TypeError, function() { cm.signed_char_to_string(-129); });
@@ -863,7 +863,7 @@ module({
             assert.equal(2147483648, cm.load_unsigned_long());
         });
 
-        if (cm['ASSERTIONS']) {
+        if (cm.getCompilerSetting('ASSERTIONS')) {
             test("throws type error when attempting to coerce null to int", function() {
                 var e = assert.throws(TypeError, function() {
                     cm.int_to_string(null);
@@ -1044,13 +1044,13 @@ module({
 
             assert.equal(undefined, vec.get(4));
             // only test a negative index without assertions.
-            if (!cm['ASSERTIONS']) {
+            if (!cm.getCompilerSetting('ASSERTIONS')) {
                 assert.equal(undefined, vec.get(-1));
             }
             vec.delete();
         });
 
-        if (cm['ASSERTIONS']) {
+        if (cm.getCompilerSetting('ASSERTIONS')) {
             test("out of type range array index throws with assertions", function() {
                 var vec = cm.emval_test_return_vector();
 
@@ -1445,7 +1445,7 @@ module({
             c.delete();
         });
 
-        if (cm['ASSERTIONS']) {
+        if (cm.getCompilerSetting('ASSERTIONS')) {
             test("assigning string or object to integer raises TypeError with assertions", function() {
                 var c = new cm.CustomStruct();
                 var e = assert.throws(TypeError, function() {
@@ -2509,7 +2509,8 @@ module({
 
     BaseFixture.extend("function names", function() {
         assert.equal('ValHolder', cm.ValHolder.name);
-        if (!cm['DYNAMIC_EXECUTION']) {
+
+        if (!cm.getCompilerSetting('DYNAMIC_EXECUTION')) {
           assert.equal('', cm.ValHolder.prototype.setVal.name);
           assert.equal('', cm.ValHolder.makeConst.name);
         } else {

test/embind/helpers.js

@@ -2742,10 +2742,10 @@ def test_embind(self, extra_args):
       (['-lembind', '-O1']),
       (['-lembind', '-O2']),
       (['-lembind', '-O2', '-sALLOW_MEMORY_GROWTH', test_file('embind/isMemoryGrowthEnabled=true.cpp')]),
+      (['-lembind', '-O2', '--closure=1']),
     ]
+    extra_args = extra_args + ['-sRETAIN_COMPILER_SETTINGS', '-sEXPORTED_RUNTIME_METHODS=getCompilerSetting']
     test_cases = [t + extra_args for t in test_cases]
-    # closure compiler doesn't work with DYNAMIC_EXECUTION=0
-    test_cases.append((['-lembind', '-O2', '--closure=1']))
     for args in test_cases:
       print(args)
       self.clear()
@@ -2760,13 +2760,10 @@ def test_embind(self, extra_args):
         [EMXX, test_file('embind/embind_test.cpp'),
          '--pre-js', test_file('embind/test.pre.js'),
          '--post-js', test_file('embind/test.post.js'),
-         '--js-library', test_file('embind/helpers.js'),
          '-sWASM_ASYNC_COMPILATION=0',
          # This test uses a `CustomSmartPtr` class which has 1MB of data embedded in
          # it which means we need more stack space than normal.
-         '-sSTACK_SIZE=2MB',
-         '-sDEFAULT_LIBRARY_FUNCS_TO_INCLUDE=$EMBIND_STD_STRING_IS_UTF8,$DYNAMIC_EXECUTION,$ASSERTIONS',
-         '-sEXPORTED_FUNCTIONS=EMBIND_STD_STRING_IS_UTF8,DYNAMIC_EXECUTION,ASSERTIONS'] + args)
+         '-sSTACK_SIZE=2MB'] + args)
 
       if '-sDYNAMIC_EXECUTION=0' in args:
         js_binary_str = read_file('a.out.js')