Merge pull request #9 from sakama/fix-error-handling

Fix error handling

Author: civitaspo

src/main/java/org/embulk/output/sftp/SftpFileOutput.java

@@ -8,6 +8,7 @@
 import org.apache.commons.vfs2.impl.StandardFileSystemManager;
 import org.apache.commons.vfs2.provider.sftp.IdentityInfo;
 import org.apache.commons.vfs2.provider.sftp.SftpFileSystemConfigBuilder;
+import org.embulk.config.ConfigException;
 import org.embulk.config.TaskReport;
 import org.embulk.spi.Buffer;
 import org.embulk.spi.Exec;
@@ -58,7 +59,7 @@ private StandardFileSystemManager initializeStandardFileSystemManager()
         }
         catch (FileSystemException e) {
             logger.error(e.getMessage());
-            throw new RuntimeException(e);
+            throw new ConfigException(e);
         }
 
         return manager;
@@ -92,7 +93,7 @@ private FileSystemOptions initializeFsOptions(PluginTask task)
         }
         catch (FileSystemException e) {
             logger.error(e.getMessage());
-            throw new RuntimeException(e);
+            throw new ConfigException(e);
         }
 
         return fsOptions;
@@ -142,7 +143,9 @@ public void add(Buffer buffer)
             logger.error(e.getMessage());
             Throwables.propagate(e);
         }
-        buffer.release();
+        finally {
+            buffer.release();
+        }
     }
 
     @Override
@@ -166,7 +169,7 @@ public void abort()
     @Override
     public TaskReport commit()
     {
-        return null;
+        return Exec.newTaskReport();
     }
 
 
@@ -199,7 +202,7 @@ private URI getSftpFileUri(String remoteFilePath)
         }
         catch (URISyntaxException e) {
             logger.error(e.getMessage());
-            throw new RuntimeException(e);
+            throw new ConfigException(e);
         }
     }