Move buffer.release() call to finally block

sakama · sakama · commit 7e5534d85312 · 2016-03-04T20:04:41.000+09:00
diff --git a/src/main/java/org/embulk/output/sftp/SftpFileOutput.java b/src/main/java/org/embulk/output/sftp/SftpFileOutput.java
@@ -137,7 +137,9 @@ public void add(Buffer buffer)
             logger.error(e.getMessage());
             Throwables.propagate(e);
         }
-        buffer.release();
+        finally {
+            buffer.release();
+        }
     }
 
     @Override

Original file line number	Diff line number	Diff line change
`@@ -137,7 +137,9 @@ public void add(Buffer buffer)`
`137`	`137`	`logger.error(e.getMessage());`
`138`	`138`	`Throwables.propagate(e);`
`139`	`139`	`}`
`140`		`- buffer.release();`
	`140`	`+ finally {`
	`141`	`+ buffer.release();`
	`142`	`+ }`
`141`	`143`	`}`
`142`	`144`
`143`	`145`	`@Override`