Bump some deps, update Ember to 3.28 (#923)

* Bump some deps

* ember-cli 3.28

* Bump some deps

* Bump ember-modal-dialog

* Fix lint

* Fix various things

* Remove debugger

* Fix some tests and deprecations

* Fix some computeds

* Fix some testing issues

* Back to params

* Use fork of render modifiers

* Use modal dialog fork

* Add macros

* Add embroider utils

* Remove embroider testing

Author: RobbieTheWagner

.eslintignore

@@ -13,6 +13,7 @@
 # misc
 /coverage/
 !.*
+.*/
 .eslintcache
 
 # ember-try

.eslintrc.js

@@ -45,24 +45,18 @@ module.exports = {
     // node files
     {
       files: [
-        '.eslintrc.js',
-        '.prettierrc.js',
-        '.template-lintrc.js',
-        'ember-cli-build.js',
-        'addon/styles/tailwind.js',
-        'index.js',
-        'testem.js',
-        'blueprints/*/index.js',
-        'config/**/*.js',
-        'lib/**/*.js',
-        'tests/dummy/config/**/*.js',
-        'tests-node/**/*.js',
-      ],
-      excludedFiles: [
-        'addon/**',
-        'addon-test-support/**',
-        'app/**',
-        'tests/dummy/app/**',
+        './.eslintrc.js',
+        './.prettierrc.js',
+        './.template-lintrc.js',
+        './ember-cli-build.js',
+        './index.js',
+        './testem.js',
+        './addon/styles/tailwind.js',
+        './blueprints/*/index.js',
+        './config/**/*.js',
+        './lib/**/*.js',
+        './tests/dummy/config/**/*.js',
+        './tests-node/**/*.js',
       ],
       parserOptions: {
         sourceType: 'script',
@@ -74,7 +68,6 @@ module.exports = {
       plugins: ['node'],
       extends: ['plugin:node/recommended'],
     },
-
     // node test files
     {
       globals: {
@@ -88,5 +81,10 @@ module.exports = {
         'node/no-unpublished-require': 'off',
       },
     },
+    {
+      // Test files:
+      files: ['tests/**/*-test.{js,ts}'],
+      extends: ['plugin:qunit/recommended'],
+    },
   ],
 };

.github/workflows/ci-cd.yml

@@ -123,14 +123,15 @@ jobs:
       fail-fast: true
       matrix:
         scenario:
-          - 'ember-lts-3.16'
           - 'ember-lts-3.20'
+          - 'ember-lts-3.24'
           - 'ember-release'
           - 'ember-beta'
           - 'ember-canary'
           - 'ember-default-with-jquery'
           - 'ember-classic'
-          - 'ember-concurrency-2.x'
+          # - 'embroider-safe'
+          # - 'embroider-optimized'
     timeout-minutes: 7
     steps:
       - name: Check out a copy of the repo

.npmignore

@@ -25,6 +25,7 @@
 /ember-cli-build.js
 /testem.js
 /tests/
+/yarn-error.log
 /yarn.lock
 .gitkeep
 

.prettierrc.js

@@ -2,4 +2,13 @@
 
 module.exports = {
   singleQuote: true,
+  overrides: [
+    {
+      files: '**/*.hbs',
+      options: {
+        parser: 'glimmer',
+        singleQuote: false,
+      },
+    },
+  ],
 };

README.md

@@ -9,9 +9,9 @@ ember-cli-addon-docs
 Compatibility
 ------------------------------------------------------------------------------
 
-* Ember.js v3.16 or above
-* Ember CLI v2.13 or above
-* Node.js v10 or above
+* Ember.js v3.20 or above
+* Ember CLI v3.20 or above
+* Node.js v12 or above
 
 **2/28/20 Update: AddonDocs is in Maintenace Mode.**
 

addon/components/api/x-component/template.hbs

@@ -9,7 +9,7 @@
       Show
     </panel.header>
 
-    {{#if hasToggles}}
+    {{#if this.hasToggles}}
       <Api::XToggles @toggles={{hash
           inherited=(if @component.hasInherited this.showInherited)
           internal=(if @component.hasInternal this.showInternal)
@@ -22,7 +22,7 @@
 {{/if}}
 
 
-{{#if hasContents}}
+{{#if this.hasContents}}
   <Api::XSections @sections={{hash
       constructors=this.constructors
       yields=this.yields

addon/components/api/x-import-path/component.js

@@ -8,14 +8,14 @@ export default Component.extend({
       <pre class="docs-md__code docs-whitespace-no-wrap">
         <span class="hljs-keyword">import</span>
 
-        {{#if (eq item.exportType "default")}}
-          {{item.name}}
+        {{#if (eq @item.exportType "default")}}
+          {{@item.name}}
         {{else}}
-        { {{item.name}} }
+        { {{@item.name}} }
         {{/if}}
 
         <span class="hljs-keyword">from</span>
-        <span class="hljs-string">'{{item.file}}'</span>;
+        <span class="hljs-string">'{{@item.file}}'</span>;
       </pre>
     </div>
   `,

addon/components/api/x-section/template.hbs

@@ -11,7 +11,7 @@
       </span>
     {{/if}}
 
-    {{#if (or @item.isClass item.isComponent)}}
+    {{#if (or @item.isClass @item.isComponent)}}
       <LinkTo @route="docs.api.item" @model={{concat "modules/" @item.id}} class="hover:underline">
         <strong>{{@item.name}}</strong>
       </LinkTo>

addon/components/api/x-sections/component.js

@@ -4,7 +4,7 @@ import Component from '@ember/component';
 export default Component.extend({
   tagName: '',
   layout: hbs`
-    {{#each-in sections as |sectionName items|}}
+    {{#each-in @sections as |sectionName items|}}
       {{#if items}}
         <section data-test-api-section class="item-section">
           <h2 data-test-section-header={{sectionName}} class="docs-h2">