Handle empty s3 response

After the update to AWS SDK v3 when searching for a revision the
Contents on the response is not present if the revision hasn't been
created yet. This seemed like the smallest change to fix the problem,
and optional chaining is supported in Node 14, but I had to bump up the
ecmaVersion in the eslint config to allow it.

Author: jrjohnson

.eslintrc.js

@@ -1,7 +1,7 @@
 module.exports = {
   root: true,
   parserOptions: {
-    ecmaVersion: 6,
+    ecmaVersion: 'latest',
     sourceType: 'module'
   },
   extends: 'eslint:recommended',

lib/s3.js

@@ -166,7 +166,7 @@ module.exports = CoreObject.extend({
     var revisionPrefix = joinUriSegments(prefix, options.filePattern + ":" + options.revisionKey);
 
     return listObjects({ Bucket: bucket, Prefix: revisionPrefix })
-      .then((response) => response.Contents.find((element) => element.Key === revisionPrefix));
+      .then((response) => response.Contents?.find((element) => element.Key === revisionPrefix));
   },
 
   fetchRevisions: function(options) {

tests/unit/lib/s3-test.js

@@ -242,6 +242,15 @@ describe('s3', function() {
         });
     });
 
+    it('succeeds when revision key search returns no values', function() {
+      s3Client.listObjects = function(params, cb) {
+        cb(undefined, {});
+      };
+      var promise = subject.upload(options);
+
+      return assert.isFulfilled(promise);
+    });
+
     describe("when revisionKey was already uploaded", function() {
       beforeEach(function() {
         options.revisionKey = "123";