Merge pull request #53 from jrjohnson/atime-fix

Fix invalid atime being set

Author: lukemelia

index.js

@@ -97,7 +97,7 @@ module.exports = {
             fs.stat(fullPath, function(err, stats) {
               if (err) resolve(); // ignore errors
               else {
-                fs.utimes(outFilePath, Date.now(), stats.mtime, function () {
+                fs.utimes(outFilePath, new Date(), stats.mtime, function () {
                   resolve();
                 });
               }

tests/index-test.js

@@ -141,7 +141,7 @@ describe('gzip plugin', function() {
       if (!fs.existsSync(context.distDir)) { fs.mkdirSync(context.distDir); }
       if (!fs.existsSync(path.join(context.distDir, 'assets'))) { fs.mkdirSync(path.join(context.distDir, 'assets')); }
       fs.writeFileSync(path.join(context.distDir, context.distFiles[0]), 'alert("Hello foo world!");', 'utf8');
-      fs.utimesSync(path.join(context.distDir, context.distFiles[0]), Date.now(), new Date("2020-01-01T00:01:02Z"));
+      fs.utimesSync(path.join(context.distDir, context.distFiles[0]), new Date(), new Date("2020-01-01T00:01:02Z"));
       fs.writeFileSync(path.join(context.distDir, context.distFiles[1]), 'alert("Hello bar world!");', 'utf8');
       fs.writeFileSync(path.join(context.distDir, context.distFiles[2]), 'alert("Hello ignore world!");', 'utf8');
       plugin.beforeHook(context);
@@ -187,7 +187,7 @@ describe('gzip plugin', function() {
           });
       });
 
-      it('has the same timestamp as the original', function(done) {
+      it('has the same mtime timestamp as the original', function(done) {
         assert.isFulfilled(plugin.willUpload(context))
           .then(function(result) {
             var mtime_gz = fs.statSync(path.join(context.distDir, result.gzippedFiles[0])).mtime.valueOf();
@@ -201,6 +201,20 @@ describe('gzip plugin', function() {
           });
       });
 
+      it('atime timestamp is slightly newer than the original', function(done) {
+        assert.isFulfilled(plugin.willUpload(context))
+          .then(function(result) {
+            var atime_gz = fs.statSync(path.join(context.distDir, result.gzippedFiles[0])).atime.valueOf();
+            var atime_orig = fs.statSync(path.join(context.distDir, context.distFiles[0])).atime.valueOf();
+
+            assert.ok(atime_gz - atime_orig < 1000);
+
+            done();
+          }).catch(function(reason){
+            done(reason);
+          });
+      });
+
       it('does not use the same object for gzippedFiles and distFiles', function(done) {
         assert.isFulfilled(plugin.willUpload(context))
           .then(function(result) {