From 60c6ab10fe88c1f261915e8e19b3fc6521634e71 Mon Sep 17 00:00:00 2001 From: kartikey1306 Date: Mon, 31 Aug 2026 22:38:57 +0530 Subject: [PATCH] fix(tests): restore the line continuation that unterminates TEST() in test_image_verify MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit master does not build. The TEST() macro in tests/unit/test_image_verify.c lost the backslash on one line: #define TEST(name) \ static void name(void); \ static void run_##name(void) { \ memset(sim_flash, 0xFF, sizeof(sim_flash)); \ sim_unreadable_from = UINT32_MAX; <-- no continuation sim_tick = 0; \ ... The macro therefore ends at that line, and every line after it -- the tick reset, eos_hal_init(), the printf, the call, the closing brace -- is parsed as file-scope code instead of macro body. That produces 24 errors that all look unrelated to the cause: error: redefinition of 'sim_tick' with a different type: 'int' vs 'uint32_t' error: conflicting types for 'eos_hal_init' error: conflicting types for 'printf' error: extraneous closing brace ('}') Restoring the backslash is the whole fix. before: 24 errors, ctest 13 of 19 failing after: 0 errors, ctest 19/19 pass Introduced by #70 (881f00c). It also means every TEST() in that file was running without its per-test reset of sim_unreadable_from and sim_tick, so the fixture state leaked between cases -- the file has not compiled since, so this never showed up as a wrong result, only as a build failure. `CI — eBoot` was already red on master for exactly this before I started. Co-Authored-By: Claude Opus 5 (1M context) --- tests/unit/test_image_verify.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/unit/test_image_verify.c b/tests/unit/test_image_verify.c index 6c11af0..9e44af9 100644 --- a/tests/unit/test_image_verify.c +++ b/tests/unit/test_image_verify.c @@ -91,7 +91,7 @@ static int tests_passed = 0; static void name(void); \ static void run_##name(void) { \ memset(sim_flash, 0xFF, sizeof(sim_flash)); \ - sim_unreadable_from = UINT32_MAX; + sim_unreadable_from = UINT32_MAX; \ sim_tick = 0; \ eos_hal_init(&sim_ops); \ printf(" %-50s ", #name); \