Skip to content

Commit 0ff619f

Browse files
committed
We don't know if there's a device ID
1 parent 68107af commit 0ff619f

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

crates/handlers/src/compat/login_sso_complete.rs

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -123,7 +123,8 @@ pub async fn get(
123123
user: &session.user,
124124
is_interactive: true,
125125
login_type: CompatLoginType::WebSso,
126-
// TODO should we predict a replacement?
126+
// We don't know if there's going to be a replacement until we received the device ID,
127+
// which happens too late.
127128
session_replaced: false,
128129
session_counts,
129130
requester: mas_policy::Requester {
@@ -254,7 +255,8 @@ pub async fn post(
254255
is_interactive: true,
255256
login_type: CompatLoginType::WebSso,
256257
session_counts,
257-
// TODO should we predict a replacement?
258+
// We don't know if there's going to be a replacement until we received the device ID,
259+
// which happens too late.
258260
session_replaced: false,
259261
requester: mas_policy::Requester {
260262
ip_address: activity_tracker.ip(),

0 commit comments

Comments
 (0)