update Create Object action, add utils tests

Author: shulkaolka

lib/actions/createObject.js

@@ -1,60 +1,34 @@
-const _ = require('lodash');
 const { messages } = require('elasticio-node');
-const { SalesforceEntity } = require('../entry.js');
-const MetaLoader = require('../helpers/metaLoader');
-const sfConnection = require('../helpers/sfConnection.js');
+const { processMeta } = require('../helpers/utils');
 const attachment = require('../helpers/attachment.js');
+const { callJSForceMethod } = require('../helpers/wrapper');
 
-exports.objectTypes = function objectTypes(configuration) {
-  const metaLoader = new MetaLoader(configuration, this);
-  return metaLoader.getCreateableObjectTypes();
+exports.objectTypes = async function objectTypes(configuration) {
+  return callJSForceMethod.call(this, configuration, 'getCreateableObjectTypes');
+};
+
+exports.getMetaModel = async function getMetaModel(configuration) {
+  const meta = await callJSForceMethod.call(this, configuration, 'describe');
+  return processMeta(meta, 'create');
 };
 
 exports.process = async function createObject(message, configuration) {
   this.logger.info(`Preparing to create a ${configuration.sobject} object...`);
-
-  const sfConn = sfConnection.createConnection(configuration, this);
-
-  this.logger.debug('Creating message body: ', message.body);
-
-  const binaryField = await attachment.prepareBinaryData(message, configuration, sfConn, this);
+  this.logger.info('Starting Upsert Object Action');
+  const binaryField = await attachment.prepareBinaryData(message, configuration, this);
 
   this.logger.info('Sending request to SalesForce...');
+  const response = await callJSForceMethod.call(this, configuration, 'sobjectCreate', message);
 
-  try {
-    const response = await sfConn.sobject(configuration.sobject).create(message.body);
+  this.logger.debug('SF response: ', response);
+  this.logger.info(`${configuration.sobject} has been successfully created (ID = ${response.id}).`);
+  // eslint-disable-next-line no-param-reassign
+  message.body.id = response.id;
 
-    this.logger.debug('SF response: ', response);
-    this.logger.info(`${configuration.sobject} has been successfully created (ID = ${response.id}).`);
+  if (binaryField) {
     // eslint-disable-next-line no-param-reassign
-    message.body.id = response.id;
-
-    if (binaryField) {
-      // eslint-disable-next-line no-param-reassign
-      delete message.body[binaryField.name];
-    }
-
-    return messages.newMessageWithBody(message.body);
-  } catch (err) {
-    return this.emit('error', err);
+    delete message.body[binaryField.name];
   }
-};
 
-exports.getMetaModel = function getMetaModel(cfg, cb) {
-  const entity = new SalesforceEntity(this);
-  entity.getInMetaModel(cfg, (err, data) => {
-    if (err) {
-      return cb(err);
-    }
-    // eslint-disable-next-line no-param-reassign
-    data.out = _.cloneDeep(data.in);
-    // eslint-disable-next-line no-param-reassign
-    data.out.properties.id = {
-      type: 'string',
-      required: true,
-      readonly: true,
-      title: 'ObjectID',
-    };
-    return cb(null, data);
-  });
+  return messages.newMessageWithBody(message.body);
 };

lib/actions/upsert.js

@@ -54,7 +54,7 @@ module.exports.process = async function upsertObject(message, configuration) {
   if (lookupResults.length === 1) {
     this.logger.info('sobject=%s was successfully upserted by %s=%s', sobject, configuration.lookupField, message.body[configuration.lookupField]);
     this.logger.debug('Emitting data: %j', lookupResults[0]);
-    this.emit('data', messages.newMessageWithBody(lookupResults[0]));
+    await this.emit('data', messages.newMessageWithBody(lookupResults[0]));
     return;
   }
   if (lookupResults.length > 1) {

lib/helpers/utils.js

@@ -29,6 +29,12 @@ const TYPES_MAP = {
   url: 'string',
 };
 
+const META_TYPES_MAP = {
+  lookup: 'lookup',
+  upsert: 'upsert',
+  create: 'create',
+};
+
 /**
  * This method returns a property description for e.io proprietary schema
  *
@@ -102,18 +108,18 @@ exports.processMeta = async function processMeta(meta, metaType, lookupField) {
   const outProp = result.out.properties;
   let fields = await meta.fields.filter(field => !field.deprecatedAndHidden);
 
-  if (metaType !== 'lookup') {
+  if (metaType === META_TYPES_MAP.create || metaType === META_TYPES_MAP.upsert) {
     fields = await fields.filter(field => field.updateable && field.createable);
   }
   await fields.forEach((field) => {
-    if (metaType === 'lookup' && field.name === lookupField) {
+    if (metaType === META_TYPES_MAP.lookup && field.name === lookupField) {
       inProp[field.name] = createProperty(field);
-    } else if (metaType !== 'lookup' && field.createable) {
+    } else if (metaType !== META_TYPES_MAP.lookup && field.createable) {
       inProp[field.name] = createProperty(field);
     }
     outProp[field.name] = createProperty(field);
   });
-  if (metaType === 'upsert') {
+  if (metaType === META_TYPES_MAP.upsert) {
     Object.keys(inProp).forEach((key) => {
       inProp[key].required = false;
     });
@@ -123,5 +129,11 @@ exports.processMeta = async function processMeta(meta, metaType, lookupField) {
       title: 'Id',
     };
   }
+  if (metaType === META_TYPES_MAP.create) {
+    outProp.id = {
+      type: 'string',
+      required: true,
+    };
+  }
   return result;
 };

lib/salesForceClient.js

@@ -43,6 +43,10 @@ class SalesForceClient {
     return this.getSObjectList('updateable/createable sobject', object => object.updateable && object.createable);
   }
 
+  async getCreateableObjectTypes() {
+    return this.getSObjectList('createable sobject', object => object.createable);
+  }
+
   async queryEmitAll(query) {
     const result = [];
     await new Promise((resolve, reject) => {
@@ -122,6 +126,12 @@ class SalesForceClient {
     return results;
   }
 
+  async sobjectCreate(options) {
+    const sobject = options.sobject || this.configuration.sobject;
+    const { body } = options;
+    return this.connection.sobject(sobject).create(body);
+  }
+
   async sobjectUpdate(options) {
     const sobject = options.sobject || this.configuration.sobject;
     const { body } = options;

spec-integration/actions/createObject.spec.js

@@ -0,0 +1,71 @@
+/* eslint-disable no-return-assign */
+const fs = require('fs');
+const logger = require('@elastic.io/component-logger')();
+const { expect } = require('chai');
+const sinon = require('sinon');
+const nock = require('nock');
+const action = require('../../lib/actions/createObject');
+
+describe('creare object action', async () => {
+  let emitter;
+  const secretId = 'secretId';
+  let configuration;
+  let secret;
+
+  before(async () => {
+    emitter = {
+      emit: sinon.spy(),
+      logger,
+    };
+    if (fs.existsSync('.env')) {
+      // eslint-disable-next-line global-require
+      require('dotenv').config();
+    }
+    process.env.ELASTICIO_API_URI = 'https://app.example.io';
+    process.env.ELASTICIO_API_USERNAME = 'user';
+    process.env.ELASTICIO_API_KEY = 'apiKey';
+    process.env.ELASTICIO_WORKSPACE_ID = 'workspaceId';
+    secret = {
+      data: {
+        attributes: {
+          credentials: {
+            access_token: process.env.ACCESS_TOKEN,
+            instance_url: process.env.INSTANCE_URL,
+          },
+        },
+      },
+    };
+
+    configuration = {
+      secretId,
+    };
+
+    nock(process.env.ELASTICIO_API_URI)
+      .get(`/v2/workspaces/${process.env.ELASTICIO_WORKSPACE_ID}/secrets/${secretId}`)
+      .times(10)
+      .reply(200, secret);
+  });
+  afterEach(() => {
+    emitter.emit.resetHistory();
+  });
+
+  it('should succeed selectModel objectTypes', async () => {
+    const result = await action.objectTypes.call(emitter, configuration);
+    expect(result.Contact).to.eql('Contact');
+  });
+
+  it('should succeed process create sobject=Contact', async () => {
+    const cfg = {
+      ...configuration,
+      sobject: 'Contact',
+    };
+    const message = {
+      body: {
+        LastName: 'IntegrationTest',
+      },
+    };
+    const result = await action.process.call(emitter, message, cfg);
+    expect(result.body.LastName).to.eql('IntegrationTest');
+    expect(Object.prototype.hasOwnProperty.call(result.body, 'id')).to.eql(true);
+  });
+});