PR feedback

Author: tobio

internal/elasticsearch/ml/datafeed_state/schema.go

@@ -57,6 +57,7 @@ func GetSchema() schema.Schema {
 				MarkdownDescription: "The desired state for the ML datafeed. Valid values are `started` and `stopped`.",
 				Required:            true,
 				Validators: []validator.String{
+					// We don't allow starting/stopping here since they're transient states
 					stringvalidator.OneOf(string(datafeed.StateStarted), string(datafeed.StateStopped)),
 				},
 			},

internal/elasticsearch/ml/datafeed_state/update.go

@@ -175,7 +175,7 @@ func (r *mlDatafeedStateResource) performStateTransition(ctx context.Context, cl
 	// Return early if no state change is needed
 	if currentState == desiredState {
 		tflog.Debug(ctx, fmt.Sprintf("ML datafeed %s is already in desired state %s", datafeedId, desiredState))
-		return false, nil
+		return true, nil
 	}
 
 	// Initiate the state change

internal/models/ml.go

@@ -125,10 +125,10 @@ type DatafeedNode struct {
 
 // DatafeedRunning represents the running state of a datafeed
 type DatafeedRunning struct {
-	RealTimeConfigured bool                   `json:"real_time_configured"`
-	RealTimeRunning    bool                   `json:"real_time_running"`
-	SearchInterval     DatafeedSearchInterval `json:"search_interval,omitempty"`
-	LastEndTime        *time.Time             `json:"last_end_time,omitempty"`
+	RealTimeConfigured bool                    `json:"real_time_configured"`
+	RealTimeRunning    bool                    `json:"real_time_running"`
+	SearchInterval     *DatafeedSearchInterval `json:"search_interval,omitempty"`
+	LastEndTime        *time.Time              `json:"last_end_time,omitempty"`
 }
 
 type DatafeedTimingStats struct {

internal/utils/customtypes/memory_size_value.go

@@ -65,7 +65,7 @@ func (v MemorySize) StringSemanticEquals(_ context.Context, newValuable basetype
 	newValue, ok := newValuable.(MemorySize)
 	if !ok {
 		diags.AddError(
-			"Semantic Equality Check Error",
+			"Semantic equality check error",
 			"An unexpected value type was received while performing semantic equality checks. "+
 				"Please report this to the provider developers.\n\n"+
 				"Expected Value Type: "+fmt.Sprintf("%T", v)+"\n"+
@@ -104,19 +104,19 @@ func (v MemorySize) ConvertToMB() (int64, diag.Diagnostics) {
 	var diags diag.Diagnostics
 
 	if v.IsNull() {
-		diags.Append(diag.NewErrorDiagnostic("Memory Size Parse error", "memory size string value is null"))
+		diags.Append(diag.NewErrorDiagnostic("Memory size parse error", "memory size string value is null"))
 		return 0, diags
 	}
 
 	if v.IsUnknown() {
-		diags.Append(diag.NewErrorDiagnostic("Memory Size Parse Error", "memory size string value is unknown"))
+		diags.Append(diag.NewErrorDiagnostic("Memory size parse error", "memory size string value is unknown"))
 		return 0, diags
 	}
 
 	valueString := v.ValueString()
 	matches := memoryPattern.FindStringSubmatch(valueString)
 	if len(matches) != 3 {
-		diags.Append(diag.NewErrorDiagnostic("Memory Size Parse Error",
+		diags.Append(diag.NewErrorDiagnostic("Memory size parse error",
 			fmt.Sprintf("invalid memory size format: %s", valueString)))
 		return 0, diags
 	}
@@ -125,7 +125,7 @@ func (v MemorySize) ConvertToMB() (int64, diag.Diagnostics) {
 	numStr := matches[1]
 	num, err := strconv.ParseInt(numStr, 10, 64)
 	if err != nil {
-		diags.Append(diag.NewErrorDiagnostic("Memory Size Parse Error",
+		diags.Append(diag.NewErrorDiagnostic("Memory size parse error",
 			fmt.Sprintf("invalid number in memory size: %s", numStr)))
 		return 0, diags
 	}
@@ -146,7 +146,7 @@ func (v MemorySize) ConvertToMB() (int64, diag.Diagnostics) {
 	case "": // no unit = bytes
 		bytes = num
 	default:
-		diags.Append(diag.NewErrorDiagnostic("Memory Size Parse Error",
+		diags.Append(diag.NewErrorDiagnostic("Memory size parse error",
 			fmt.Sprintf("unsupported memory unit: %s", unit)))
 		return 0, diags
 	}