Skip to content

Conversation

@ansssu
Copy link

@ansssu ansssu commented Mar 6, 2023

Propagate errors on items. Fix #179

@elasticmachine
Copy link
Collaborator

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@cla-checker-service
Copy link

cla-checker-service bot commented Mar 6, 2023

💚 CLA has been signed

@TCheruy
Copy link

TCheruy commented Aug 6, 2025

@Anaethelion (as last main contributor) would you mind taking a look at this PR when you get a chance? #179 has been going on for a long time and prevents from using the bulk indexer in many production use-cases where visibility into failed writes is needed.

* makes code DRYer
* fixes bug where `res.IsError()` resulted in BulkIndexerItem.OnError receiving a nil `err`
@prodsecmachine
Copy link

prodsecmachine commented Nov 13, 2025

Snyk checks have passed. No issues have been found so far.

Status Scanner Critical High Medium Low Total (0)
Licenses 0 0 0 0 0 issues
Open Source Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@MattDevy
Copy link
Contributor

Hi all, I've added some tests to cover the new behaviour, with a slight refactor to make the code more DRY and a minor bug fix. This will be sorted soon, thank you for your patience and for your contribution!

@MattDevy MattDevy requested a review from Anaethelion November 13, 2025 13:42
@MattDevy MattDevy added the bug label Nov 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

BulkIndexer do not provide info to BulkIndexerItem on global worker.flush error

5 participants