Merge pull request #2175 from elastic/fix/2173

Fix IsValid logic error in UpdateByQuery response

Author: gmarz

src/Nest/Document/Multiple/UpdateByQuery/UpdateByQueryResponse.cs

@@ -41,7 +41,7 @@ public interface IUpdateByQueryResponse : IResponse
 
 	public class UpdateByQueryResponse : ResponseBase, IUpdateByQueryResponse
 	{
-		public override bool IsValid => this.ApiCall?.HttpStatusCode == 200 || !this.Failures.HasAny();
+		public override bool IsValid => this.ApiCall?.HttpStatusCode == 200 && !this.Failures.HasAny();
 
 		public long Took { get; internal set; }
 

src/Tests/Reproduce/GithubIssue2173.cs

@@ -0,0 +1,24 @@
+using FluentAssertions;
+using System;
+using System.Collections.Generic;
+using System.Linq;
+using System.Text;
+using System.Threading.Tasks;
+using Tests.Framework;
+using Tests.Framework.MockData;
+
+namespace Tests.Reproduce
+{
+	public class GithubIssue2173
+	{
+		[I]
+		public void UpdateByQueryWithInvalidScript()
+		{
+			var client = TestClient.GetClient();
+			var response = client.UpdateByQuery<Project>(typeof(Project), typeof(Project), u => u
+				.Script("invalid groovy")
+			);
+			response.IsValid.Should().BeFalse();
+		}
+	}
+}

src/Tests/Tests.csproj

@@ -570,6 +570,7 @@
     <Compile Include="Reproduce\GithubIssue2101.cs" />
     <Compile Include="Reproduce\GithubIssue2152.cs" />
     <Compile Include="Reproduce\GithubIssue2052.cs" />
+    <Compile Include="Reproduce\GithubIssue2173.cs" />
     <Compile Include="Search\Search\Rescoring\RescoreUsageTests.cs" />
     <Compile Include="XPack\Security\ClearCachedRealms\ClearCachedRealmsApiTests.cs" />
     <Compile Include="XPack\Security\ClearCachedRealms\ClearCachedRealmsUrlTests.cs" />

src/Tests/tests.yaml

@@ -1,5 +1,5 @@
 # mode either u (unit test), i (integration test) or m (mixed mode)
-mode: u
+mode: i
 # the elasticsearch version that should be started
 elasticsearch_version: 2.3.4
 # whether we want to forcefully reseed on the node, if you are starting the tests with a node already running